Help with function

[Theo324]

Hi guys, I have a function(), but am struggling to see what's wrong. The function is supposed to close a trade after not stop lossing or taking profit in 10 days, but it's not running correctly since I have a trade running for more than 30 days in my EA when looking at the holding time scatter plot (Attached)

The code I found and edited is attached here,

void CloseAllPositions()
{
for(int i=PositionsTotal()-1;i>0;i--)
{//go through all positions
int Ticket=PositionGetTicket(i);     //Get ticket # for current position
int PositionDirection = PositionGetInteger(POSITION_TYPE);
if(PositionDirection == POSITION_TYPE_BUY||PositionDirection == POSITION_TYPE_SELL)
{
trade.PositionClose(Ticket);
}
}
}

void OnTick()
  {
   double Ask=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_ASK),_Digits);
   double Bid=NormalizeDouble(SymbolInfoDouble(_Symbol,SYMBOL_BID),_Digits);

   datetime from = TimeToString(0,TIME_DATE);
   HistorySelect(from,TimeCurrent()); 
   int Deals=HistoryDealsTotal(); 
   datetime LastDealTime = HistoryDealGetInteger(Deals,DEAL_TIME);                     ///Time of Last Deal
   datetime LastDealTimeStringPlusOneHour = StringToTime(LastDealTime)+1*60*60;//1 hour
   datetime LastDealTimeStringPlus10Days = StringToTime(LastDealTime)+10*24*60*60;//10*24 hours
   bool HourAfter = (TimeCurrent()>LastDealTimeStringPlusOneHour); // delay after trade
  
   if(PositionsTotal()>0&&TimeCurrent()>LastDealTimeStringPlus10Days)
   {
   CloseAllPositions();
   }
}

[William Roeder]

1.    int Deals=HistoryDealsTotal(); 
      datetime LastDealTime = HistoryDealGetInteger(Deals,DEAL_TIME);                     ///Time of Last Deal
   

   Perhaps you should read the manual. When is a count a ticket?
   

   long  HistoryDealGetInteger(
      ulong                       ticket_number,     // Ticket
      ENUM_DEAL_PROPERTY_INTEGER  property_id        // Property identifier
      );

             Trade Functions / HistoryDealGetInteger - Reference on algorithmic/automated trading language for MetaTrader 5

2. datetime LastDealTime = HistoryDealGetInteger(Deals,DEAL_TIME);                     ///Time of Last Deal
   datetime LastDealTimeStringPlusOneHour = StringToTime(LastDealTime)+1*60*60;//1 hour

   What is the purpose of converting a datetime to a string to a datetime?
   

[lippmaje]

At least this does not look right:

for(int i=PositionsTotal()-1;i>0;i--)
{//go through all positions

When you loop back to front, make sure to catch element at position 0. Your condition needs to be i>=0.

Just my opinion from looking at your code, get help from a freelancer if your project is aiming at real money.