Has anyone used Marek's EA called MA_MA_2-35 ?
I think that's because as this code:
if (TotalOrdersCount() == 0)
and in the function TotalOrdersCount() -> if (OrderMagicNumber()==MagicNumber) result++;
that is not use _Symbol to count the number of open orders.
Thus, when EA already opened orders for EURUSD, the order for others _Symbol will not be opened.
Supposed to the function TotalOrdersCount(), added a code like this:
if (OrderSymbol() == _Symbol && OrderMagicNumber() == MagicNumber) result++;
I think so.
extern int MagicNumber=10001; extern double Lots =0.01; extern double StopLoss=30; extern double TakeProfit=60; extern int TrailingStop=50; extern int Slippage=3; //+------------------------------------------------------------------+ // expert start function //+------------------------------------------------------------------+ int start() { double MyPoint=Point; if(Digits==3 || Digits==5) MyPoint=Point*10; double TheStopLoss=0; double TheTakeProfit=0; if( TotalOrdersCount()==0 ) { int result=0; if((iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,2)<iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,2))&&(iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,1)>iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,1))) // Here is your open buy rule { result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"EA comment",MagicNumber,0,Blue); if(result>0) { TheStopLoss=0; TheTakeProfit=0; if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint; if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint; OrderSelect(result,SELECT_BY_TICKET); OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green); } return(0); } if((iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,2)>iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,2))&&(iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,1)<iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,1))) // Here is your open Sell rule { result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"EA comment",MagicNumber,0,Red); if(result>0) { TheStopLoss=0; TheTakeProfit=0; if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint; if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint; OrderSelect(result,SELECT_BY_TICKET); OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green); } return(0); } } for(int cnt=0;cnt<OrdersTotal();cnt++) { OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES); if(OrderType()<=OP_SELL && OrderSymbol()==Symbol() && OrderMagicNumber()==MagicNumber ) { if(OrderType()==OP_BUY) { if((iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,2)>iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,2))&&(iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,1)<iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,1))) //here is your close buy rule { OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red); } if(TrailingStop>0) { if(Bid-OrderOpenPrice()>MyPoint*TrailingStop) { if(OrderStopLoss()<Bid-MyPoint*TrailingStop) { OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green); return(0); } } } } else { if((iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,2)<iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,2))&&(iMA(NULL,0,8,0,MODE_EMA,PRICE_CLOSE,1)>iMA(NULL,0,20,0,MODE_EMA,PRICE_CLOSE,1))) // here is your close sell rule { OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red); } if(TrailingStop>0) { if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop)) { if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0)) { OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red); return(0); } } } } } } return(0); } int TotalOrdersCount() { int result=0; for(int i=0;i<OrdersTotal();i++) { OrderSelect(i,SELECT_BY_POS ,MODE_TRADES); if (OrderMagicNumber()==MagicNumber) result++; } return (result); }
Thank you, 3rjfx, for your feedback.
As an experiment I only activated this EA on USD/JPY 1 hour chart last night about 10pm Mountain Time (Denver). The moving averages crossed and no trade entered. Am wondering if there is something in this code specific to EUR/USD, even though it is not obvious to me. Any more ideas???
parkhurstsd:
3rjfx, I substituted your code and loaded to EUR/USD, USD/JPY, and AUD/USD one hour charts for one micro each to test it out....we'll see how it works!
3rjfx, I substituted your code and loaded to EUR/USD, USD/JPY, and AUD/USD one hour charts for one micro each to test it out....we'll see how it works!
Hello parkhurstsd,
advertising is prohibited on MQL5.com forums. So, unfortunately I have to remove some comments from the code you just posted, once it referes to third-party websites and commercial vendors.
For more information, please take a look at the Forum Rules.
Malacarne, I just posted the code as-is after the other moderator asked me to...sorry for breaking the Forum Rules. I did not create the code I posted, I found it on the platform I use to trade in MT4. Very sorry.
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
_MAvsMA_ema - expert for MetaTrader 4
Marek
Views: 5721Rating:On Oanda's Meta Trader 4, on 1 hour chart, this works great on EUR/USD. Yet does not enter trades on USD/JPY and AUD/USD. Any ideas why it only works on one chart?