Need A Little Help On My EA Coding (Reversal Fractals)

[Alirzen]

Hi. I need a little help on my EA coding. I found an intersting indicator and i want to make an EA of it. I am not a professional programmer, but i tried my best. i would be very appreciated if you can help me. I will attach the EA and the errors.

[Sergey Golubev]

If no one helps you on this thread (for free) so you may go to Freelance service for example.

[William Roeder]

1. int counted_bars=IndicatorCounted();
   

   Global and static variables work exactly the same way in MT4/MT5/C/C++.
   1. They are initialized once on program load.
   2. They don't update unless you assign to them.
   3. In C/C++ you can only initialize them with constants, and they default to zero. In MTx you should only initialize them with constants. There is no default in MT5 (or MT4 with strict which you should always use.)

      MT4/MT5 actually compiles with non-constants, but the order that they are initialized is unspecified and don't try to use any price or server related functions in OnInit (or on load,) as there may be no connection/chart yet:

      1. Terminal starts.
      2. Indicators/EAs are loaded. Static and globally declared variables are initialized. (Do not depend on a specific order.)
      3. OnInit is called.
      4. For indicators OnCalculate is called with any existing history.
      5. Human may have to enter password, connection to server begins.
      6. New history is received, OnCalculate called again.
      7. New tick is received, OnCalculate/OnTick is called. Now TickValue, TimeCurrent, account information and prices are valid.
   4. Unlike indicators, EAs are not reloaded on chart change so you must reinitialize them, if necessary.
                external static variable - Inflation - MQL4 programming forum

   Tool generates bogus code.

2. Compilation errors, Tool generates bogus code.

3. // THIS EA CODE HAS BEEN GENERATED USING FOREXEADVISOR STRATEGY BUILDER 0.2 
   

   EA builder, EATree, Forex Strategy Builder, FOREXEADVISOR STRATEGY BUILDER, FX EA Builder, fxDreema, FxPro, Molanis, Online Forex Expert AdvisorGenerator, Quant, Strategy Builder FX, Visual Trader Studio, MQL5 Wizard, etc., are all the same. You will get something quick, but then you will spend a much longer time trying to get it right, than if you learned the language up front, and then just wrote it.
   • Since you haven't learned MQL4/5, therefor there is no common language for us to communicate.
     If we tell you what you need, you can't code it.
     If we give you the code, you don't know how to integrate it into yours.
     We are willing to HELP you when you post your attempt (using SRC) and the nature of your problem, but we are not going to debug your hundreds of lines of code. You are essentially going to be on your own.

   • EA builder makes bad code counting up while closing multiple orders.
     EA builder makes bad code Bars is unreliable (Max bars in chart), volume is unreliable (miss ticks.) Always use time.
     EA builder makes bad code, not adjusting for 4/5 digit brokers, TP/SL and slippage.
     EA builder makes bad code, not adjusting for ECN brokers. ( pre-Build 500)
     EA builder makes bad code, not checking return codes.
     EATree uses objects on chart to save values — not persistent storage ( files or GV+Flush.) No recovery (crash/power failure.)

   • FX EA Builder makes bad code, not checking return codes.
     FX EA Builder makes bad code, loosing open tickets on terminal restart. No recovery (crash/power failure.)
     FX EA Builder makes bad code, not adjusting stops for the spread.
     FX EA Builder makes bad code, using OrdersTotal directly.

   • FOREXEADVISOR STRATEGY BUILDER makes bad code, non-updateing global variables.
     FOREXEADVISOR STRATEGY BUILDER makes bad code, compilation errors.
     FOREXEADVISOR STRATEGY BUILDER makes bad code, not checking return codes.

   Learn to code it, or pay someone (Freelance) someone to code it.