Expert Advisors: MQL5 Wizard - Trade Signals Based on Price Crossover with Moving Average Indicator - page 2

[busybear]

Hello Carl Schreiber, thank you very much for your quick response. My question relates to this article here https://www.mql5.com/en/code/248. It describes how to create an Expert Advisor with this signal using the wizard. I can't get to this point. I first made sure that the indicator is in the correct directory. If I then click on File New -> Generate Expert Advisor -> Assign Name -> Parameters of Signal Module in the Meta Editor, Signals based on price crossover with MA should appear there according to the article described. Unfortunately, the selection does not appear. I have version 5.0 Build 3211

[Carl Schreiber]

Unfortunately, your build is too small for me to recognise anything.

The iMA indicator is integrated, it does not need to be in a specific directory.

I have no problem creating an EA ( generate with Expert Advisor) according to this article with the moving average: https://www.metatrader5.com/de/metaeditor/help/mql5_wizard/wizard_ea_generate

After adding the moving average continue ...

Then this EA is created:

//+------------------------------------------------------------------+
//|test_Wizard.mq5 |
//|Calli |
//| https://www.mql5.com/en/users/gooly |
//+------------------------------------------------------------------+
#property copyright "Calli"
#property link      "https://www.mql5.com/en/users/gooly"
#property version   "1.00"
//+------------------------------------------------------------------+
//| Include|
//+------------------------------------------------------------------+
#include <Expert\Expert.mqh>
//--- available signals
#include <Expert\Signal\SignalMA.mqh>
//--- available trailing
#include <Expert\Trailing\TrailingNone.mqh>
//--- available money management
#include <Expert\Money\MoneyFixedLot.mqh>
//+------------------------------------------------------------------+
//| Inputs|
//+------------------------------------------------------------------+
//--- inputs for expert
input string             Expert_Title         ="test_Wizard"; // Document name
ulong                    Expert_MagicNumber   =18344;         //
bool                     Expert_EveryTick     =false;         //
//--- inputs for main signal
input int                Signal_ThresholdOpen =10;            // Signal threshold value to open [0...100]
input int                Signal_ThresholdClose=10;            // Signal threshold value to close [0...100]
input double             Signal_PriceLevel    =0.0;           // Price level to execute a deal
input double             Signal_StopLevel     =50.0;          // Stop loss level (in points)
input double             Signal_TakeLevel     =50.0;          // Take Profit level (in points)
input int                Signal_Expiration    =4;             // Expiration of pending orders (in bars)
input int                Signal_MA_PeriodMA   =12;            // Moving Average(12,0,...) Period of averaging
input int                Signal_MA_Shift      =0;             // Moving Average(12,0,...) Time shift
input ENUM_MA_METHOD     Signal_MA_Method     =MODE_SMA;      // Moving Average(12,0,...) Method of averaging
input ENUM_APPLIED_PRICE Signal_MA_Applied    =PRICE_CLOSE;   // Moving Average(12,0,...) Prices series
input double             Signal_MA_Weight     =1.0;           // Moving Average(12,0,...) Weight [0...1.0]
//--- inputs for money
input double             Money_FixLot_Percent =10.0;          // Percent
input double             Money_FixLot_Lots    =0.1;           // Fixed volume
//+------------------------------------------------------------------+
//| Global expert object|
//+------------------------------------------------------------------+
CExpert ExtExpert;
//+------------------------------------------------------------------+
//| Initialisation function of the expert |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- Initialising expert
   if(!ExtExpert.Init(Symbol(),Period(),Expert_EveryTick,Expert_MagicNumber))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing expert");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Creating signal
   CExpertSignal *signal=new CExpertSignal;
   if(signal==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating signal");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//---
   ExtExpert.InitSignal(signal);
   signal.ThresholdOpen(Signal_ThresholdOpen);
   signal.ThresholdClose(Signal_ThresholdClose);
   signal.PriceLevel(Signal_PriceLevel);
   signal.StopLevel(Signal_StopLevel);
   signal.TakeLevel(Signal_TakeLevel);
   signal.Expiration(Signal_Expiration);
//--- Creating filter CSignalMA
   CSignalMA *filter0=new CSignalMA;
   if(filter0==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating filter0");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
   signal.AddFilter(filter0);
//--- Set filter parameters
   filter0.PeriodMA(Signal_MA_PeriodMA);
   filter0.Shift(Signal_MA_Shift);
   filter0.Method(Signal_MA_Method);
   filter0.Applied(Signal_MA_Applied);
   filter0.Weight(Signal_MA_Weight);
//--- Creation of trailing object
   CTrailingNone *trailing=new CTrailingNone;
   if(trailing==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating trailing");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Add trailing to expert (will be deleted automatically))
   if(!ExtExpert.InitTrailing(trailing))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing trailing");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Set trailing parameters
//--- Creation of money object
   CMoneyFixedLot *money=new CMoneyFixedLot;
   if(money==NULL)
     {
      //--- failed
      printf(__FUNCTION__+": error creating money");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Add money to expert (will be deleted automatically))
   if(!ExtExpert.InitMoney(money))
     {
      //--- failed
      printf(__FUNCTION__+": error initializing money");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Set money parameters
   money.Percent(Money_FixLot_Percent);
   money.Lots(Money_FixLot_Lots);
//--- Check all trading objects parameters
   if(!ExtExpert.ValidationSettings())
     {
      //--- failed
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- Tuning of all necessary indicators
   if(!ExtExpert.InitIndicators())
     {
      //--- failed
      printf(__FUNCTION__+": error initializing indicators");
      ExtExpert.Deinit();
      return(INIT_FAILED);
     }
//--- ok
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Deinitialisation function of the expert |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
   ExtExpert.Deinit();
  }
//+------------------------------------------------------------------+
//| "Tick" event handler function|
//+------------------------------------------------------------------+
void OnTick()
  {
   ExtExpert.OnTick();
  }
//+------------------------------------------------------------------+
//| "Trade" event handler function|
//+------------------------------------------------------------------+
void OnTrade()
  {
   ExtExpert.OnTrade();
  }
//+------------------------------------------------------------------+
//| "Timer" event handler function|
//+------------------------------------------------------------------+
void OnTimer()
  {
   ExtExpert.OnTimer();
  }
//+------------------------------------------------------------------+

The code compiles without any problems, but I don't know whether it also generates profits, nor do I know whether the code could be optimised.

[[Deleted]]

really good code