Experts: JK BullP AutoTrader

New comment
 

JK BullP AutoTrader:

The Expert Advisor uses the iBullsPower (Bulls Power) indicator.

JK BullP AutoTrader tester‌

Author: Vladimir Karputov

 

All good, except why handle_iBullsPower=iBullsPower(Symbol(),Period(),13); ?

This parameter should be moved to input ?

And it seems to me that since TrailingStep is always less than TrailingStop but more than zero, we can enter in input instead of TrailingStep a double coefficient TrailingStepKo from 0 to 1.

and in OnInit() TrailingStep=int(TrailingStepKo*TrailingStop);

This way it is more convenient to set parameters in the tester and you won't be tested with error "incorrect input parameters"

 
Oleg Tsarkov:

All good, except why handle_iBullsPower=iBullsPower(Symbol(),Period(),13); ?

This parameter should be moved to input ?

...

Everyone can do as he/she likes. If it is more convenient for you, change the code.

Oleg Tsarkov:

...

And it seems to me that since TrailingStep is always less than TrailingStop but more than zero, we can enter a double coefficient TrailingStepKo from 0 to 1 in the input instead of TrailingStep.

and in OnInit() TrailingStep=int(TrailingStepKo*TrailingStop);

...

Everyone can do it the way he/she likes. If it is more convenient for you, change the code.

Oleg Tsarkov:

...

It is more convenient to set parameters in the tester and you won't be tested with error "incorrect input parameters".

Everyone can do as he/she likes. If it is more convenient for you, change the code.

 
Vladimir Karputov:

Everyone can do as he/she likes. If it is more convenient for you, change the code.

Everyone can do as they please. If it suits you better, change the code.

Everyone can do as they please. If it is more convenient for you, change the code.

One more thing, if I'm not boring you.)

   if(pos1pre>pos2cur && pos2cur>0 && total<2)
     {
      m_trade.Sell(Lots,Symbol(),m_symbol.Bid(),
                   m_symbol.Ask()+StopLoss*m_digits_adjust,
                   m_symbol.Ask()-TakeProfit*m_digits_adjust);
     }
   if(pos2cur<0 && total<1)
     {
      m_trade.Buy(Lots,Symbol(),m_symbol.Ask(),
                  m_symbol.Bid()-StopLoss*m_digits_adjust,
                  m_symbol.Bid()+TakeProfit*m_digits_adjust,NULL);
     }

why are there different conditions for buy and sell?

If there can be two selves at the same time, then there is always one bay....

Of course you can answer as usual, but I'm interested in your logic.

 
Oleg Tsarkov:

One more thing, if I'm not boring you)

   if(pos1pre>pos2cur && pos2cur>0 && total<2)
     {
      m_trade.Sell(Lots,Symbol(),m_symbol.Bid(),
                   m_symbol.Ask()+StopLoss*m_digits_adjust,
                   m_symbol.Ask()-TakeProfit*m_digits_adjust);
     }
   if(pos2cur<0 && total<1)
     {
      m_trade.Buy(Lots,Symbol(),m_symbol.Ask(),
                  m_symbol.Bid()-StopLoss*m_digits_adjust,
                  m_symbol.Bid()+TakeProfit*m_digits_adjust,NULL);
     }

why are there different conditions for buy and sell?

If there can be two sels at the same time, then there is always one buy....

of course you can answer as usual, but I am interested in your logic.

Read the description carefully - it's not my logic :).
New comment