Indicators: ZoomPrice tick indicator - page 4

New comment
 
ascerdfg:

I unzipped mql5.com/en/code/download/16753.zip and copied with the folder structure intact.

When compiling ZoomPrice.mq5 in MetaEditor 5.0 build 2715, it gives an error:

The zip files in the code base have not been updated when updating the sources for a long time. Download each file separately.

 

1. In the Ticks.mqh file there is this code

AmountTicks = this.GetFreshTicks(NewTicks, COPY_TICKS_INFO, (uint)MathMax((this.To - this.LastTime) >> 5, 2000)); // ~2000 ticks/minute

At the same time in GetFreshTicks there is a check

if ((NewAmount > 0) && (this.Count < NewAmount))

In other words, if the last few ticks are read, GetFreshTicks will not change the NewTicks array. But it is not cleaned, and the old array with old values will be processed. Alternatively, this is solved by moving the MqlTick NewTicks[] declaration;

    TICK Tick;

    int AmountTicks = 1;

    while (AmountTicks > 0)
    {
      MqlTick NewTicks[];
      AmountTicks = this.GetFreshTicks(NewTicks, COPY_TICKS_INFO, (uint)MathMax((this.To - this.LastTime) >> 5, 2000)); // ~2000 ticks/minute


2. A few typos

Количество тиков в последенем запросе


So far, because of this bug https://www.mql5.com/ru/forum/363680/page9#comment_21182494 I can't say whether everything is normal or something else doesn't work.

 

Пока из-за этого бага https://www.mql5.com/ru/forum/363680/page9#comment_21182494 не могу сказать, всё ли дальше нормально или ещё что не работает.

Forum on trading, automated trading systems and testing trading strategies

Custom symbols. Errors, bugs, questions, suggestions.

fxsaber, 2020.07.01 17:34

I confirm the bug in 2509.

This variant doesn't seem to fail.

int size = CopyTicksRange(_Symbol, array, COPY_TICKS_ALL, cursor);

Perhaps it makes sense to switch to CopyTicksRange.

 
traveller00:

It might make sense to switch to CopyTicksRange.

The indicator is ancient. It didn't even have this function back then. To work properly, of course, you need to make changes.

 
traveller00:

It might make sense to switch to CopyTicksRange.

It seems to be a working option.


3. there is a void SetAutoScroll( void ) function. If the chart auto-scrolls to the right edge, the time for ZoomTicks will be calculated based on the real current time via this.Ticks.GetNowTime(). But custom characters don't spawn new ticks. As a result From and To will be filled with values from the current time, it will not pick up ticks for them (there are no new ticks), the picture of ticks will eventually show the old one, but in this.SetTextCross it will sign the current time.


4. The request for ticks comes from the left edge of the interval. If the interval goes 01:00:00:00-01:01:00:00, and the first tick entering the interval will be at 01:00:30, there will be a hole on the left half.

 
traveller00:

4. The tick request comes from the left edge of the interval. If the interval goes 01:00:00:00-01:01:00:00, and the first tick entering the interval is at 01:00:30, there will be a hole on the left half.

This was originally there. I didn't rule it on purpose.

 
fxsaber:

It was there from the beginning. I didn't rule on purpose.

What was the hole for, if it's no secret?

 
traveller00:

What was the hole for, if it's no secret?

I can see right away that there was no tick to the left.

 
ascerdfg:

And I'm getting the same errors.

I still have a working version of the indicator, it still works for me).

 
ZoomPrice


12345
New comment