MA cross over logic
Don't use EA builders. They produce very bad code, and most users here will refuse to help you because there just too much to fix.
So do it right, and don't use EA builders! Learn to code it yourself and we will be glad to help you out with your own code.
Don't use EA builders. They produce very bad code, and most users here will refuse to help you because there just too much to fix.
So do it right, and don't use EA builders! Learn to code it yourself and we will be glad to help you out with your own code.
thank you for taking the time to look into my query does MT4 recognize the "crossover" and "crossunder" logic or I would have to manually find a way to code this?
if SMA(100) crossover EMA(13) then Buy;if SMA(100) crossunder EMA(13) then Sell;
thank you for taking the time to look into my query does MT4 recognize the "crossover" and "crossunder" logic or I would have to manually find a way to code this?
if SMA(100) crossover EMA(13) then Buy;if SMA(100) crossunder EMA(13) then Sell;
i find it easier to code an indicator first then slot it into an ea with icustom()
For a simple crossover? That is just making it more complicated and more inefficient.
chipNdale: found that there is a builder on EA. And so I used it. chipNdale: does MT4 recognize the "crossover" and "crossunder" logic or I would have to manually find a way to code this? if SMA(100) crossover EMA(13) then Buy; if SMA(100) crossunder EMA(13) then Sell; |
|
It all depends of the "exact requirements."
chipNdale: found that there is a builder on EA. And so I used it. chipNdale: does MT4 recognize the "crossover" and "crossunder" logic or I would have to manually find a way to code this? if SMA(100) crossover EMA(13) then Buy; if SMA(100) crossunder EMA(13) then Sell; |
|
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
You agree to website policy and terms of use
Hello everyone. I am new to the coding trying to learn from this page and found that there is a builder on EA. And so I used it. I am setting up an EA to trade MA crosses but the builder does not have this option. Can somebody help or guide me on this? Below is the code i generated from http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/ . When I tried on my dummy account the buy / sell always is true and executes order since my logic is one MA > or < the other MA instead of cross over :(
logic
Buy order if
EMA 13 cross over (upwards) SMA 100
sell order if
EMA 13 cross over (downwards) SMA 100
//+------------------------------------------------------------------+ //| This MQL is generated by Expert Advisor Builder | //| http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/ | //| | //| In no event will author be liable for any damages whatsoever. | //| Use at your own risk. | //| | //+------------------- DO NOT REMOVE THIS HEADER --------------------+ #define SIGNAL_NONE 0 #define SIGNAL_BUY 1 #define SIGNAL_SELL 2 #define SIGNAL_CLOSEBUY 3 #define SIGNAL_CLOSESELL 4 #property copyright \\\\\\\"Expert Advisor Builder\\\\\\\" #property link \\\\\\\"http://sufx.core.t3-ism.net/ExpertAdvisorBuilder/\\\\\\\" extern int MagicNumber = 0; extern bool SignalMail = False; extern bool EachTickMode = True; extern double Lots = 0.1; extern int Slippage = 3; extern bool UseStopLoss = False; extern int StopLoss = 30; extern bool UseTakeProfit = True; extern int TakeProfit = 100; extern bool UseTrailingStop = False; extern int TrailingStop = 30; int BarCount; int Current; bool TickCheck = False; //+------------------------------------------------------------------+ //| expert initialization function | //+------------------------------------------------------------------+ int init() { BarCount = Bars; if (EachTickMode) Current = 0; else Current = 1; return(0); } //+------------------------------------------------------------------+ //| expert deinitialization function | //+------------------------------------------------------------------+ int deinit() { return(0); } //+------------------------------------------------------------------+ //| expert start function | //+------------------------------------------------------------------+ int start() { int Order = SIGNAL_NONE; int Total, Ticket; double StopLossLevel, TakeProfitLevel; if (EachTickMode && Bars != BarCount) TickCheck = False; Total = OrdersTotal(); Order = SIGNAL_NONE; //+------------------------------------------------------------------+ //| Variable Begin | //+------------------------------------------------------------------+ double Buy1_1 = iMA(NULL, 0, 13, 0, MODE_EMA, PRICE_CLOSE, Current + 0); double Buy1_2 = iMA(NULL, 0, 100, 0, MODE_SMA, PRICE_CLOSE, Current + 0); double Sell1_1 = iMA(NULL, 0, 13, 0, MODE_EMA, PRICE_CLOSE, Current + 0); double Sell1_2 = iMA(NULL, 0, 100, 0, MODE_SMA, PRICE_CLOSE, Current + 0); //+------------------------------------------------------------------+ //| Variable End | //+------------------------------------------------------------------+ //Check position bool IsTrade = False; for (int i = 0; i < Total; i ++) { OrderSelect(i, SELECT_BY_POS, MODE_TRADES); if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) { IsTrade = True; if(OrderType() == OP_BUY) { //Close //+------------------------------------------------------------------+ //| Signal Begin(Exit Buy) | //+------------------------------------------------------------------+ if (False) Order = SIGNAL_CLOSEBUY; //+------------------------------------------------------------------+ //| Signal End(Exit Buy) | //+------------------------------------------------------------------+ if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) { OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen); if (SignalMail) SendMail(\\\\\\\"[Signal Alert]\\\\\\\", \\\\\\\"[\\\\\\\" + Symbol() + \\\\\\\"] \\\\\\\" + DoubleToStr(Bid, Digits) + \\\\\\\" Close Buy\\\\\\\"); if (!EachTickMode) BarCount = Bars; IsTrade = False; continue; } //Trailing stop if(UseTrailingStop && TrailingStop > 0) { if(Bid - OrderOpenPrice() > Point * TrailingStop) { if(OrderStopLoss() < Bid - Point * TrailingStop) { OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen); if (!EachTickMode) BarCount = Bars; continue; } } } } else { //Close //+------------------------------------------------------------------+ //| Signal Begin(Exit Sell) | //+------------------------------------------------------------------+ //+------------------------------------------------------------------+ //| Signal End(Exit Sell) | //+------------------------------------------------------------------+ if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) { OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange); if (SignalMail) SendMail(\\\\\\\"[Signal Alert]\\\\\\\", \\\\\\\"[\\\\\\\" + Symbol() + \\\\\\\"] \\\\\\\" + DoubleToStr(Ask, Digits) + \\\\\\\" Close Sell\\\\\\\"); if (!EachTickMode) BarCount = Bars; IsTrade = False; continue; } //Trailing stop if(UseTrailingStop && TrailingStop > 0) { if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) { if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) { OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange); if (!EachTickMode) BarCount = Bars; continue; } } } } } } //+------------------------------------------------------------------+ //| Signal Begin(Entry) | //+------------------------------------------------------------------+ if (Buy1_1 >= Buy1_2) Order = SIGNAL_BUY; if (Sell1_1 <= Sell1_2) Order = SIGNAL_SELL; //+------------------------------------------------------------------+ //| Signal End | //+------------------------------------------------------------------+ //Buy if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) { if(!IsTrade) { //Check free margin if (AccountFreeMargin() < (1000 * Lots)) { Print(\\\\\\\"We have no money. Free Margin = \\\\\\\", AccountFreeMargin()); return(0); } if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0; if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0; Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, \\\\\\\"Buy(#\\\\\\\" + MagicNumber + \\\\\\\")\\\\\\\", MagicNumber, 0, DodgerBlue); if(Ticket > 0) { if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) { Print(\\\\\\\"BUY order opened : \\\\\\\", OrderOpenPrice()); if (SignalMail) SendMail(\\\\\\\"[Signal Alert]\\\\\\\", \\\\\\\"[\\\\\\\" + Symbol() + \\\\\\\"] \\\\\\\" + DoubleToStr(Ask, Digits) + \\\\\\\" Open Buy\\\\\\\"); } else { Print(\\\\\\\"Error opening BUY order : \\\\\\\", GetLastError()); } } if (EachTickMode) TickCheck = True; if (!EachTickMode) BarCount = Bars; return(0); } } //Sell if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) { if(!IsTrade) { //Check free margin if (AccountFreeMargin() < (1000 * Lots)) { Print(\\\\\\\"We have no money. Free Margin = \\\\\\\", AccountFreeMargin()); return(0); } if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0; if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0; Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, \\\\\\\"Sell(#\\\\\\\" + MagicNumber + \\\\\\\")\\\\\\\", MagicNumber, 0, DeepPink); if(Ticket > 0) { if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) { Print(\\\\\\\"SELL order opened : \\\\\\\", OrderOpenPrice()); if (SignalMail) SendMail(\\\\\\\"[Signal Alert]\\\\\\\", \\\\\\\"[\\\\\\\" + Symbol() + \\\\\\\"] \\\\\\\" + DoubleToStr(Bid, Digits) + \\\\\\\" Open Sell\\\\\\\"); } else { Print(\\\\\\\"Error opening SELL order : \\\\\\\", GetLastError()); } } if (EachTickMode) TickCheck = True; if (!EachTickMode) BarCount = Bars; return(0); } } if (!EachTickMode) BarCount = Bars; return(0); } //+------------------------------------------------------------------+