Trailing stop ONLY on the remaining open positions. - page 2
You are missing trading opportunities:
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
Registration
Log in
You agree to website policy and terms of use
If you do not have an account, please register
Finally done it - Christ almighty. I feel so stupid looking at it now!
Just something to think about
So you're right. To be perfectly honest, I have tried understanding the "Point" built in variable, but I actually don't understand its purpose to the if statement.
This will sound horrifying to some, but I use it because many moons ago I read a large article on comparing doubles (think it was by WHRoeder - could be wrong) and I noticed that in there. Then someone told me in a post to do it.
There isn't much information on Point within the referencing doc.
+ or - Point at the end of an 'double' equality statement... What does this change? Is it just telling the if statement to be "point size of the current symbol in the quote currency", i.e. in my case, 5 decimal places?
Thanks for your input Gumrai, have swapped it over. Works fine!
It trails, but before the second target is hit by the bid, it actually jumps to the different MA trail? "MA2" below?
//+----------------------------------------------------------------------------------------------------------------------------------------+ //Moving Average Trailing Stop Function //+----------------------------------------------------------------------------------------------------------------------------------------+ void MA_Trail() { static datetime Target_2_reached; double Target2_Stored_OpenTime = GlobalVariableGet(" Target 2 hit "); ATR = iATR(NULL,low,ATR_Period,1); MA = iMA(NULL,low,MA_Period,0,1,0,1); double BuyStopPriceMath = MA - ATR; double SellStopPriceMath = MA + ATR; double new_BSL_1 = NormalizeDouble(BuyStopPriceMath,Digits); double new_SSL_1 = NormalizeDouble(SellStopPriceMath,Digits); //----------------------------------------------------------// double MA2 = iMA(NULL,low,21,0,1,0,1); double BuyStopPriceMath2 = MA2 - ATR; double SellStopPriceMath2 = MA2 + ATR; double new_BSL_2 = NormalizeDouble(BuyStopPriceMath2,Digits); double new_SSL_2 = NormalizeDouble(SellStopPriceMath2,Digits); for(int b=OrdersTotal()-1; b>=0; b--) { if( !OrderSelect(b,SELECT_BY_POS,MODE_TRADES))continue; if( OrderMagicNumber() == MagicNumber1 || OrderMagicNumber()== MagicNumber2 || OrderMagicNumber()== MagicNumber3 || OrderMagicNumber()== MagicNumber4 ) if(OrderSymbol() == Symbol()) { if( OrderType()==OP_BUY ) { if( OrderMagicNumber() == MagicNumber2 ){ TakeProfit_2 = OrderTakeProfit(); } if( new_BSL_1 > OrderStopLoss() + Point && OrderOpenTime() != Target2_Stored_OpenTime) { bool BuyModify = OrderModify(OrderTicket(),OrderOpenPrice(),new_BSL_1,OrderTakeProfit(),0,CLR_NONE); if(BuyModify == True )Print("Original MA trail BUY Order Modified on: ", Symbol()); if(BuyModify != True )Print("Original MA trail BUY Order Modify Failed: ", GetLastError()); } if( Bid > TakeProfit_2 - Point && OrderOpenTime() != Target2_Stored_OpenTime ) { Target_2_reached = GlobalVariableSet(" Target 2 hit ", OrderOpenTime()); } if( OrderOpenTime() == Target2_Stored_OpenTime ) { if( new_BSL_2 > OrderStopLoss() + Point ) { if( OrderOpenTime() == Target2_Stored_OpenTime ) { if( new_BSL_2 > OrderStopLoss() + Point ) { bool BuyModify2 = OrderModify(OrderTicket(),OrderOpenPrice(),new_BSL_2,OrderTakeProfit(),0,CLR_NONE); if(BuyModify2 == True )Print("MA CHANGED - Trailing BUY Order Modified on: ", Symbol()); if(BuyModify2 != True )Print("MA CHANGED - Trailing BUY Order Modify Failed: ", GetLastError()); } } } ...I think what is happening is on the very first trade taken, on the FIRST loop, it selects OrderMagicNumber1 and therefore cannot find the TakeProfit_2 price. Therefore, it is set to "0". When it gets to:
TakeProfit_2 - PointI think your math is a bit wrong. Do you know what and how to use Point ?Point in this case means how many digits after dot. If it is 5 digits means 1*Point = 0.00001
Use Print(Point); to get the point value. From there, what-is-the-distance-you-want * Point
The 5th digit means 1/10 of 1.
Would you mind taking a look at this? It seems to work flawlessly on the OP_BUY side by not on the OP_SELL side? Basic symmetry here but I cannot spot the difference. I apologize; it's a little messy!
To be specific, it almost ignores everything below on the sell side. As soon as the OP_SELLSTOP turns into OP_SELL it switches straight to the very last OrderModify function at the bottom with the "new_SSL_3" price!?