# how to modify the basic ma strategy.

213

Hi, Below is the standard moving average strategy that comes with the system. Can someone show me how to modify it slightly. I see no profit target, and I'm finding it difficult to even adjust the parameters of of the buying and selling levels.

I assume the two orders at the bottom are for the exits, and the two at the top are for entries.

when I try to make adjustments by adding variables and adding or subtracting points it performs unlike I'd expect, such as no orders at all, or only does sells.

for a test example I'd like to sell when it's under the ma by .0005 and buy when it's over the ma by .0005 and also have a profit target in dollars that I can set. It's also unclear to me if the "Close[1]" is referring to the tick close or the bar close.

```//+------------------------------------------------------------------+
//|                                               Moving Average.mq4 |
//|                                       http://www.metaquotes.net/ |
//+------------------------------------------------------------------+
#define MAGICMA  20050610

extern double Lots               = 0.1;
extern double MaximumRisk        = 0.02;
extern double DecreaseFactor     = 3;
extern double MovingPeriod       = 12;
extern double MovingShift        = 6;
//+------------------------------------------------------------------+
//| Calculate open positions                                         |
//+------------------------------------------------------------------+
int CalculateCurrentOrders(string symbol)
{
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderSymbol()==Symbol() && OrderMagicNumber()==MAGICMA)
{
if(OrderType()==OP_SELL) sells++;
}
}
//---- return orders volume
else       return(-sells);
}
//+------------------------------------------------------------------+
//| Calculate optimal lot size                                       |
//+------------------------------------------------------------------+
double LotsOptimized()
{
double lot=Lots;
int    orders=HistoryTotal();     // history orders total
int    losses=0;                  // number of losses orders without a break
//---- select lot size
lot=NormalizeDouble(AccountFreeMargin()*MaximumRisk/1000.0,1);
//---- calcuulate number of losses orders without a break
if(DecreaseFactor>0)
{
for(int i=orders-1;i>=0;i--)
{
if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==false) { Print("Error in history!"); break; }
if(OrderSymbol()!=Symbol() || OrderType()>OP_SELL) continue;
//----
if(OrderProfit()>0) break;
if(OrderProfit()<0) losses++;
}
if(losses>1) lot=NormalizeDouble(lot-lot*losses/DecreaseFactor,1);
}
//---- return lot size
if(lot<0.1) lot=0.1;
return(lot);
}
//+------------------------------------------------------------------+
//| Check for open order conditions                                  |
//+------------------------------------------------------------------+
void CheckForOpen()
{
double ma;
int    res;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//---- sell conditions
if(Open[1]>ma && Close[1]<ma)
{
res=OrderSend(Symbol(),OP_SELL,LotsOptimized(),Bid,3,0,0,"",MAGICMA,0,Red);
return;
}
if(Open[1]<ma && Close[1]>ma)
{
return;
}
//----
}
//+------------------------------------------------------------------+
//| Check for close order conditions                                 |
//+------------------------------------------------------------------+
void CheckForClose()
{
double ma;
//---- go trading only for first tiks of new bar
if(Volume[0]>1) return;
//---- get Moving Average
ma=iMA(NULL,0,MovingPeriod,MovingShift,MODE_SMA,PRICE_CLOSE,0);
//----
for(int i=0;i<OrdersTotal();i++)
{
if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
//---- check order type
{
if(Open[1]>ma && Close[1]<ma) OrderClose(OrderTicket(),OrderLots(),Bid,3,White);
break;
}
if(OrderType()==OP_SELL)
{
break;
}
}
//----
}
//+------------------------------------------------------------------+
//| Start function                                                   |
//+------------------------------------------------------------------+
void start()
{
//---- check for history and trading
//---- calculate open orders by current symbol
if(CalculateCurrentOrders(Symbol())==0) CheckForOpen();
else                                    CheckForClose();
//----
}
//+------------------------------------------------------------------+```
213

Here is a great( video was added here but it did not post) and it also deleted all of my text that I typed in. thanks, big help

6433

moneycode:

Hi, Below is the standard moving average strategy that comes with the system. Can someone show me how to modify it slightly. I see no profit target, and I'm finding it difficult to even adjust the parameters of of the buying and selling levels.

I assume the two orders at the bottom are for the exits, and the two at the top are for entries.

when I try to make adjustments by adding variables and adding or subtracting points it performs unlike I'd expect, such as no orders at all, or only does sells.

for a test example I'd like to sell when it's under the ma by .0005 and buy when it's over the ma by .0005 and also have a profit target in dollars that I can set. It's also unclear to me if the "Close[1]" is referring to the tick close or the bar close.

I see no difference with the original EA

so what is it you tried to make it work with profit target

and if it is unclear to you what Close[1] means then it is also unclear to me how to explain you what changes you have to make...

2584

Close[1] referes to the last price of the last completed bar.