I can't believe the new programs in Code Base passed proofreading....

New comment
 

Sometimes it takes long before your program is published in section Code Base

The new Code has to pass a proofreading

So when you see a new published code You may expect a little quality

.

//+------------------------------------------------------------------+
//|                                             Bullish Reversal.mq4 |
//|                                                               ar |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
#property copyright "ar"
#property link      "http://www.metaquotes.net"

extern double Lots=1;
extern double StopLoss=0;
extern double TakeProfit=0;
extern double TrailingStop=50;
extern int UseTrailingStop=1;
int ThisBarTrade=0;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
// int quick variables 
   int ticket,total;
// check sample size   
if(Bars<50)
   { 
    Print("Sample Size Too Small");
    return(0);
    } 
if(OrdersTotal()<1) // check if there are any postions open
   {
   if (Bars != ThisBarTrade ) 
    {
      ThisBarTrade = Bars;  // ensure only one trade opportunity per bar
   
     if(AccountFreeMargin()<1000*Lots) // check margin level 
        {
          Print("Free Margin = ",AccountFreeMargin());
         return(0);
         }
// seting up quick variables for candle stick parts 
double high1=iHigh(NULL,0,1);
double close1=iClose(NULL,0,1);
double open1=iOpen(NULL,0,1);
double low1=iLow(NULL,0,1);
double high2=iHigh(NULL,0,2);
double close2=iClose(NULL,0,2);
double open2=iOpen(NULL,01,2);
double low2=iLow(NULL,0,2);
double high3=iHigh(NULL,0,3);
double close3=iClose(NULL,0,3);
double open3=iOpen(NULL,0,3);
double low3=iLow(NULL,01,3);
double MA=iMA(NULL,0,50,0,MODE_SMA,PRICE_CLOSE,0);
// set up partern names
// strong Indicator

// set up algo
if ()&&open1>MA)
    {
       ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,0,"BF",16384,0,Green);
       if(ticket>0) // if order can be filled 
           {
              if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES))// if order is executed 
               Print("BUY order opened : ",OrderOpenPrice());//     then notifiy the trader that it was executed.
            }
        return(0);
     }
     return(0);
    }
  return(0);
  }
//Trailing stop
if(TrailingStop>0)
  {
   if(OrderOpenPrice-Ask()> Point*TrailingStop) // if the is a chance of lossing more than trailing stop 
      {
        if(OrderStopLoss()> Ask+Point*TrailingStop) // amd if a trailing stop would work
        {
          OrderModify(OrderTicket(), OrderOpenPrice(), Ask+Point*TrailingStop, OrderTakeProfit(),0,Orange);
         }
       }
      return(0);
     }
  return(0);
}
//+------------------------------------------------------------------+

This is a new code published today

Can you believe proofreading is done seriously ???

 
deVries:

Sometimes it takes long before your program is published in section Code Base

The new Code has to pass a proofreading

So when you see a new published code You may expect a little quality

.

This is a new code published today

Can you believe proofreading is done seriously ???

so you want mql4 to check each and every line for syntax error.?? c'mon..

As far as I know, proofreading means that the code doesnt voilate any T&C..

 
dineshydv:

so you want mql4 to check each and every line for syntax error.?? c'mon..

As far as I know, proofreading means that the code doesnt voilate any T&C..


A syntax error can simply be checked by checking if code can be compiled without errors so that might be no problem to do

This program is showing errors by compiling. In MetaTrader4 we can free download the programs from CodeBase then atleast check if it compile...

Maybe you can tell what you mean by T&C..

 
deVries:

Sometimes it takes long before your program is published in section Code Base

The new Code has to pass a proofreading

So when you see a new published code You may expect a little quality

.

This is a new code published today

Can you believe proofreading is done seriously ???


I asked the question about what needs to be done as part of the "proofreading" but was told that it is done by Metaquotes so I never found out.

To reject this code would also need a reason feeding back to the author, the task of "proofreading" would then become one of critical review/critique and would take more time. So while it would be desirable I don't see it ever happening. The thing that I do find disturbing is decompiled code in the Codebase.

 
RaptorUK:


I agree with you about Decompiled code can't be published in the CodeBase...

About "To reject a code ... take more time" You have to wait days or weeks before publishing

If a Code is not good you can give a reason to the author...

If he needs help then send him to this section Forum

If you see the Above Code it is this way not to use with other EA's

Common Errors discussed here Weekly inside of it

To my opinion That is not coding to have in CodeBase

 
smoknfx:


the proper approach is that if you really want to do something like this, just dig in and start doing it...

dont proofread anything, jump in and start compiling and debugging..

then make some records about what you have done and then contact metaquotes and inform them that you have fixed all of the code in the codebase and that whenever they are ready that you can upload it.


If I submitted code to the codebase and someone, anyone, changed it before approving it I wouldn't be very happy. It has to be the Author's work, and any changes have to be done by the Author.
 

Not sure if its too much, but submitting code should be more smart. There should be a utility which will compile the code (automatically) upon submitting and if there's any error then reject it right away and ask author to resubmit again. Its same what MetaEditor do.

 
RaptorUK:

If I submitted code to the codebase and someone, anyone, changed it before approving it I wouldn't be very happy. It has to be the Author's work, and any changes have to be done by the Author.


i do agree with you.

i dont always say the right things.

i make tons of mistakes.

either way, problems are made to be fixed.

if i can help or whatever, just ask.

zero/.

 

Puzzled by the line

if ()&&open1>MA)
 

The latest code in Chinese forum was dated 2010.09.22, The latest code in Russian forum "zero" was 08/15/2012 and is "very sophisticated" https://www.mql5.com/ru/code/10817

 
onewithzachy:

The latest code in Chinese forum was dated 2010.09.22, The latest code in Russian forum "zero" was 08/15/2012 and is "very sophisticated" https://www.mql5.com/ru/code/10817



So looks like the proofreading in Chinese forum is done very carefully before MetaQuotes place the new Code to their Code Base

And I agree "zero" looks like well written. Hard to find one error inside of it... Already rated with a 10.

12
New comment
Reason: