Debug: array out of range issue + 2 buffers return value of 1 on live chart for every bar

Tarea técnica

Only for developers with experience in debugging, and array-out-of-range issues.


A custom indicator seems to work on a static chart, but 1 buffer still has mistakes in it, resulting in a value of 1 for every bar: the code needs to be reviewed and modified, resulting in a working indicator for every symbol, for every timeframe: sometimes when the timeframe is switched, the chart closes automatically, but all the time the value of ExtMapBuffer2 (Aqua) is 1 on the live chart, sometimes there is an "array out of range" issue. The second buffer: NonRepaintBuffer (red line on the image below) is based on the first one:  ExtMapBuffer2. ExtMapBuffer2 repaints around turning points, so this second buffer is added ( NonRepaintBuffer ) that does not change values in the past. As the red line is calculated based on the aqua line, the error must be contained within the  ExtMapBuffer2 calculation.



So review, edit & fix please.

I'm happy to answer any questions.

- - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - -  - - - - - 

About the indicator:

A zig-zag NRP close is applied to an oscillator.

On this, a counter is added, to keep track of the number of bars since the last "zag" (that does not repaint). The counter adds 0 for a counter-trend bar, and 1 for a trend bar. So when in a rising segment, you have a small counter-trend down-swing, the counter is flat. If after this counter-trend down-swing the trend goes back up, and a new high is made, the counter takes the value as if there would not have been a counter-trend piece (like only rising bars). (& vice versa for falling segment).

Every trend change starts with a retracement against the current trend, so the counter will be flat during this time, but when the trend goes further (than an acceptable retracement as in the setting for the zigzag), a new leg of the zig zag is created. 

The problem with the current code, is that at that moment (when a new leg of the zigzag close nrp on the oscillator appears), the counter jumps back to the start of the retracement (of the flat part), instead of the end of the flat part. 

So it is not a repainting error, it is a code error.

To fix this, a new buffer that does not repaint is added.



Archivos adjuntos:

ZIP
trash15.zip
3.6 Kb

Han respondido

1
Desarrollador 1
Evaluación
(266)
Proyectos
598
35%
Arbitraje
64
20% / 58%
Caducado
147
25%
Libre
Ha publicado: 1 artículo, 22 ejemplos
2
Desarrollador 2
Evaluación
(452)
Proyectos
565
26%
Arbitraje
24
42% / 38%
Caducado
85
15%
Trabaja
Ha publicado: 6 ejemplos
3
Desarrollador 3
Evaluación
(567)
Proyectos
656
32%
Arbitraje
41
41% / 46%
Caducado
11
2%
Ocupado
4
Desarrollador 4
Evaluación
(4)
Proyectos
5
20%
Arbitraje
2
0% / 100%
Caducado
1
20%
Libre
Ha publicado: 3 ejemplos
5
Desarrollador 5
Evaluación
(279)
Proyectos
341
37%
Arbitraje
6
50% / 17%
Caducado
7
2%
Libre
Ha publicado: 5 ejemplos
6
Desarrollador 6
Evaluación
(450)
Proyectos
477
69%
Arbitraje
6
67% / 0%
Caducado
2
0%
Trabaja
7
Desarrollador 7
Evaluación
(87)
Proyectos
121
68%
Arbitraje
5
80% / 0%
Caducado
12
10%
Trabaja
8
Desarrollador 8
Evaluación
(2659)
Proyectos
3377
68%
Arbitraje
77
48% / 14%
Caducado
342
10%
Trabaja
Ha publicado: 1 ejemplo
9
Desarrollador 9
Evaluación
(102)
Proyectos
105
60%
Arbitraje
0
Caducado
0
Libre
10
Desarrollador 10
Evaluación
(132)
Proyectos
178
39%
Arbitraje
4
25% / 50%
Caducado
14
8%
Libre
11
Desarrollador 11
Evaluación
(3)
Proyectos
2
50%
Arbitraje
2
0% / 100%
Caducado
0
Libre
Solicitudes similares
I need a mt5 expert advisor as shown in the youtube video. The expert advisor need to work with three digit broker i.e. exness also with two digit broker i.e. vantage. Please specify the settings for both type of brokers. I need same result as shown in the youtube video. Video link is https://www.youtube.com/watch?v=ndVQD7iS1-A
You can control via Telegram: /start - enable bot, begin trading, /stop - end trading, disable bot /status - trade status Bot requirements: • Automated trading throughout the day until 00:00 UTC (Moscow time) (I do not want to trade or turn the bot on 100 times a day). • Auto shutdown of the bot in Telegram at 00:00 UTC (Moscow time) and manual restart when convenient. • Market analysis 24/5 using 20 EMA, RSI, and
I am seeking an alert-only EA. An EA that will follow all the rules but not execute a trade. As this is a repeat posting I am seeking the successful technician - Xiro from Vietnam. Thanks Karl
Ninjatrader bot 30+ USD
I am looking for an experienced developer who specializes in NinjaTrader and NinjaScript to build a fully automated trading bot. The goal is to create a “sniper-style” trading system that focuses on precise entries, strong risk management, and structured trading logic. This is NOT a simple indicator project I am looking for someone who understands algorithmic trading and can translate trading rules into a reliable
Looking for a trading bot / Expert Advisor that wont make dozens of small successful trades and then one or two unsuccessful trades that wipes out your account Requirements: - MT4 capable - Use on the major currency pairs - although open to other currency pairs - Be successful in monetary terms not necessarily in how many successful trades
I need a MT5 Prop firm challenge passing EA with strict prop firm rules compliance. Any strategy can be used but win rate should be above 70%. It should have high impact news filter and a dashboard panel to monitor daily drawdown, target profit, current balance, etc. It should not have martingale, grid, hedging, etc
Hello Developers I have a Project to get done! i have a simple strategy can you please create the automated forex ea to execute my trading strategy? i need custom ea for tradingview and mt4/mt5 correction: i need a tradingview indicator created that tells me when to buy or sell. and ea in mt4/mt5
Pro firm setup 30+ USD
Hi, I am starting a futures prop firm. Are you able to help me get data feed for this with no delays and can handle many traders on the platform. Additionally, are you able to handle charts for us
Mam kody EA Bot. Chciałbym je dokończyć, dopracować i ukończyć projekty. Chciałbym otrzymać pliki SET po ukończeniu EA. Jeśli jesteś zainteresowany, skontaktuj się ze mną. Szukam doświadczonego programisty do stworzenia dedykowanego doradcy eksperckiego (EA) do tradingu. Programista powinien posiadać solidną wiedzę z zakresu MT5, logiki strategii, wskaźników, zarządzania ryzykiem i backtestingu. Doświadczenie w
I am looking for an experienced developer to create a custom Expert Advisor (EA) for trading. The developer should have strong knowledge of MT4/MT5, strategy logic, indicators, risk management, and backtesting. Experience in building reliable and professional trading robots is preferred. Please contact me if you have done similar projects before. 9817724000

Información sobre el proyecto

Presupuesto
90+ USD
Plazo límite de ejecución
de 1 a 3 día(s)