FreelanceSections

Need errors to be fixed on my mql5 language mt5 code

MQL5 Indicators Experts Forex Trading robot/indicator debugging

Job finished

Execution time 4 hours
Feedback from customer
very fast and good to work with
Feedback from employee
Nice working with you, No stress :)

Specification

heres the code (#include <Trade\Trade.mqh>  // Include the CTrade class
CTrade trade;  // Declare an instance of CTrade

// Symbols to trade
string SYMBOLS[] = {"XAUUSDm", "US30m", "GBPUSDm", "USTECm", "EURUSDm"};

// Parameters for 15-minute scalping and integrated strategy
double MIN_LOT_SIZE = 0.01;  // Minimum lot size for most brokers
double TRAILING_STOP_LOSS = 5;      // Trailing stop loss (points)
double RISK_PERCENTAGE = 0.5;        // Risk per trade in percentage (smaller for scalping)
int MA_PERIOD_M5 = 10;              // Moving average period for M15
int MA_PERIOD_D1 = 100;              // Moving average period for D1 (longer-term trend)
int ATR_PERIOD = 5;                  // ATR period for volatility filter
double MIN_ATR_THRESHOLD = 0.0002;   // Minimum ATR value for high volatility (tighter for scalping)
int trade_count = 0;                 // Counter to track the number of trades
datetime last_trade_time = 0;        // Track last trade time for session filtering

// Variables to store the last detected pattern and trend
struct TradeSetup {
    string trend;
    string pattern;
};
TradeSetup last_setup[ArraySize(SYMBOLS)]; // Array to store last setup for each symbol


// Function declarations
double calculate_lot_size(double risk_percentage, double stop_loss_distance);
void log_trade(string symbol, double entry_price, double exit_price, string type);
double adjust_stop_loss(double atr_value);
int execute_trade(string symbol, string type, double lot_size);

// Function to calculate lot size based on risk percentage and stop loss distance
double calculate_lot_size(double risk_percentage, double stop_loss_distance) {
    double account_balance = AccountInfoDouble(ACCOUNT_BALANCE);
    double risk_amount = account_balance * (3 / 100);
    double lot_size = risk_amount / stop_loss_distance;
    return NormalizeDouble(lot_size, 2); // Adjust to the broker's lot size precision
}

// Function to adjust stop loss based on ATR value
double adjust_stop_loss(double atr_value) {
    return atr_value * 1.5; // Adjust this multiplier as needed
}

// Function to log trade details
void log_trade( double entry_price, double exit_price, string type) {
    Print("Trade executed: ", symbol, " Entry: ", entry_price, " Exit: ", exit_price, " Type: ", type);
}

void IntegratedStrategy(double price, double support, double resistance, 
                        double demandZone, double supplyZone,
                        bool isBullishPattern, bool isBearishPattern,
                        bool isBreakout, bool isBreakdown,
                        bool isFalseBreakout, bool isReversal,
                        bool isUptrend, bool isDowntrend,
                        double volume, double rsi)

 //--- Pure Price Action: Reversal at Key Levels
        if (isReversal) {
            // Buying Reversal at Support or Demand Zone
            if (SymbolInfoDouble(symbol, SYMBOL_BID) <= support || SymbolInfoDouble(symbol, SYMBOL_BID) <= demandZone) {
                // Confirmations: Bullish candlestick pattern, volume increase, RSI not overbought
                if (bullishSignal == "bullish_engulfing" && volume > 0 && rsi < 70) {
                    request.action = TRADE_ACTION_DEAL;
                    request.symbol = symbol;
                    request.volume = LOT_SIZE; // You can adjust lot size here
                    request.type = ORDER_TYPE_BUY;
                    request.price = SymbolInfoDouble(symbol, SYMBOL_ASK);
                    request.sl = 3; // Define stop loss (modify as needed)
                    request.tp = 15; // Define take profit (modify as needed)
                    request.deviation = 3;
                    request.comment = "Buy Reversal at Support/Demand";
                    if (!execute_trade(request, result)) {
                    Print("Failed to place Buy order at Supoort/Demand.");
                }
            }

            // Selling Reversal at Resistance or Supply Zone
            if (SymbolInfoDouble(symbol, SYMBOL_BID) >= resistance || SymbolInfoDouble(symbol, SYMBOL_BID) >= supplyZone) {
                // Confirmations: Bearish candlestick pattern, volume increase, RSI overbought
                if (bearishSignal == "bearish_engulfing" && volume > 0 && rsi > 70) {
                    request.action = TRADE_ACTION_DEAL;
                    request.symbol = symbol;
                    request.volume = LOT_SIZE; // You can adjust lot size here
                    request.type = ORDER_TYPE_SELL;
                    request.price = SymbolInfoDouble(symbol, SYMBOL_BID);
                    request.sl = 3; // Define stop loss (modify as needed)
                    request.tp = 15; // Define take profit (modify as needed)
                    request.deviation = 3;
                    request.comment = "Sell Reversal at Resistance/Supply";
                    if (!execute_trade(request, result)) {
                    Print("Failed to place Sell order at Resistance/Supply.");
                }
            }
        }

        //--- Price Action: Breakout or Breakdown
        if (isBreakout && SymbolInfoDouble(symbol, SYMBOL_BID) > resistance) {
            // Buy on confirmed breakout with strong volume
            if (volume > 0 && rsi < 70) {
                request.action = TRADE_ACTION_DEAL;
                request.symbol = symbol;
                request.volume = LOT_SIZE; // You can adjust lot size here
                request.type = ORDER_TYPE_BUY;
                request.price = SymbolInfoDouble(symbol, SYMBOL_ASK);
                request.deviation = 3;
                request.comment = "Buy Breakout";
                if (!execute_trade(request, result)) {
                    Print("Failed to place Buy order at Breakout.");
            }
        }

        if (isBreakdown && SymbolInfoDouble(symbol, SYMBOL_BID) < support) {
            // Sell on confirmed breakdown with strong volume
            if (volume > 0 && rsi > 70) {
                request.action = TRADE_ACTION_DEAL;
                request.symbol = symbol;
                request.volume = LOT_SIZE; // You can adjust lot size here
                request.type = ORDER_TYPE_SELL;
                request.price = SymbolInfoDouble(symbol, SYMBOL_BID);
                request.deviation = 3;
                request.comment = "Sell Breakdown";
                if (!execute_trade(request, result)) {
                    Print("Failed to place Sell order at Breakdown.");
            }
        }

        //--- False Breakout: Sell After False Breakout at Resistance or Buy After False Breakout at Support
        if (isFalseBreakout) {
            if (SymbolInfoDouble(symbol, SYMBOL_BID) > resistance && bearishSignal == "bearish_engulfing" && volume > 0 && rsi > 70) {
                request.action = TRADE_ACTION_DEAL;
                request.symbol = symbol;
                request.volume = LOT_SIZE; // You can adjust lot size here
                request.type = ORDER_TYPE_SELL;
                request.price = SymbolInfoDouble(symbol, SYMBOL_BID);
                request.deviation = 3;
                request.comment = "Sell False Breakout at Resistance";
                if (!execute_trade(request, result)) {
                    Print("Failed to place Sell order at Resistance.");
            }

            if (SymbolInfoDouble(symbol, SYMBOL_BID) < support && bullishSignal == "bullish_engulfing" && volume > 0 && rsi < 30) {
                request.action = TRADE_ACTION_DEAL;
                request.symbol = symbol;
                request.volume = LOT_SIZE; // You can adjust lot size here
                request.type = ORDER_TYPE_BUY;
                request.price = SymbolInfoDouble(symbol, SYMBOL_ASK);
                request.deviation = 3;
                request.comment = "Buy False Breakout at Support";
                if (!execute_trade(request, result)) {
                    Print("Failed to place Buy order at Support.");
            }
        }

        //--- Trend Continuation: Buy in Uptrend at Demand Zone or Support, Sell in Downtrend at Supply Zone or Resistance
        if (isUptrend) {
            if (SymbolInfoDouble(symbol, SYMBOL_BID) <= demandZone || SymbolInfoDouble(symbol, SYMBOL_BID) <= support) {
                if (bullishSignal == "bullish_engulfing" && volume > 0 && rsi < 70) {
                    request.action = TRADE_ACTION_DEAL;
                    request.symbol = symbol;
                    request.volume = LOT_SIZE; // You can adjust lot size here
                    request.type = ORDER_TYPE_BUY;
                    request.price = SymbolInfoDouble(symbol, SYMBOL_ASK);
                    request.deviation = 3;
                    request.comment = "Buy in Uptrend at Demand/Support";
                    if (!execute_trade(request, result)) {
                    Print("Failed to place Buy order at Demand/Support.");
                }
            }
        }

        if (isDowntrend) {
            if (SymbolInfoDouble(symbol, SYMBOL_BID) >= supplyZone || SymbolInfoDouble(symbol, SYMBOL_BID) >= resistance) {
                if (bearishSignal == "bearish_engulfing" && volume > 0 && rsi > 70) {
                    request.action = TRADE_ACTION_DEAL;
                    request.symbol = symbol;
                    request.volume = LOT_SIZE; // You can adjust lot size here
                    request.type = ORDER_TYPE_SELL;
                    request.price = SymbolInfoDouble(symbol, SYMBOL_BID);
                    request.deviation = 3;
                    request.comment = "Sell in Downtrend at Supply/Resistance";
                    if (!execute_trade(request, result)) {
                    Print("Failed to place Sell order at Supply/Resistance.");
                }
            }
        }
    }
}

//--- Function to execute trade with error checking
bool execute_trade(MqlTradeRequest &request, MqlTradeResult &result) {
    if (!OrderSend(request, result)) {
        Print("OrderSend failed with error ", GetLastError());
        return false;
    }
    if (result.retcode != TRADE_RETCODE_DONE) {
        Print("OrderSend failed, return code: ", result.retcode);
        return false;
    }
    Print("Order placed successfully with ticket ", result.order);
    return true;
}

//--- Event handler
void OnTick() {
    strategy_execution(); // Execute strategy on every tick
}
 
// Trailing stop-loss function
void apply_trailing_stop(int ticket, double trail_distance) {
    double current_price = SymbolInfoDouble(Symbol(), SYMBOL_BID);
    double stop_loss = PositionGetDouble(POSITION_SL);

    if (PositionSelectByTicket(ticket) && current_price - trail_distance > stop_loss) {
        MqlTradeRequest request;
        MqlTradeResult result;
        ZeroMemory(request);
        request.action = TRADE_ACTION_SLTP;
        request.position = ticket;
        request.sl = current_price - trail_distance;

        if (!OrderSend(request, result)) {
            Print("Trailing stop modification failed with error ", GetLastError());
        } else if (result.retcode != TRADE_RETCODE_DONE) {
            Print("Trailing stop modification failed, return code: ", result.retcode);
        } else {
            Print("Trailing stop updated successfully for ticket ", ticket);
        }
    }
}

 
// Moving average calculation for trend detection
double calculate_moving_average(string symbol, int period, int timeframe)
{
   double ma[];
   if (CopyBuffer(iMA(symbol, PERIOD_M15, period, 0, MODE_SMA, PRICE_CLOSE), 0, 0, 1, ma) > 0)
      return ma[0];
   return 0;
}

// ATR calculation for volatility filter
double calculate_atr(string symbol, int timeframe, int period)
{
   double atr[];
   if (CopyBuffer(iATR(symbol, PERIOD_M15, period), 0, 0, 1, atr) > 0)
      return atr[0];
   return 0;
}

// Detect trend based on 15-minute and daily charts
string detect_trend(string symbol)
{
   // Calculate moving averages
   double ma_m15 = calculate_moving_average(symbol, MA_PERIOD_M15, PERIOD_M15);
   double ma_d1 = calculate_moving_average(symbol, MA_PERIOD_D1, PERIOD_D1);

   // Retrieve the current price
   double price = iClose(symbol, PERIOD_M15, 0);  // Using M15 period

   // Determine trend based on the price and moving averages
   if (price > ma_m15 && price > ma_d1)
      return "uptrend";
   else if (price < ma_m15 && price < ma_d1)
      return "downtrend";

   return "";  // No clear trend
}


        // Calculate ATR and stop loss distance
        double atr_value = calculate_atr(symbol, PERIOD_M15, atr_period);
        double stop_loss_distance = adjust_stop_loss(atr_value);
        double lot_size = calculate_lot_size(risk_percentage, stop_loss_distance);


// ATR Volatility filter for M15
bool is_volatile(string symbol)
{
   double atr_value = calculate_atr(symbol, PERIOD_M15, ATR_PERIOD);
   return (atr_value >= MIN_ATR_THRESHOLD);
}

// Candlestick pattern detection (e.g., engulfing pattern)
string detect_bullish_engulfing(double &open[], double &close[])
{
   if (close[1] < open[1] && close[0] > open[0] && close[0] > open[1] && open[0] < close[1])
      return "bullish_engulfing";
   return "";
}

string detect_bearish_engulfing(double &open[], double &close[])
{
   if (close[1] > open[1] && close[0] < open[0] && close[0] < open[1] && open[0] > close[1])
      return "bearish_engulfing";
   return "";
}

// Fetch data function
bool get_data(string symbol, int timeframe, int bars, double &high[], double &low[], double &close[], double &open[])
{
   MqlRates rates[];  // Declare an array of MqlRates structures

   // Use CopyRates to fetch the data
   int copied = CopyRates(symbol, PERIOD_M15, 0, bars, rates);

   // Check if rates were successfully copied
   if (copied <= 0)
   {
      Print("Failed to copy rates for ", symbol, " on timeframe ", timeframe);
      return false;
   }

   // Resize the arrays based on the number of bars copied
   ArrayResize(high, copied);
   ArrayResize(low, copied);
   ArrayResize(close, copied);
   ArrayResize(open, copied);

   // Ensure the array is accessed from newest to oldest
   ArraySetAsSeries(rates, true);

   // Copy data into the respective arrays
   for (int i = 0; i < copied; i++)
   {
      high[i] = rates[i].high;
      low[i] = rates[i].low;
      close[i] = rates[i].close;
      open[i] = rates[i].open;
   }

   // Return true if data was successfully copied
   return true;
}

int execute_trade(string symbol, string type, double lot_size) {
    MqlTradeRequest request;
    MqlTradeResult result;
    ZeroMemory(request);
    
    request.action = TRADE_ACTION_DEAL;
    request.symbol = symbol;
    request.volume = lot_size;
    request.type = (type == "buy") ? ORDER_TYPE_BUY : ORDER_TYPE_SELL;
    request.price = (type == "buy") ? SymbolInfoDouble(symbol, SYMBOL_ASK) : SymbolInfoDouble(symbol, SYMBOL_BID);
    request.deviation = 3; // Adjust deviation as needed
    request.comment = type + " trade executed";

    if(OrderSend(request, result)) {
        trade_count++; // Increment trade count on successful trade
        return result.handle; // Return the ticket number
    } else {
        Print("Error executing trade: ", GetLastError());
        return -1; // Return -1 on failure
    }
}

// Function to check if the current time is within trading session hours
bool is_trading_session() {
    datetime current_time = TimeCurrent();
    int hour = TimeHour(current_time);
    // Example: London session (9:00 - 17:00) and New York session (15:00 - 22:00)
    return (hour >= 9 && hour < 17) || (hour >= 15 && hour < 22);
}


// Main trading loop
void OnTick() {
    if(trade_count >= 4)  // Stop execution once trade limit is reached
    {
        Print("Trading halted after opening 4 trades.");
        return;
    }

    for(int i = 0; i < ArraySize(SYMBOLS); i++) {
        string symbol = SYMBOLS[i];
        double high[1000], low[1000], close[1000], open[1000];
        int bars = 1000;  // Number of bars to retrieve

        // Retrieve data, handling the case where it fails
        if (!get_data(symbol, PERIOD_M15, bars, high, low, close, open)) {
            Print("Failed to get data for ", symbol);
            continue;  // Skip to the next symbol if data retrieval fails
        }

        
        // Perform trend detection and get candlestick patterns
        string trend = detect_trend(symbol);
        string bullishSignal = detect_bullish_engulfing(open, close);
        string bearishSignal = detect_bearish_engulfing(open, close);

        // Check if there is volatility and if we're within the trading session
        if (!is_volatile(symbol) || !is_trading_session()) {
            Print("Skipping ", symbol, " due to low volatility or out of trading session.");
            continue;
        }

        // Check if the current setup matches the last one
        if (trend == "uptrend" && bullishSignal == "bullish_engulfing") {
            // If the setup is the same as the last one, skip the trade
            if (last_setup[i].trend == trend && last_setup[i].pattern == bullishSignal) {
                Print("Skipping trade for ", symbol, " as the setup is the same as the last trade.");
                continue;
            }

            // Execute a buy trade
            int ticket = execute_trade(symbol, "buy", MIN_LOT_SIZE);
            log_trade(symbol, SymbolInfoDouble(symbol, SYMBOL_ASK), "BUY");
            apply_trailing_stop(ticket, TRAILING_STOP_LOSS);

            // Update last setup
            last_setup[i].trend = trend;
            last_setup[i].pattern = bullishSignal;
        }
        
        else if (trend == "downtrend" && bearishSignal == "bearish_engulfing") {
            // If the setup is the same as the last one, skip the trade
            if (last_setup[i].trend == trend && last_setup[i].pattern == bearishSignal) {
                Print("Skipping trade for ", symbol, " as the setup is the same as the last trade.");
                continue;
            }

            // Execute a sell trade
            int ticket = execute_trade(symbol, "sell", MIN_LOT_SIZE);
            log_trade(symbol, SymbolInfoDouble(symbol, SYMBOL_BID), "SELL");
            apply_trailing_stop(ticket, TRAILING_STOP_LOSS);

            // Update last setup
            last_setup[i].trend = trend;
            last_setup[i].pattern = bearishSignal;
        }
    }
)

Responded

1
Developer 1
Rating
(45)
Projects
53
57%
Arbitration
2
100% / 0%
Overdue
1
2%
Free
Published: 5 codes
2
Developer 2
Rating
(5)
Projects
5
0%
Arbitration
5
0% / 40%
Overdue
0
Free
3
Developer 3
Rating
(51)
Projects
71
37%
Arbitration
4
25% / 75%
Overdue
1
1%
Free
Published: 1 code
4
Developer 4
Rating
(15)
Projects
20
35%
Arbitration
3
0% / 100%
Overdue
0
Free
Published: 1 code
5
Developer 5
Rating
Projects
4
0%
Arbitration
2
0% / 100%
Overdue
2
50%
Free
6
Developer 6
Rating
(619)
Projects
722
33%
Arbitration
46
48% / 41%
Overdue
14
2%
Loaded
7
Developer 7
Rating
(7)
Projects
8
0%
Arbitration
4
0% / 100%
Overdue
3
38%
Free
8
Developer 8
Rating
Projects
0
0%
Arbitration
3
0% / 100%
Overdue
0
Working
9
Developer 9
Rating
(14)
Projects
15
20%
Arbitration
1
100% / 0%
Overdue
0
Free
10
Developer 10
Rating
(69)
Projects
146
34%
Arbitration
13
8% / 62%
Overdue
26
18%
Free
Published: 6 codes
Similar orders
Tradingview indicator fix 30+ USD
i have my indicator already and i need to fix a little issue in it, CHOCH and Bos indicator, i need to make it multitimeframe, i have a video that i have make regarding all details about the project, the project is not much at all, and i need a good developer that can get it done, i will send the video when you message me
Need EA for XAUUSD Fast Scalper ( Highest Winning Rate ) 30 - 35 USD
Account size 50$ to 100$ or 5000USC to 10000USC ( Account $ Size may not matter ) Max Leverage 1000-2000 Min Lot 0.01 [ if averaging possible ] Averaging + Shift TP Faster Required if Trend Direction is Clear Account Protection Maxx Profit Max Loss Key Based Activation News Filter Need Expert to handle this to avoid false entry [ Developer can suggest extra additional filters inputs here ] as i mentioned I have no
Build a Forex Multi -Basket Trading Bot for Oanda (Python v20 REST API) 30 - 50 USD
Build a Forex Multi-Basket Trading Bot for OANDA (Python v20 REST API Only) MANDATORY DEVELOPER REQUIREMENTS (PLEASE READ BEFORE APPLYING): Do not apply for this project unless you meet the following strict professional criteria: 1. Deep Mathematical & Quantitative Background: You must thoroughly understand statistical distributions, rolling standard deviations (σ), calculating matrix medians, and dynamic Z-score
Build Trading EA the self learns and improves itself 30+ USD
I need an AI based mt5 EA which self learns and improves on its previous mistakes. The EA must be able to utilize numerous trade set ups like; 1. CRT, 2. liquidity sweep reversal at selected higher timeframe where a candle sweeps previous candle high and closes lower or sweeps previous candle low and closes higher, 3. SMC where it trades on OB, CHoCH, BOS. 4. Support and resistance. It should trade any currency pair
Tradingview strategy develop 30+ USD
i need some tradingview strategy that i want to use as a tester, i have something that i am working on currently and i need someone that can provide me with tradingview strategies that doesn't have a win rate, the one with 1:1 RR it need to have low win rate like 10% or 5% profitability, i am not paying $30 for,i dont have up to that for this cause i only want to use it as a test, if anyone have any to send me please
An expert trading bot 100+ USD
hello i need help building a ea bot for mt5 and i have started on claude but i will need someone if a incredible experience to make my ideas come to live. please contact so we can schedule a quick call and i can share anything that concerns you for the task
Custom XAUUSD Gold Grid & Hedge EA for MT5 50 - 150 USD
I need a custom MT5 Expert Advisor (EA) for XAUUSD Gold. I have attached a reference video showing the exact trading behavior I want. Please watch the entire video carefully before starting development. I want the EA to work as closely as possible to the reference video. MAIN TRADING BEHAVIOR: 1. The EA will trade XAUUSD (Gold) on MT5. 2. The EA should automatically open multiple positions without manual
Research and Develop a Robust Commercial XAUUSD EA for MT5 – Strategy Research + Full Source 1000 - 2000 USD
I am looking for an experienced MQL5 developer who can BOTH research trading strategies and develop a commercial-quality MetaTrader 5 Expert Advisor. This is NOT simply a coding job. The developer is free to choose the trading logic, indicators, entry method, exit method, timeframe architecture and strategy type. I do not require the EA to copy or resemble any existing commercial EA. My priority is: ROBUST LONG-TERM
An AI assisted EA forex watch-list scanner (not an auto-trader) of PDL/PDH bounces on M15 is needed. 100 - 150 USD
A developer will create an AI assisted EA forex watch-list scanner (not an auto-trader) designed to surface PDL/PDH bounces on M15, with coding in Python/MQL5. This will strictly be a market intelligence and scanning tool (no automatic order placement) and EA primary function will be a delivery of visual dashboard UI, 2-phased alerts (warning vs. execution), and multi-channel notification. 1. Project Overview &
EA Scalping XAUUSD M15 - EMA Cross 30 - 50 USD
Hello, please make me a simple MT5 Expert Advisor for XAUUSD on M15 timeframe. TRADING LOGIC: - BUY when EMA(10) crosses UP EMA(30) - SELL when EMA(10) crosses DOWN EMA(30) TRADING HOURS: - Only trade between 19:00 - 22:00 WIB / Jakarta time RISK SETTINGS: - Lot size: 0.01 - Stop Loss: 70 points - Take Profit: 150 - 300 points - Max 1 open position Please deliver .ex5 file ready to use. Thank you

Project information

Budget
30+ USD
Deadline
from 1 to 2 day(s)