Download MetaTrader 5

New MQ4 code

To add comments, please log in or register
What is the best place to find a programmer? Freelance service!
sergiodv
283
sergiodv 2015.12.14 04:11 

Hi All,

I have an indicator NonLagMA_v7.1.

It is apparently written in old MQ4 language.

I am trying to use it in eabuilder.com but the code apparently needs to be in "new" code.

Any idea on how we can easily convert one to the other.


Eg this is what it says on the eabuilder website....

" The MQL4 language has significantly changed since build 600 in the beginning of 2014. Old, incompatible indicators include functions init() and start() whereas new indicators include functions OnInit() and OnCalculate()."

So does anyone have an updated version, or a simple way to convert one to the other.

Please DO NOT tell me to use a freelancer to make changes as this is obvious.

Thanks in advance

Irwan Adnan
886
Irwan Adnan 2015.12.14 06:29  
sergiodv:

Hi All,

I have an indicator NonLagMA_v7.1.

It is apparently written in old MQ4 language.

I am trying to use it in eabuilder.com but the code apparently needs to be in "new" code.

Any idea on how we can easily convert one to the other.


Eg this is what it says on the eabuilder website....

" The MQL4 language has significantly changed since build 600 in the beginning of 2014. Old, incompatible indicators include functions init() and start() whereas new indicators include functions OnInit() and OnCalculate()."

So does anyone have an updated version, or a simple way to convert one to the other.

Please DO NOT tell me to use a freelancer to make changes as this is obvious.

Thanks in advance

Change Init() to OnInit() and int start() to OnCalculate. Dont forget to use tabkey after typing that words. Replace return line with new one and remove all new brackets. 
sergiodv
283
sergiodv 2015.12.14 11:45  

I keep getting heap of errors: any chance you can show me the changes so that I can learn from it.

Below is the original code. It appears simple to make the change until I try and compile and then I get heaps of errors.

Thanks in advance

------------------------------------------------------------------------------------------------------------------------------------------------


#property indicator_chart_window
#property indicator_buffers 3
#property indicator_color1 Orange
#property indicator_width1 2
#property indicator_color2 Aqua
#property indicator_width2 2
#property indicator_color3 Magenta
#property indicator_width3 2


//---- input parameters
extern int     Price          = 0;  //Apply to Price(0-Close;1-Open;2-High;3-Low;4-Median price;5-Typical price;6-Weighted Close)
extern int     Length         = 15;  //Period of NonLagMA
extern int     Displace       = 0;  //DispLace or Shift
extern double  PctFilter      = 0;  //Dynamic filter in decimal
extern int     Color          = 1;  //Switch of Color mode (1-color) 
extern int     ColorBarBack   = 1;  //Bar back for color mode
extern double  Deviation      = 0;  //Up/down deviation       
extern int     AlertMode      = 0;  //Sound Alert switch (0-off,1-on)
extern int     WarningMode    = 0;  //Sound Warning switch(0-off,1-on)
//---- indicator buffers
double MABuffer[];
double UpBuffer[];
double DnBuffer[];
double trend[];
double Del[];
double AvgDel[];

double alfa[];
int i, Phase, Len,Cycle=4;
double Coeff, beta, t, Sum, Weight, g;
double pi = 3.1415926535;   
bool   UpTrendAlert=false, DownTrendAlert=false;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
  int init()
  {
   IndicatorBuffers(6);
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,MABuffer);
   SetIndexStyle(1,DRAW_LINE);
   SetIndexBuffer(1,UpBuffer);
   SetIndexStyle(2,DRAW_LINE);
   SetIndexBuffer(2,DnBuffer);
   SetIndexBuffer(3,trend);
   SetIndexBuffer(4,Del);
   SetIndexBuffer(5,AvgDel);
   string short_name;
//---- indicator line
  
   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
//---- name for DataWindow and indicator subwindow label
   short_name="NonLagMA("+Length+")";
   IndicatorShortName(short_name);
   SetIndexLabel(0,"NonLagMA");
   SetIndexLabel(1,"Up");
   SetIndexLabel(2,"Dn");
//----
   SetIndexShift(0,Displace);
   SetIndexShift(1,Displace);
   SetIndexShift(2,Displace);
  
   SetIndexEmptyValue(0,EMPTY_VALUE);
   SetIndexEmptyValue(1,EMPTY_VALUE);
   SetIndexEmptyValue(2,EMPTY_VALUE);
  
   SetIndexDrawBegin(0,Length*Cycle+Length+1);
   SetIndexDrawBegin(1,Length*Cycle+Length+1);
   SetIndexDrawBegin(2,Length*Cycle+Length+1);
//----
  
   Coeff =  3*pi;
   Phase = Length-1;
   Len = Length*4 + Phase; 
   ArrayResize(alfa,Len);
   Weight=0;   
     
      for (i=0;i<Len-1;i++)
      {
      if (i<=Phase-1) t = 1.0*i/(Phase-1);
      else t = 1.0 + (i-Phase+1)*(2.0*Cycle-1.0)/(Cycle*Length-1.0);
      beta = MathCos(pi*t);
      g = 1.0/(Coeff*t+1);  
      if (t <= 0.5 ) g = 1;
      alfa[i] = g * beta;
      Weight += alfa[i];
      }
 
   return(0);
  }

//+------------------------------------------------------------------+
//| NonLagMA_v7.1                                                      |
//+------------------------------------------------------------------+
int start()
{
   int    i,shift, counted_bars=IndicatorCounted(),limit;
   double price;     
   if ( counted_bars > 0 )  limit=Bars-counted_bars;
   if ( counted_bars < 0 )  return(0);
   if ( counted_bars ==0 )  limit=Bars-Len-1;
   if ( counted_bars < 1 )
  
   for(i=1;i<Length*Cycle+Length;i++)
   {
   MABuffer[Bars-i]=0;   
   UpBuffer[Bars-i]=0; 
   DnBuffer[Bars-i]=0; 
   }
  
   for(shift=limit;shift>=0;shift--)
   {   
      Sum = 0;
      for (i=0;i<=Len-1;i++)
       {
      price = iMA(NULL,0,1,0,3,Price,i+shift);     
      Sum += alfa[i]*price;
     
      }
  
    if (Weight > 0) MABuffer[shift] = (1.0+Deviation/100)*Sum/Weight;
  
     
      if (PctFilter>0)
      {
      Del[shift] = MathAbs(MABuffer[shift] - MABuffer[shift+1]);
  
      double sumdel=0;
      for (i=0;i<=Length-1;i++) sumdel = sumdel+Del[shift+i];
      AvgDel[shift] = sumdel/Length;
   
      double sumpow = 0;
      for (i=0;i<=Length-1;i++) sumpow+=MathPow(Del[shift+i]-AvgDel[shift+i],2);
      double StdDev = MathSqrt(sumpow/Length);
    
      double Filter = PctFilter * StdDev;
    
      if( MathAbs(MABuffer[shift]-MABuffer[shift+1]) < Filter ) MABuffer[shift]=MABuffer[shift+1];
      }
      else
      Filter=0;
     
      if (Color>0)
      {
      trend[shift]=trend[shift+1];
      if (MABuffer[shift]-MABuffer[shift+1] > Filter) trend[shift]= 1;
      if (MABuffer[shift+1]-MABuffer[shift] > Filter) trend[shift]=-1;
         if (trend[shift]>0)
         { 
         UpBuffer[shift] = MABuffer[shift];
         if (trend[shift+ColorBarBack]<0) UpBuffer[shift+ColorBarBack]=MABuffer[shift+ColorBarBack];
         DnBuffer[shift] = EMPTY_VALUE;
         if (WarningMode>0 && trend[shift+1]<0 && shift==0) PlaySound("alert2.wav");
         }
         if (trend[shift]<0)
         {
         DnBuffer[shift] = MABuffer[shift];
         if (trend[shift+ColorBarBack]>0) DnBuffer[shift+ColorBarBack]=MABuffer[shift+ColorBarBack];
         UpBuffer[shift] = EMPTY_VALUE;
         if (WarningMode>0 && trend[shift+1]>0 && shift==0) PlaySound("alert2.wav");
         }
      }
   }
//----------  
   string Message;
  
   if ( trend[2]<0 && trend[1]>0 && Volume[0]>1 && !UpTrendAlert)
    {
    Message = " NonLagMA "+Symbol()+" M"+Period()+": Signal for BUY";
    if ( AlertMode>0 ) Alert (Message);
    UpTrendAlert=true; DownTrendAlert=false;
    }
          
    if ( trend[2]>0 && trend[1]<0 && Volume[0]>1 && !DownTrendAlert)
    {
    Message = " NonLagMA "+Symbol()+" M"+Period()+": Signal for SELL";
    if ( AlertMode>0 ) Alert (Message);
    DownTrendAlert=true; UpTrendAlert=false;
    }             
//----
    return(0);   
}


Irwan Adnan
886
Irwan Adnan 2015.12.15 07:50  
sergiodv:

I keep getting heap of errors: any chance you can show me the changes so that I can learn from it.

Below is the original code. It appears simple to make the change until I try and compile and then I get heaps of errors.

Thanks in advance

------------------------------------------------------------------------------------------------------------------------------------------------


#property indicator_chart_window
#property indicator_buffers 3
#property indicator_color1 Orange
#property indicator_width1 2
#property indicator_color2 Aqua
#property indicator_width2 2
#property indicator_color3 Magenta
#property indicator_width3 2


//---- input parameters
extern int     Price          = 0;  //Apply to Price(0-Close;1-Open;2-High;3-Low;4-Median price;5-Typical price;6-Weighted Close)
extern int     Length         = 15;  //Period of NonLagMA
extern int     Displace       = 0;  //DispLace or Shift
extern double  PctFilter      = 0;  //Dynamic filter in decimal
extern int     Color          = 1;  //Switch of Color mode (1-color) 
extern int     ColorBarBack   = 1;  //Bar back for color mode
extern double  Deviation      = 0;  //Up/down deviation       
extern int     AlertMode      = 0;  //Sound Alert switch (0-off,1-on)
extern int     WarningMode    = 0;  //Sound Warning switch(0-off,1-on)
//---- indicator buffers
double MABuffer[];
double UpBuffer[];
double DnBuffer[];
double trend[];
double Del[];
double AvgDel[];

double alfa[];
int i, Phase, Len,Cycle=4;
double Coeff, beta, t, Sum, Weight, g;
double pi = 3.1415926535;   
bool   UpTrendAlert=false, DownTrendAlert=false;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+

int OnInit()


  {
   IndicatorBuffers(6);
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,MABuffer);
   SetIndexStyle(1,DRAW_LINE);
   SetIndexBuffer(1,UpBuffer);
   SetIndexStyle(2,DRAW_LINE);
   SetIndexBuffer(2,DnBuffer);
   SetIndexBuffer(3,trend);
   SetIndexBuffer(4,Del);
   SetIndexBuffer(5,AvgDel);
   string short_name;
//---- indicator line
  
   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
//---- name for DataWindow and indicator subwindow label
   short_name="NonLagMA("+Length+")";
   IndicatorShortName(short_name);
   SetIndexLabel(0,"NonLagMA");
   SetIndexLabel(1,"Up");
   SetIndexLabel(2,"Dn");
//----
   SetIndexShift(0,Displace);
   SetIndexShift(1,Displace);
   SetIndexShift(2,Displace);
  
   SetIndexEmptyValue(0,EMPTY_VALUE);
   SetIndexEmptyValue(1,EMPTY_VALUE);
   SetIndexEmptyValue(2,EMPTY_VALUE);
  
   SetIndexDrawBegin(0,Length*Cycle+Length+1);
   SetIndexDrawBegin(1,Length*Cycle+Length+1);
   SetIndexDrawBegin(2,Length*Cycle+Length+1);
//----
  
   Coeff =  3*pi;
   Phase = Length-1;
   Len = Length*4 + Phase; 
   ArrayResize(alfa,Len);
   Weight=0;   
     
      for (i=0;i<Len-1;i++)
      {
      if (i<=Phase-1) t = 1.0*i/(Phase-1);
      else t = 1.0 + (i-Phase+1)*(2.0*Cycle-1.0)/(Cycle*Length-1.0);
      beta = MathCos(pi*t);
      g = 1.0/(Coeff*t+1);  
      if (t <= 0.5 ) g = 1;
      alfa[i] = g * beta;
      Weight += alfa[i];
      }
 

   return(INIT_SUCCEEDED);


  }

//+------------------------------------------------------------------+
//| NonLagMA_v7.1                                                      |
//+------------------------------------------------------------------+

int OnCalculate(const int rates_total,

                const int prev_calculated,

                const datetime& time[],

                const double& open[],

                const double& high[],

                const double& low[],

                const double& close[],

                const long& tick_volume[],

                const long& volume[],

                const int& spread[])


{
   int    i,shift, counted_bars=IndicatorCounted(),limit;
   double price;     
   if ( counted_bars > 0 )  limit=Bars-counted_bars;
   if ( counted_bars < 0 )  return(0);
   if ( counted_bars ==0 )  limit=Bars-Len-1;
   if ( counted_bars < 1 )
  
   for(i=1;i<Length*Cycle+Length;i++)
   {
   MABuffer[Bars-i]=0;   
   UpBuffer[Bars-i]=0; 
   DnBuffer[Bars-i]=0; 
   }
  
   for(shift=limit;shift>=0;shift--)
   {   
      Sum = 0;
      for (i=0;i<=Len-1;i++)
       {
      price = iMA(NULL,0,1,0,3,Price,i+shift);     
      Sum += alfa[i]*price;
     
      }
  
    if (Weight > 0) MABuffer[shift] = (1.0+Deviation/100)*Sum/Weight;
  
     
      if (PctFilter>0)
      {
      Del[shift] = MathAbs(MABuffer[shift] - MABuffer[shift+1]);
  
      double sumdel=0;
      for (i=0;i<=Length-1;i++) sumdel = sumdel+Del[shift+i];
      AvgDel[shift] = sumdel/Length;
   
      double sumpow = 0;
      for (i=0;i<=Length-1;i++) sumpow+=MathPow(Del[shift+i]-AvgDel[shift+i],2);
      double StdDev = MathSqrt(sumpow/Length);
    
      double Filter = PctFilter * StdDev;
    
      if( MathAbs(MABuffer[shift]-MABuffer[shift+1]) < Filter ) MABuffer[shift]=MABuffer[shift+1];
      }
      else
      Filter=0;
     
      if (Color>0)
      {
      trend[shift]=trend[shift+1];
      if (MABuffer[shift]-MABuffer[shift+1] > Filter) trend[shift]= 1;
      if (MABuffer[shift+1]-MABuffer[shift] > Filter) trend[shift]=-1;
         if (trend[shift]>0)
         { 
         UpBuffer[shift] = MABuffer[shift];
         if (trend[shift+ColorBarBack]<0) UpBuffer[shift+ColorBarBack]=MABuffer[shift+ColorBarBack];
         DnBuffer[shift] = EMPTY_VALUE;
         if (WarningMode>0 && trend[shift+1]<0 && shift==0) PlaySound("alert2.wav");
         }
         if (trend[shift]<0)
         {
         DnBuffer[shift] = MABuffer[shift];
         if (trend[shift+ColorBarBack]>0) DnBuffer[shift+ColorBarBack]=MABuffer[shift+ColorBarBack];
         UpBuffer[shift] = EMPTY_VALUE;
         if (WarningMode>0 && trend[shift+1]>0 && shift==0) PlaySound("alert2.wav");
         }
      }
   }
//----------  
   string Message;
  
   if ( trend[2]<0 && trend[1]>0 && Volume[0]>1 && !UpTrendAlert)
    {
    Message = " NonLagMA "+Symbol()+" M"+Period()+": Signal for BUY";
    if ( AlertMode>0 ) Alert (Message);
    UpTrendAlert=true; DownTrendAlert=false;
    }
          
    if ( trend[2]>0 && trend[1]<0 && Volume[0]>1 && !DownTrendAlert)
    {
    Message = " NonLagMA "+Symbol()+" M"+Period()+": Signal for SELL";
    if ( AlertMode>0 ) Alert (Message);
    DownTrendAlert=true; UpTrendAlert=false;
    }             
//----
      return(rates_total);


}


To add comments, please log in or register