i Need help in fixing this indicator

New comment
 
this indicator is not auto refreshing alongwith the chart progress, thanks in advance 
//+------------------------------------------------------------------+
//|                        MAB_TD_Sequential                         |
//|                              v1.2                                |
//|                                                                  |
//|   Indicator based off of Tom DeMarks' TD Sequential indicator as |
//|   described in Jason Perl's book "DeMark Indicators"             |
//|                                                                  |
//|   05/22/2009 - Created Buy and Sell Setup along with TDST lines  |
//|               and set up criteria for arrow and alert to appear  |
//|               for a perfect setup.                               |
//|      issues:  TDST line starts updating before a full setup is   |
//|               made                                               |
//|      still needs:  Countdown criteria                            |
//|                                                                  |
//|   05/26/2009 - Added the Countdown criteria.  Countdown will also|
//|               create a "+" when 13 is reach but not perfected.   |
//|      still needs:  Countdown recycle criteria(currently recycles |
//|                  automatically when setup completed)             |   
//+------------------------------------------------------------------+
#property copyright "Copyright © 2009, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"

#property indicator_chart_window
#property indicator_buffers 6
#property indicator_color1 Red
#property indicator_color2 Green
#property indicator_color3 MediumSpringGreen
#property indicator_color4 MediumSpringGreen
#property indicator_color5 Gold
#property indicator_color6 Gold

extern color Setup=MediumSpringGreen;
extern color Countdown=Gold;

extern int NumBars=1000;
extern int Space=50;    //space above or below high to place number


extern bool Alerts=false;

double Support[],Resistance[],bPerfected[],sPerfected[],Buy[],Sell[];

datetime last_alert=0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
//TDST lines
   SetIndexBuffer(0,Support);
   SetIndexStyle(0,DRAW_LINE,STYLE_DOT,1);
   SetIndexEmptyValue(0,EMPTY_VALUE);
   SetIndexBuffer(1,Resistance);
   SetIndexStyle(1,DRAW_LINE,STYLE_DOT,1);
   SetIndexEmptyValue(1,EMPTY_VALUE);

//Perfected Setup
   SetIndexBuffer(2,bPerfected);
   SetIndexStyle(2,DRAW_ARROW,0,5);
   SetIndexArrow(2,225);
   SetIndexBuffer(3,sPerfected);
   SetIndexStyle(3,DRAW_ARROW,0,5);
   SetIndexArrow(3,226);

//Countdown
   SetIndexBuffer(4,Buy);
   SetIndexStyle(4,DRAW_ARROW,0,5);
   SetIndexArrow(4,225);
  
  
   SetIndexBuffer(5,Sell);
   SetIndexStyle(5,DRAW_ARROW,0,5);
   SetIndexArrow(5,226);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   for(int i=0;i<Bars;i++)
     {
      ObjectDelete(""+i);
      ObjectDelete("cd"+i);
     }
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   ChartRedraw();
   RefreshRates();
   
   int counted_bars=IndicatorCounted();
   if(counted_bars < 0)  return(-1);
   if(counted_bars>0) counted_bars--;
   int limit=Bars-counted_bars;
   if(counted_bars==0) limit-=1+8;
   if(limit<NumBars) return(-1);

   int bSetup,sSetup,bCountdown,sCountdown;
   int x;
   double tfm=Space*Point;
   double CountTest;
   bool bSetupInd,sSetupInd,bPerfect,sPerfect;
//----
   for(int i=NumBars; i>=0; i--)
     {
      ObjectDelete(""+i);
      ObjectDelete("cd"+i);
      //+------------------------------------------------------------------+
      //| Buy Setup                                                        |
      //+------------------------------------------------------------------+
      if(Close[i]<=Close[i+4] && Close[i+1]>=Close[i+5] && bSetup==0)//start setup
        {
         bSetup++;
         ObjectCreate(""+i,OBJ_TEXT,0,Time[i],Low[i]-tfm);
         ObjectSetText(""+i,""+bSetup,8,"Arial",Setup);
        }
      if(Close[i]<Close[i+4] && bSetup!=0 && ObjectFind(""+i)==-1)
        {
         bSetup++;
         if(bSetup==9)
           {
            ObjectCreate(""+i,OBJ_TEXT,0,Time[i],Low[i]-tfm);
            ObjectSetText(""+i,""+bSetup,15,"Arial Black",Setup);
            bSetup=0;
            bSetupInd=true;
            sSetupInd=false;
            sCountdown=0;
           }
         else
           {
            ObjectCreate(""+i,OBJ_TEXT,0,Time[i],Low[i]-tfm);
            ObjectSetText(""+i,""+bSetup,8,"Arial",Setup);
           }
        }
      //if setup is completed look for criteria for perfect setup
      if(bSetupInd==true)
        {
         if(Low[i+1]<=Low[i+3] || Low[i]<=Low[i+2])
           {
            bSetupInd=false;
            bPerfect=true;
            bPerfected[i]=Low[i]-tfm*2;
            bCountdown=1;
           }
         if(Alerts==True && last_alert!=Time[0])
           {
            last_alert=Time[0];
            Alert("TD Sequential - ",Symbol()," Buy Signal Perfected");
           }
        }
      //Deletes numbers that were created if there is a break in sequence before 9 is reached
      else if(Close[i]>=Close[i+4] && bSetup!=0)
        {
         for(x=i+1; x<=i+bSetup+1; x++) ObjectDelete(""+x);
         bSetup=0;
        }
      //+------------------------------------------------------------------+
      //| Buy Countdown Setup                                              |
      //+------------------------------------------------------------------+
      if(bCountdown==13 && Close[i]<=Close[i+1] && Close[i]>CountTest)
        {
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],Low[i]-tfm*2.5);
         ObjectSetText("cd"+i,"+",18,"Arial",Countdown);
        }
      if(bCountdown==13 && Close[i]<=Close[i+1] && Close[i]<=CountTest)
        {
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],Low[i]-tfm*2.5);
         ObjectSetText("cd"+i,""+bCountdown,18,"Arial",Countdown);
         bCountdown=0;
         if(Alerts==True && last_alert!=Time[0])
           {
            last_alert=Time[0];
            Alert("TD Sequential - ",Symbol()," Buy Countdown Completed");
           }
         Buy[i]=Low[i]-tfm*4;
        }
      if(bCountdown>=1 && bCountdown<13 && Close[i]<=Close[i+2])
        {
         if(bCountdown==8)CountTest=Close[i];
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],Low[i]-tfm*2.5);
         ObjectSetText("cd"+i,""+bCountdown,8,"Arial",Countdown);
         bCountdown++;
        }
      //+------------------------------------------------------------------+
      //| Sell Setup                                                       |
      //+------------------------------------------------------------------+
      if(Close[i]>=Close[i+4] && Close[i+1]<=Close[i+5] && bSetup==0)//start setup
        {
         sSetup++;
         ObjectCreate(""+i,OBJ_TEXT,0,Time[i],High[i]+tfm);
         ObjectSetText(""+i,""+sSetup,8,"Arial",Setup);
        }
      if(Close[i]>=Close[i+4] && sSetup!=0 && ObjectFind(""+i)==-1)
        {
         sSetup++;
         if(sSetup==9)
           {
            ObjectCreate(""+i,OBJ_TEXT,0,Time[i],High[i]+tfm);
            ObjectSetText(""+i,""+sSetup,15,"Arial Black",Setup);
            sSetup=0;
            sSetupInd=true;
            bSetupInd=false;
            bCountdown=0;
           }
         else
           {
            ObjectCreate(""+i,OBJ_TEXT,0,Time[i],High[i]+tfm);
            ObjectSetText(""+i,""+sSetup,18,"Arial",Setup);
           }
        }
      //Perfected Setup
      ChartRedraw();
      if(sSetupInd==true)
        {
         if(Low[i+1]>=Low[i+3] || Low[i]>=Low[i+2])
           {
            sSetupInd=false;
            sPerfect=true;
            sPerfected[i]=High[i]+tfm*2;
            sCountdown=1;
           }
         if(Alerts==True && last_alert!=Time[0])
           {
            last_alert=Time[0];
            Alert("TD Sequential - ",Symbol()," Sell Signal Perfected");
           }
        }
      //Deletes numbers that were created if there is a break in sequence before 9 is reached
      else if(Close[i]<=Close[i+4] && sSetup!=0)
        {
         for(x=i+1; x<=i+sSetup; x++) ObjectDelete(""+x);
         sSetup=0;
        }
      //+------------------------------------------------------------------+
      //| Sell Countdown Setup                                             |
      //+------------------------------------------------------------------+
      if(sCountdown==13 && Close[i]>=Close[i+2] && Close[i]>=CountTest)
        {
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],High[i]+tfm*2.5);
         ObjectSetText("cd"+i,""+sCountdown,8,"Arial",Countdown);
         sCountdown=0;
         Sell[i]=High[i]+tfm*4;
         if(Alerts==True && last_alert!=Time[0])
           {
            last_alert=Time[0];
            Alert("TD Sequential - ",Symbol()," Sell Countdown Completed");
           }
        }
      if(sCountdown==13 && Close[i]>=Close[i+2] && Close[i]<CountTest)
        {
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],High[i]+tfm*2.5);
         ObjectSetText("cd"+i,"+",8,"Arial",Countdown);
        }
      if(sCountdown>=1 && sCountdown<13 && Close[i]>=Close[i+2])
        {
         if(sCountdown==8)CountTest=Close[i];
         ObjectCreate("cd"+i,OBJ_TEXT,0,Time[i],High[i]+tfm*2.5);
         ObjectSetText("cd"+i,""+sCountdown,8,"Arial",Countdown);
         sCountdown++;
        }
     }
//+------------------------------------------------------------------+
//| TDST Support and Resistance lines                                |
//+------------------------------------------------------------------+
   for(int j=limit-8; j>=0+8; j--)
     {
      //TDST Support
      if(Close[j]<=Close[j+4] && Close[j+1]>=Close[j+5] && Close[j-1]<=Close[j+3] && Close[j-2]<=Close[j+2] && 
         Close[j-3]<=Close[j+1] && Close[j-4]<=Close[j] && Close[j-5]<=Close[j-1] && Close[j-6]<=Close[j-2] &&
         Close[j-7]<=Close[j-3] && Close[j-8]<=Close[j-4])
        {
         Support[j]=High[j];
         Support[j+1]=EMPTY_VALUE;
        }
      else Support[j]=Support[j+1];
      //TDST Resistance
      if(Close[j]>=Close[j+4] && Close[j+1]<=Close[j+5] && Close[j-1]>=Close[j+3] && Close[j-2]>=Close[j+2] && 
         Close[j-3]>=Close[j+1] && Close[j-4]>=Close[j] && Close[j-5]>=Close[j-1] && Close[j-6]>=Close[j-2] &&
         Close[j-7]>=Close[j-3] && Close[j-8]>=Close[j-4])
        {
         Resistance[j]=Low[j];
         Resistance[j+1]=EMPTY_VALUE;
        }
      else Resistance[j]=Resistance[j+1];
     }
//----
   ChartRedraw();
   RefreshRates(); 
   ChartRedraw(); 
   return(0);
  }
//+------------------------------------------------------------------+
  
   int counted_bars=IndicatorCounted();
   if(counted_bars < 0)  return(-1);
   if(counted_bars>0) counted_bars--;
   int limit=Bars-counted_bars;
   if(counted_bars==0) limit-=1+8;
   if(limit<NumBars) return(-1);
⋮
   for(int i=NumBars; i>=0; i--)

  1. No need for the decrement. Contradictory information on IndicatorCounted() - MQL4 programming forum (2022)

  2. Because that is not how you do your lookbacks. After the first run, limit will be negative and you do nothing.
              How to do your lookbacks correctly #9 — #14 & #19 (2016)

    See How to do your lookbacks correctly #9 — #14 & #19. (2016)

  3. You should stop using the old event handlers (init, start, deinit) and IndicatorCounted() and start using new event handlers (OnInit, OnTick/OnCalculate, OnDeinit).
              Event Handling Functions - MQL4 Reference
              How to do your lookbacks correctly - MQL4 programming forum #9-14 & #19 (2016)

 
Your topic has been moved to the section: MQL4 e MetaTrader 4 — In the future, please consider which section is most appropriate for your query.
New comment