Strange in copybuffer ATR

Minh Truong Pham 2023.05.22 08:25

I found something strange in copybuffer atr indicator. the value return EMPTY_VALUE if shift is far from current. Anyone get this problem?

//+------------------------------------------------------------------+
//|                                                  TestCopyATR.mq5 |
//|                                                         truongxx |
//+------------------------------------------------------------------+
#property copyright "truongxx"
#property link      ""
#property version   "1.00"
#property indicator_chart_window

int handle_atr=0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {
//--- indicator buffers mapping
   handle_atr=iATR(_Symbol, PERIOD_CURRENT, 200);
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
//---
   if(prev_calculated<=0)
   {  
      Print("rates_total:",rates_total);
      for(int i=401;i<rates_total;i++)
      {
         double atr[];
         CopyBuffer(handle_atr, 0, i, 1, atr);
         Print("atr:",atr[0]);
      }
      
   }
//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+

Tobias Johannes Zimmer 2023.05.22 09:09 #1

Try printing ATR[rates_total-1].

But also you don't need to put CopyBuffer inside a loop it is not good practice. It needs to run only once to get all the values in the buffer. But you will need to search for limit and to_copy to define the lookbacks right.

And I would strongly recommend that you separate for the for loop from the Copybuffer in your project and test both of them on its own. Because like this you are mixing them up until you don't know which is which.

Instead finding out which is which and how they work should be the first thing to do.

MQL5 Wizard: Development of Loop Operator while Questions about how to

William Roeder 2023.05.22 11:17 #2

Minh Truong Pham: I found something strange in copybuffer atr indicator. the value return EMPTY_VALUE if shift is far from current. Anyone get this problem?

Nothing strange there. To calculate a SMA of length 200, you need at least 200 values. The "a" in ATR means average.

      for(int i=401;i<rates_total - 199 ;i++)

New comment