Cant close pending orders by time.

[[Deleted]]

  int orders =0;
   for(int i= OrdersTotal()-1; i>=0; i--)
     {
      ulong orderTicket = OrderGetTicket(i);
      if(OrderSelect(orderTicket))
        {
         if(OrderGetString(ORDER_SYMBOL)== _Symbol && OrderGetInteger(ORDER_MAGIC) == eaMagic)
           {
            if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - 30 * PeriodSeconds(PERIOD_MN1))
              {
               trade.OrderDelete(orderTicket);
              }
            orders = orders + 1;
           }
        }
     }

Hey, guys please help me out with this.

[R4tna C]

aviyadav321:

Hey, guys please help me out with this.

What are you aiming to calculate with this? 30 mins back?

            if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - 30 * PeriodSeconds(PERIOD_MN1))

[Carl Schreiber]

Du you know what PERIOD_MN1 means and how long 30 * PeriodSeconds(PERIOD_MN1) will be?

Use the debugger to find out: https://www.mql5.com/en/articles/654 or read the reference: place the cursor on PeriodSeconds and press F1

[Carl Schreiber]

Don't double post! I deleted the other one.

[R4tna C]

Carl Schreiber #:

Du you know what PERIOD_MN1 means and how long 30 * PeriodSeconds(PERIOD_MN1) will be?

Use the debugger to find out: https://www.mql5.com/en/articles/654 or read the reference: place the cursor on PeriodSeconds and press F1

Good point - I misread that as PERIOD_M1

[Dwi Sudarsono]

please add expiration time for order send sir

[William Roeder]

Dwi Sudarsono #: please add expiration time for order send sir

Some brokers do not support expiration time.

[Dominik Egert]

I have a question.

What's the calculation order here?

if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - 30 * PeriodSeconds(PERIOD_MN1))

Isn't this first addition then multiply the result of addition?

Or is the result the same as this:

if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - (30 * PeriodSeconds(PERIOD_MN1)))

[Keith Watford]

Dominik Christian Egert #:

I have a question.

What's the calculation order here?

if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - 30 * PeriodSeconds(PERIOD_MN1))

Isn't this first addition then multiply the result of addition?

Or is the result the same as this:

if(OrderGetInteger(ORDER_TIME_SETUP) < TimeCurrent() - (30 * PeriodSeconds(PERIOD_MN1)))

The 2nd one

[William Roeder]

Dominik Christian Egert #: What's the calculation order here?

Perhaps you should read the manual. Precedence Rules - Operations and Expressions - Language Basics - MQL5 Reference - Reference on algorithmic/automated trading language for MetaTrader 5
   How To Ask Questions The Smart Way. (2004)
      How To Interpret Answers.
         RTFM and STFW: How To Tell You've Seriously Screwed Up.

[William Roeder]

You should be able to read your code out loud and have it make sense. Thus, I would rewrite your test to if(duration >= 30 x)

if(TimeCurrent() - OrderGetInteger(ORDER_TIME_SETUP) >= (30 * PeriodSeconds(PERIOD_MN1)))