Tester Visual Mode opens a single indicator window endlessly

Wilson Wong 2022.04.04 12:57

I have no idea why EA is behaving this way in visual mode. Plus it dumps this error message too:

failed market sell 0.03 EURUSD.a [Market closed]
Error opening order : 10018 Market is closed

Files:

Screenshot_from_2022-04-04_20-53-19.png 49 kb

Fernando Carreiro 2022.04.04 13:14 #1

Wilson Wong: I have no idea why EA is behaving this way in visual mode. Plus it dumps this error message too:

Your EA is very badly coded and continuously opening new indicator handles. You should only initialise indicator handles in OnInit() and not in OnTick().

Also, you are not checking the trading session times before placing orders and that is why you are getting "Market Closed" errors.

If you want further guidance then you will have to show your code.

why strategy tester doesnt Close Price-ATR in array Questions from Beginners MQL5

Wilson Wong 2022.04.04 23:22 #2

Fernando Carreiro #:

Your EA is very badly coded and continuously opening new indicator handles. You should only initialise indicator handles in OnInit() and not in OnTick().

Also, you are not checking the trading session times before placing orders and that is why you are getting "Market Closed" errors.

If you want further guidance then you will have to show your code.

You are right, the codes are certainly not optimized on MQL5 since they are "ported" over from MQL4 with my "freshly acquired" knowledge of MQL5 with lots of trial and error. This EA has a special ability to test combinations of indicators and facilitate addition of more new indicators to find the "effectiveness" of indicator combinations. I eyed the "multi-core" capabilities of MQL5 to speed up testing hence I ventured here. The EA was coded in MQL4 to call indicators directly from functions in multiple .mqh header files. My crude patching added "indicator handles" in place right where MQL4 codes were asking for indicators inputs. So as i understand your comment, the codes would have to be re-arranged so indicator handles are all to be placed in OnInit().

On checking the "trading session" that is certainly a valuable input to me. I will try to incorporate that into my codes.

Advise on MQL4 vs Accessing Opened orders in Any questions from newcomers

Fernando Carreiro 2022.04.04 23:49 #3

Wilson Wong #: You are right, the codes are certainly not optimized on MQL5 since they are "ported" over from MQL4 with my "freshly acquired" knowledge of MQL5 with lots of trial and error. This EA has a special ability to test combinations of indicators and facilitate addition of more new indicators to find the "effectiveness" of indicator combinations. I eyed the "multi-core" capabilities of MQL5 to speed up testing hence I ventured here. The EA was coded in MQL4 to call indicators directly from functions in multiple .mqh header files. My crude patching added "indicator handles" in place right where MQL4 codes were asking for indicators inputs. So as i understand your comment, the codes would have to be re-arranged so indicator handles are all to be placed in OnInit(). On checking the "trading session" that is certainly a valuable input to me. I will try to incorporate that into my codes.

I suggest you first learn to code in MQL5 properly before trying to convert such a complicated EA from MQL4. MQL5 can very different.

New comment