Changing the Stop Loss and Take Profit of all Orders

New comment
 

Hi, I' having a hard time with changing the SL and TP of all active orders. See code below, It seems to never close trade 1 (order 0).

Should the below code not change all orders to the same stop loss and take profit?


  for(int i=0;i<OrdersTotal();i++)
     {
      if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderMagicNumber()!=MAGICMA || OrderSymbol()!=Symbol()) continue;
      
 //-----------------------------------------------------Trailing Stop----------------------------------------------
       if(NormalizeDouble((Bid-OrderStopLoss()), Digits)>NormalizeDouble(Point*BuyStopLoss, Digits) && OrderType()==OP_BUY)
        {
           resb = (OrderModify(OrderTicket(),OrderOpenPrice(),BuyStopLoss,UpperBandSell,0,Blue));
           }

       if(NormalizeDouble((OrderStopLoss()-Ask), Digits)>NormalizeDouble(Point*SellStopLoss, Digits) && OrderType()==OP_SELL)   
       {
           ress = (OrderModify(OrderTicket(),OrderOpenPrice(),SellStopLoss,LowerBandBuy,0,Red));
           }
          
 

  1. In the presence of multiple orders (one EA multiple charts, multiple EAs, manual trading,) while you are waiting for the current operation (closing, deleting, modifying) to complete, any number of other operations on other orders could have concurrently happened and changed the position indexing:

    1. For non-FIFO (non-US brokers), (or the EA only opens one order per symbol,) you can simply count down, in a position loop, and you won't miss orders. Get in the habit of always counting down.
                Loops and Closing or Deleting Orders - MQL4 programming forum
    2. For In First Out (FIFO rules — US brokers,) and you (potentially) process multiple orders per symbol, you must find the earliest order (count up,) close it, and on a successful operation, reprocess all positions.
                CloseOrders by FIFO Rules - Strategy Tester - MQL4 programming forum - Page 2 #16
                MetaTrader 5 platform beta build 2155: MQL5 scope, global Strategy Tester and built-in Virtual Hosting updates - Best Expert Advisors - General - MQL5 programming forum #1.11 ACCOUNT_FIFO_CLOSE

    3. and check OrderSelect in case later positions were deleted.
                What are Function return values ? How do I use them ? - MQL4 programming forum
                Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles
    4. and if you (potentially) process multiple orders, must call RefreshRates() after server calls if you want to use, on the next order / server call, the Predefined Variables (Bid/Ask.) Or instead, be direction independent and just use OrderClosePrice(). 

  2. ress = OrderModify(…
    Check your return codes, and report your errors (including market prices and your variables). Don't look at GLE/LE unless you have an error. Don't just silence the compiler (strict), it is trying to help you.
              What are Function return values ? How do I use them ? - MQL4 programming forum 2012.05.20
              Common Errors in MQL4 Programs and How to Avoid Them - MQL4 Articles 25 March 2014

New comment
Reason: