only one trade per candle

SIMONE MARELLI 2020.04.06 14:06 #1

jefsar:
hello, I would like to make a change to my Expert Advisor. Is it possible to add an option that obliques my expert advisor to open only one trade per candle? If needs, I can pass on my code. Thanks in advance

bool NewBar()
{
static datetime lastbar;
datetime curbar = Time[0];
if(lastbar!=curbar)
{
lastbar=curbar;
return (true);
}
else
{
return(false);
}
}

jefsar 2020.04.06 14:23 #2

Thanks, where can i write it in my code :

extern int MagicNumber=1;
extern double Lots =0.01;
extern double StopLoss=120;
extern double TakeProfit=100;
extern int TrailingStop=0;
extern int Slippage=3;
//+------------------------------------------------------------------+
//    expert start function
//+------------------------------------------------------------------+
int start()
{
double MyPoint=Point;
if(Digits==3 || Digits==5) MyPoint=Point*10;

double TheStopLoss=0;
double TheTakeProfit=0;
double MoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,0);
double DerniereMoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,1);
double MoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,0);
double DerniereMoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,1);

if( TotalOrdersCount()==0 )
{
     int result=0;
     if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)&&(MoyenneMobileFast>MoyenneMobileSlow)) // Here is your open buy rule
     {
        result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Blue);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);

        }
        return(0);
     }
     if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)&&(MoyenneMobileFast<MoyenneMobileSlow)) // Here is your open Sell rule
     {
        result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Red);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
         bougie=Bars;
        }
        return(0);
     }
}

for(int cnt=0;cnt<OrdersTotal();cnt++)
     {
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
      if(OrderType()<=OP_SELL &&
         OrderSymbol()==Symbol() &&
         OrderMagicNumber()==MagicNumber
         )
        {
         if(OrderType()==OP_BUY)
           {
              if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)
              &&(MoyenneMobileFast<MoyenneMobileSlow)) //here is your close buy rule
              {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
              }
            if(TrailingStop>0)
              {
               if(Bid-OrderOpenPrice()>MyPoint*TrailingStop)
                 {
                  if(OrderStopLoss()<Bid-MyPoint*TrailingStop)
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green);
                     return(0);
                    }
                 }
              }
           }
         else    SINON
           {
                if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)
                  &&(MoyenneMobileFast>MoyenneMobileSlow)) // here is your close sell rule
                {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
                }
            if(TrailingStop>0)
              {
               if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop))
                 {
                  if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0))
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red);
                     return(0);
                    }
                 }
              }
           }
        }
     }
   return(0);
}

int TotalOrdersCount()
{
int result=0;
for(int i=0;i<OrdersTotal();i++)
{
OrderSelect(i,SELECT_BY_POS ,MODE_TRADES);
if (OrderMagicNumber()==MagicNumber) result++;

}
return (result);
}

My robot can't execute Arráy help i have a problem

Sergey Golubev 2020.04.06 14:26 #3

Forum on trading, automated trading systems and testing trading strategies

When you post code please use the CODE button (Alt-S)!

Use the CODE button

jefsar 2020.04.06 14:31 #4

Sorry,

extern int MagicNumber=1;
extern double Lots =0.01;
extern double StopLoss=120;
extern double TakeProfit=100;
extern int TrailingStop=0;
extern int Slippage=3;
//+------------------------------------------------------------------+
//    expert start function
//+------------------------------------------------------------------+
int start()
{
  double MyPoint=Point;
  if(Digits==3 || Digits==5) MyPoint=Point*10;
  
  double TheStopLoss=0;
  double TheTakeProfit=0;
  double MoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,0);
  double DerniereMoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,1);
  double MoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,0);
  double DerniereMoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,1);
  
  if( TotalOrdersCount()==0 ) 
  {
     int result=0;
     if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)&&(MoyenneMobileFast>MoyenneMobileSlow)) // Here is your open buy rule
     {
        result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Blue);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
         
        }
        return(0);
     }
     if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)&&(MoyenneMobileFast<MoyenneMobileSlow)) // Here is your open Sell rule
     {
        result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Red);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
         bougie=Bars;
        }
        return(0);
     }
  }
  
  for(int cnt=0;cnt<OrdersTotal();cnt++)
     {
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
      if(OrderType()<=OP_SELL &&   
         OrderSymbol()==Symbol() &&
         OrderMagicNumber()==MagicNumber 
         )  
        {
         if(OrderType()==OP_BUY)  
           {
              if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)
              &&(MoyenneMobileFast<MoyenneMobileSlow)) //here is your close buy rule
              {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
              }
            if(TrailingStop>0)  
              {                 
               if(Bid-OrderOpenPrice()>MyPoint*TrailingStop)
                 {
                  if(OrderStopLoss()<Bid-MyPoint*TrailingStop)
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green);
                     return(0);
                    }
                 }
              }
           }
         else    SINON
           {
                if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)
                  &&(MoyenneMobileFast>MoyenneMobileSlow)) // here is your close sell rule
                {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
                }
            if(TrailingStop>0)  
              {                 
               if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop))
                 {
                  if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0))
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red);
                     return(0);
                    }
                 }
              }
           }
        }
     }
   return(0);
}

int TotalOrdersCount()
{
  int result=0;
  for(int i=0;i<OrdersTotal();i++)
  {
     OrderSelect(i,SELECT_BY_POS ,MODE_TRADES);
     if (OrderMagicNumber()==MagicNumber) result++;

   }
  return (result);
}

SIMONE MARELLI 2020.04.06 14:35 #5

jefsar:

Thanks, where can i write it in my code :

extern int MagicNumber=1;
extern double Lots =0.01;
extern double StopLoss=120;
extern double TakeProfit=100;
extern int TrailingStop=0;
extern int Slippage=3;
//+------------------------------------------------------------------+
//    expert start function
//+------------------------------------------------------------------+
int start()
{
double MyPoint=Point;
if(Digits==3 || Digits==5) MyPoint=Point*10;

double TheStopLoss=0;
double TheTakeProfit=0;
double MoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,0);
double DerniereMoyenneMobileFast=iMA(NULL,0,48,0,MODE_SMA,PRICE_OPEN,1);
double MoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,0);
double DerniereMoyenneMobileSlow=iMA(NULL,0,72,0,MODE_SMA,PRICE_OPEN,1);

if( TotalOrdersCount()==0 )
{
     int result=0;
     if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)&&(MoyenneMobileFast>MoyenneMobileSlow)) // Here is your open buy rule
     {
        result=OrderSend(Symbol(),OP_BUY,Lots,Ask,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Blue);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Ask+TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Ask-StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);

        }
        return(0);
     }
     if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)&&(MoyenneMobileFast<MoyenneMobileSlow)) // Here is your open Sell rule
     {
        result=OrderSend(Symbol(),OP_SELL,Lots,Bid,Slippage,0,0,"EA Generator www.ForexEAdvisor.com",MagicNumber,0,Red);
        if(result>0)
        {
         TheStopLoss=0;
         TheTakeProfit=10;
         if(TakeProfit>0) TheTakeProfit=Bid-TakeProfit*MyPoint;
         if(StopLoss>0) TheStopLoss=Bid+StopLoss*MyPoint;
         OrderSelect(result,SELECT_BY_TICKET);
         OrderModify(OrderTicket(),OrderOpenPrice(),NormalizeDouble(TheStopLoss,Digits),NormalizeDouble(TheTakeProfit,Digits),0,Green);
         bougie=Bars;
        }
        return(0);
     }
}

for(int cnt=0;cnt<OrdersTotal();cnt++)
     {
      OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
      if(OrderType()<=OP_SELL &&
         OrderSymbol()==Symbol() &&
         OrderMagicNumber()==MagicNumber
         )
        {
         if(OrderType()==OP_BUY)
           {
              if((DerniereMoyenneMobileFast>DerniereMoyenneMobileSlow)
              &&(MoyenneMobileFast<MoyenneMobileSlow)) //here is your close buy rule
              {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
              }
            if(TrailingStop>0)
              {
               if(Bid-OrderOpenPrice()>MyPoint*TrailingStop)
                 {
                  if(OrderStopLoss()<Bid-MyPoint*TrailingStop)
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Bid-TrailingStop*MyPoint,OrderTakeProfit(),0,Green);
                     return(0);
                    }
                 }
              }
           }
         else    SINON
           {
                if((DerniereMoyenneMobileFast<DerniereMoyenneMobileSlow)
                  &&(MoyenneMobileFast>MoyenneMobileSlow)) // here is your close sell rule
                {
                   OrderClose(OrderTicket(),OrderLots(),OrderClosePrice(),Slippage,Red);
                }
            if(TrailingStop>0)
              {
               if((OrderOpenPrice()-Ask)>(MyPoint*TrailingStop))
                 {
                  if((OrderStopLoss()>(Ask+MyPoint*TrailingStop)) || (OrderStopLoss()==0))
                    {
                     OrderModify(OrderTicket(),OrderOpenPrice(),Ask+MyPoint*TrailingStop,OrderTakeProfit(),0,Red);
                     return(0);
                    }
                 }
              }
           }
        }
     }
   return(0);
}

int TotalOrdersCount()
{
int result=0;
for(int i=0;i<OrdersTotal();i++)
{
OrderSelect(i,SELECT_BY_POS ,MODE_TRADES);
if (OrderMagicNumber()==MagicNumber) result++;

}
return (result);
}

Why are you using old codes? You using start instead of OnTick function, by the way, after your last { outside of everything. Code should be like this

int OnInit()

void OnDeinit()

void OnTick()
 {
  if(isNewBar())
  {
   
   ... your start code here ...   

   }
 }

Your Code TotalOrdersCount
{
}

bool NewBar()
{
static datetime lastbar;
datetime curbar = Time[0];
if(lastbar!=curbar)
{
lastbar=curbar;
return (true);
}
else
{
return(false);
}
}