OrderClose is closing order OP_SELL above and OP_BUY bellow the OrderOpened ?

Fernando Paiva 2020.01.11 19:30

I'm trying to create a dynamic Take Profit programatically. To do this I am using OrderClose() to close the order when the difference of pips are ready. The problem is that it is closing above the OP_SELL and bellow OP_BUY and I don't know why it happens.

how could I fix this ?

See the image: https://imgur.com/B0LYbkC

void executeTakeProfit(int mn, double points){   
  double _diffPips = 0;
  
  
  if(OrdersTotal() > 0){
      RefreshRates();
  
      for(int x = 0; x < OrdersTotal(); x++){
         if(OrderSelect(x, SELECT_BY_POS, MODE_TRADES)){
            if(OrderMagicNumber() == mn && OrderSymbol() == Symbol()){
               
               
               if(OrderType() == OP_BUY){
                  if(Ask > OrderOpenPrice()){
                     _diffPips = NormalizeDouble((Ask - OrderOpenPrice()) / Point, Digits);
                     if(_diffPips >= points){
                        if(!OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrNONE)){
                           Comment("Error Take Profit - Buy");
                        }   
                     }
                  }
               }//buy
            
               if(OrderType() == OP_SELL){
                  if(Bid < OrderOpenPrice()){
                     _diffPips = NormalizeDouble((OrderOpenPrice() - Bid) / Point, Digits);                     
                     if(_diffPips >= points){
                        if(!OrderClose(OrderTicket(), OrderLots(), Ask, 0, clrNONE)){
                           Comment("Error Take Profit - Sell");
                        }               
                     }
                  }
               }//sell
               
               
               
            }//magic
            
            
            
         }//select
      }//for
      
      
      
   
  }
   
   
}//execute take profit

Imgur

2020.01.11
imgur.com

Post with 0 votes and 1 views.

William Roeder 2020.01.11 20:15 #1

Fernando Paiva: closing above the OP_SELL and bellow OP_BUY

if(Ask > OrderOpenPrice()){
⋮
                        if(!OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrNONE)){

If the Ask goes one tick above the open price, the Bid (close price) is below the open price (by the spread.)

You buy at the Ask and sell at the Bid. So for buy orders you pay the spread on open. For sell orders you pay the spread on close.

Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid reaches it. Not the Ask. Your SL is shorter by the spread and your TP is longer. Don't you want the same/specified amount for either direction?
Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask reaches it. To trigger at a specific Bid price, add the average spread.
MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25
The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (Control-O) → charts → Show ask line.)

Fernando Paiva 2020.01.11 20:37 #2

William Roeder:

If the Ask goes one tick above the open price, the Bid (close price) is below the open price (by the spread.)

Are you mean the problem is the spread ? what do you suggest in this case of my function ?

Kenneth Parling 2020.01.11 22:27 #3

Fernando Paiva:

Are you mean the problem is the spread ? what do you suggest in this case of my function ?

if(!OrderClose(OrderTicket(), OrderLots(), Bid, 0, clrNONE)){

//instead of using Bid in your case here try// 
OrderClosePrice()

In your case here Bid is used, try the other function i provided ;)

Fernando Paiva 2020.01.12 00:03 #4

Kenneth Parling:

In your case here Bid is used, try the other function i provided ;)

I've tried to change the function but it still closing above at OP_SELL and bellow at OP_BUY. Could you help me ?

Trying

void executeTakeProfit(int mn, double points){   
  double _diffPips = 0;
  
  
  if(OrdersTotal() > 0){      
  
      for(int x = 0; x < OrdersTotal(); x++){
         if(OrderSelect(x, SELECT_BY_POS, MODE_TRADES)){
            if(OrderMagicNumber() == mn && OrderSymbol() == Symbol()){
               
               
               if(OrderType() == OP_BUY){
                  _diffPips = NormalizeDouble((OrderClosePrice() - OrderOpenPrice()) / _Point, Digits);
                  if(_diffPips >= points){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Buy", GetLastError());
                     }
                  }                  
               }//buy
            
               if(OrderType() == OP_SELL){
                  _diffPips = NormalizeDouble((OrderClosePrice() - OrderOpenPrice()) / _Point, Digits);                  
                  if(_diffPips <= points){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Sell", GetLastError());
                     }
                  }
               }//sell
               
               
               
            }//magic
            
            
            
         }//select
      }//for
      
   
  }
   
   
}//execute take profit

Jefferson Judge Metha 2020.01.12 00:41 #5

Fernando Paiva:

I've tried to change the function but it still closing above at OP_SELL and bellow at OP_BUY. Could you help me ?

Trying

awkay now How On earth does an open order have a value for OrderClosePrice()

f(OrderType() == OP_BUY){
                  _diffPips = NormalizeDouble((OrderClosePrice() - OrderOpenPrice()) / _Point, Digits);
                  if(_diffPips >= points){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Buy", GetLastError());
                     }
                  }                  
               }//buy
            
               if(OrderType() == OP_SELL){
                  _diffPips = NormalizeDouble((OrderClosePrice() - OrderOpenPrice()) / _Point, Digits);                  
                  if(_diffPips <= points){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Sell", GetLastError());
                     }

ok So we want a virtual Take Profit. lets do this

Have Holder of the Pips you want for your take Profit

input int m_takeprofit = 40; //Take Profit in pips

then next we need to change that into the corrct Format

void executeTakeProfit(int mn, double points){   
  double _diffPips = 0;
  double takeprof;
  
  
  if(OrdersTotal() > 0){      
  
      for(int x = 0; x < OrdersTotal(); x++){
         if(OrderSelect(x, SELECT_BY_POS, MODE_TRADES)){
            if(OrderMagicNumber() == mn && OrderSymbol() == Symbol()){
               takeprof = m_takeprofit * 10 * SymbolInfoDouble(OrderSymbol(),SYMBOL_POINT);
               
               if(OrderType() == OP_BUY){
                  _diffPips = NormalizeDouble((SymbolInfoDouble(OrderSymbol(),SYMBOL_BID) - OrderOpenPrice()) , SymbolInfoInteger(OrderSymbol(),SYMBOL_DIGITS));
                  if(_diffPips >= takeprof ){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Buy", GetLastError());
                     }
                  }                  
               }//buy
            
               if(OrderType() == OP_SELL){
                  _diffPips = NormalizeDouble((OrderOpenPrice() - SymbolInfoDouble(OrderSymbol(),SYMBOL_ASK)) , SymbolInfoInteger(OrderSymbol(),SYMBOL_DIGITS));                  
                  if(_diffPips >= takeprof ){
                     RefreshRates();
                     if(!OrderClose(OrderTicket(), OrderLots(), OrderClosePrice(), 0, clrNONE)){
                        Comment("Take Profit Error - Sell", GetLastError());
                     }
                  }
               }//sell
               
               
               
            }//magic
            
            
            
         }//select
      }//for
      
   
  }
   
   
}//execute take profit

I am not sure if there errors but u get the Idea hey

Keith Watford 2020.01.12 01:00 #6

Jefferson Metha:

awkay now How On earth does an open order have a value for OrderClosePrice()

How does an open bar have a value for Close[0]? (rhetorical question)

It's the same sort of thing.

OrderClosePrice() is the last known value at the time that the order is selected, so for a buy, it will be the same as Bid and for a sell, the same as Ask.

Trailing Stop with Commission Testing BUY/SELL on close HELP about use of

Jefferson Judge Metha 2020.01.12 01:08 #7

Keith Watford:

OrderClosePrice() is the last known value at the time that the order is selected, so for a buy, it will be the same as Bid and for a sell, the same as Ask.

What, it doesn't make sense to me, but I understand the Close[0] example
I thought OrderclosePrice must be accessed by

if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)

I am having a BrainShutdown trying to process that. lemme go sleep its 3 am my time

Trend of interesting thoughts OrderCloseTime() writing incorrect time Any questions from newcomers

William Roeder 2020.01.12 13:25 #8

You can use OrderClosePrice() instead of Bid/Ask and be direction independent — no need to check order type for close price. But if you potentially close multiple orders, you must call RefreshRates after the server call and before the next OrderSelect.

automatic order closing Trailing Stop and reversing Bot Closes trades immediately

New comment