i need someone help me to update expert

 

i need someone help me to update privet expert i bought 4 years ago now when make test  


code 


  OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);

    if (OrderMagicNumber() == Magic && OrderSymbol()==Symbol())

    {

      if (OrderType()==OP_BUY)

      {

        if(OrderClose(OrderTicket(),OrderLots(),Bid,Slippage)==false)

         {

           RefreshRates();

         }

         else

         {

           cnt=0;

           total=OrdersTotal();

         }

      }

      

    }

  }

  return(0);

}  



 

These are just warnings. However they mean your EA was not well coded.

See Freelance section on top of the page.

 

 bool trade = OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);


	          
 
GrumpyDuckMan:

 bool trade = OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);

Not a good idea unless the bool trade's result is actually checked.

 
 if(OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES))
 

What Mladen recommended 

dummyResult=OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);

dont forget to add

bool dummyResult;