Experts: Simple Expert Advisor

[MetaQuotes]

Simple Expert Advisor:

Many people asks to post a simple expert advisor. Here is it.

Author: Vladimir Khlystov

[Brian Dee - Random Trader]

I think

void CLOSEORDER(string ord)
{
   for (int i=0; i<OrdersTotal(); i++)
   {                                               
      if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
      {
         if (OrderSymbol()!=Symbol()) continue;
         if (OrderType()==OP_BUY && ord=="Buy")
            OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);// Close Buy
         if (OrderType()==OP_SELL && ord=="Sell")
            OrderClose(OrderTicket(),OrderLots(),Ask,3,CLR_NONE);// Close Sell
      }   
   }
}

should be

void CLOSEORDER(string ord)
{
   for (int i=OrdersTotal()-1; i>=0; i--)
   {                                               
      if (OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==true)
      {
         if (OrderSymbol()!=Symbol()) continue;
         if (OrderType()==OP_BUY && ord=="Buy")
            OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);// Close Buy
         if (OrderType()==OP_SELL && ord=="Sell")
            OrderClose(OrderTicket(),OrderLots(),Ask,3,CLR_NONE);// Close Sell
      }   
   }
}

FWIW

-BB-

[Automated-Trading]

BarrowBoy:

Editor's remark:

You are right. Code corrected.

Thank you.

[William Roeder]

I think

if (LOT>MarketInfo(Symbol(),MODE_MAXLOT)) LOT = MarketInfo(Symbol(),MODE_MAXLOT);
if (LOT<MINLOT)                           LOT = MINLOT;
if (MINLOT<0.1) LOT = NormalizeDouble(LOT,2); else LOT = NormalizeDouble(LOT,1);

Should be

double	LotStep = MarketInfo( Symbol(), MODE_LOTSTEP );
LOT=MathFloor(	LOT / LotStep )*LotStep;
if (LOT>MarketInfo(Symbol(),MODE_MAXLOT)) LOT = MarketInfo(Symbol(),MODE_MAXLOT);
if (LOT<MINLOT)                           LOT = MINLOT;

[William Roeder]

Or simplier

void CLOSEORDER(string ord)
{
   for (int i=OrdersTotal()-1; i>=0; i--)  if (
      OrderSelect(i,SELECT_BY_POS,MODE_TRADES)
   && OrderMagicNumber() == MagicNumber		// with my magic number,
   && OrderSymbol()	 == Symbol() ) {	// in my chart.
         if (OrderType()==OP_BUY && ord=="Buy")
            OrderClose(OrderTicket(),OrderLots(),Bid,3,CLR_NONE);// Close Buy
         if (OrderType()==OP_SELL && ord=="Sell")
            OrderClose(OrderTicket(),OrderLots(),Ask,3,CLR_NONE);// Close Sell
   }
}

[[Deleted]]

Could you tell more what 's Timeframe (M1)(M5)(M15) (M30) with EUR/USD are the best for this File.

Best Reguard ?

[[Deleted]]

yeh but what time frames ?

[Vladimir Khlystov]

M30 and above

Ready MTS

http://translate.google.com/translate?hl=en&sl=ru&tl=en&u=http%3A%2F%2Fcmillion.narod.ru%2Frobot.html

[damianino]

Hello Vladimir , although imposed stop loss and take profit , when it takes a position I have to put them manually , how come ?

[Vladimir Khlystov]

damianino:

В параметрах советника есть возможность устанавливать стоплосс и тейкпрофит.

Я не понимаю, что у Вас не получилось.