Need help positions are getting closed prematurely

To add comments, please log in or register
joshualiu
9
joshualiu  

This is my first time trying to create an EA using MetaEditor. After manually entering a SL of 50 pips away and TP of 3 pips away from entry price, I found that the open positions are getting closed out before the SL was hit. Please refer to the attached screenshots. 

I was thinking that the EA was trying to enter a new position but closed out the open one instead.

Thanks in advance for helping out a newbie!

Files:
para3.jpg 260 kb
para4.jpg 309 kb
Mohamad Zulhairi Baba
13596
Mohamad Zulhairi Baba  
joshualiu:

This is my first time trying to create an EA using MetaEditor. 

Post your code if you need help.
joshualiu
9
joshualiu  

Appreciate the reply, the entire code is as follows:

//+------------------------------------------------------------------+

//|                                                         Para.mq5 |

//|                        Copyright 2018, MetaQuotes Software Corp. |

//|                                             https://www.mql5.com |

//+------------------------------------------------------------------+

#property copyright "Copyright 2018, MetaQuotes Software Corp."

#property link      "https://www.mql5.com"

#property version   "1.00"

//+------------------------------------------------------------------+

//| Include                                                          |

//+------------------------------------------------------------------+

#include <Expert\Expert.mqh>

//--- available signals

#include <Expert\Signal\SignalSAR.mqh>

//--- available trailing

#include <Expert\Trailing\TrailingNone.mqh>

//--- available money management

#include <Expert\Money\MoneyFixedLot.mqh>

//+------------------------------------------------------------------+

//| Inputs                                                           |

//+------------------------------------------------------------------+

//--- inputs for expert

input string Expert_Title         ="Para"; // Document name

ulong        Expert_MagicNumber   =30218;  // 

bool         Expert_EveryTick     =false;  // 

//--- inputs for main signal

input int    Signal_ThresholdOpen =10;     // Signal threshold value to open [0...100]

input int    Signal_ThresholdClose=10;     // Signal threshold value to close [0...100]

input double Signal_PriceLevel    =0.0;    // Price level to execute a deal

input double Signal_StopLevel     =50.0;   // Stop Loss level (in points)

input double Signal_TakeLevel     =3.0;   // Take Profit level (in points)

input int    Signal_Expiration    =4;      // Expiration of pending orders (in bars)

input double Signal_SAR_Step      =0.02;   // Parabolic SAR(0.02,0.2) Speed increment

input double Signal_SAR_Maximum   =0.2;    // Parabolic SAR(0.02,0.2) Maximum rate

input double Signal_SAR_Weight    =1.0;    // Parabolic SAR(0.02,0.2) Weight [0...1.0]

//--- inputs for money

input double Money_FixLot_Percent =10.0;   // Percent

input double Money_FixLot_Lots    =1.0;    // Fixed volume

//+------------------------------------------------------------------+

//| Global expert object                                             |

//+------------------------------------------------------------------+

CExpert ExtExpert;

//+------------------------------------------------------------------+

//| Initialization function of the expert                            |

//+------------------------------------------------------------------+

int OnInit()

  {

//--- Initializing expert

   if(!ExtExpert.Init(Symbol(),Period(),Expert_EveryTick,Expert_MagicNumber))

     {

      //--- failed

      printf(__FUNCTION__+": error initializing expert");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Creating signal

   CExpertSignal *signal=new CExpertSignal;

   if(signal==NULL)

     {

      //--- failed

      printf(__FUNCTION__+": error creating signal");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//---

   ExtExpert.InitSignal(signal);

   signal.ThresholdOpen(Signal_ThresholdOpen);

   signal.ThresholdClose(Signal_ThresholdClose);

   signal.PriceLevel(Signal_PriceLevel);

   signal.StopLevel(Signal_StopLevel);

   signal.TakeLevel(Signal_TakeLevel);

   signal.Expiration(Signal_Expiration);

//--- Creating filter CSignalSAR

   CSignalSAR *filter0=new CSignalSAR;

   if(filter0==NULL)

     {

      //--- failed

      printf(__FUNCTION__+": error creating filter0");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

   signal.AddFilter(filter0);

//--- Set filter parameters

   filter0.Step(Signal_SAR_Step);

   filter0.Maximum(Signal_SAR_Maximum);

   filter0.Weight(Signal_SAR_Weight);

//--- Creation of trailing object

   CTrailingNone *trailing=new CTrailingNone;

   if(trailing==NULL)

     {

      //--- failed

      printf(__FUNCTION__+": error creating trailing");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Add trailing to expert (will be deleted automatically))

   if(!ExtExpert.InitTrailing(trailing))

     {

      //--- failed

      printf(__FUNCTION__+": error initializing trailing");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Set trailing parameters

//--- Creation of money object

   CMoneyFixedLot *money=new CMoneyFixedLot;

   if(money==NULL)

     {

      //--- failed

      printf(__FUNCTION__+": error creating money");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Add money to expert (will be deleted automatically))

   if(!ExtExpert.InitMoney(money))

     {

      //--- failed

      printf(__FUNCTION__+": error initializing money");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Set money parameters

   money.Percent(Money_FixLot_Percent);

   money.Lots(Money_FixLot_Lots);

//--- Check all trading objects parameters

   if(!ExtExpert.ValidationSettings())

     {

      //--- failed

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- Tuning of all necessary indicators

   if(!ExtExpert.InitIndicators())

     {

      //--- failed

      printf(__FUNCTION__+": error initializing indicators");

      ExtExpert.Deinit();

      return(INIT_FAILED);

     }

//--- ok

   return(INIT_SUCCEEDED);

  }

//+------------------------------------------------------------------+

//| Deinitialization function of the expert                          |

//+------------------------------------------------------------------+

void OnDeinit(const int reason)

  {

   ExtExpert.Deinit();

  }

//+------------------------------------------------------------------+

//| "Tick" event handler function                                    |

//+------------------------------------------------------------------+

void OnTick()

  {

   ExtExpert.OnTick();

  }

//+------------------------------------------------------------------+

//| "Trade" event handler function                                   |

//+------------------------------------------------------------------+

void OnTrade()

  {

   ExtExpert.OnTrade();

  }

//+------------------------------------------------------------------+

//| "Timer" event handler function                                   |

//+------------------------------------------------------------------+

void OnTimer()

  {

   ExtExpert.OnTimer();

  }

//+------------------------------------------------------------------+

To add comments, please log in or register