Help - Problems with Multi Timeframe Multi Currency Bar Size Alerts

To add comments, please log in or register
xop32
152
xop32  

I have put together  a very simple indicator that creates alerts on bar size of the previous candle in different currencys and different timeframes


THE IDEA:

during the day I wanted to be alerted to large candle sizes across the 28 pairs I monitor

if the last closed candle high to low/ or low to high is

over --  500 / 750 / 1000 or 1500 points  -- a alert is created and also a custom sound file (.wav) played



the indicator seems to work ok, but there are a 2 problems I still have with this


1) I have hard coded in the checks for barsize

dPoint_Diff > 0.01000, dPoint_Diff > 0.01500 etc etc

which causes problems on the JPY pairs as they are 3 decemial points and not 5 decemial points I have hard coded in


2) just doing a simple if check on the TIMEFRAMES  that have been selected to monitor

if (AlertOnM1)

is not good as I have duplicate code in the if (AlertOnM1) ,if (AlertOnM5) ,if (AlertOnM15) ,if (AlertOnM30) etc etc  blocks

I no its not good to duplicate the code in the blocks over and over, but this does work, but is not ideal


NOTE: on the indicator I would only select 1 or 2 timeframes max to monitor at a time during normal trading hours

example, if I have the 1 min & 5 min  set only to monitor it would generate alerts when events like non farm payrolls occur or other big moves



CODE Attached

Files:
BarSizes.mq5 27 kb
xop32
152
xop32  

I think I have fixed the problem with the jpy pairs


I just changed to point check to whole numbers and did a check on 3 or 5 digits on the currency pair


// convert the 3 digit jpy pairs to a whole number 
if (getdig(symbols[z]) == 3) {dPoint_Diff *= 1000;}

//convert the 5 digit pairs to a whole number

if (getdig(symbols[z]) == 5) {dPoint_Diff *= 100000;}


if(dPoint_Diff > 1500)
{  // we have a 1500 point bar, now do stuff here }

revised code below

xop32
152
xop32  
//+------------------------------------------------------------------+
//|                                   test3-MTFAlertsNewBarSizes.mq5 |
//|                        Copyright 2018, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2016"
#property strict
#property indicator_chart_window
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
enum tip
  {
   BarSize,
   Other
  };
input tip TypeOfAlerts=BarSize;
input string Symbols="AUDCAD,AUDCHF,AUDJPY,AUDNZD,AUDUSD,CADCHF,CADJPY,CHFJPY,EURAUD,EURCAD,EURCHF,EURGBP,EURJPY,EURNZD,EURUSD,GBPAUD,GBPCAD,GBPCHF,GBPJPY,GBPNZD,GBPUSD,NZDCAD,NZDCHF,NZDJPY,NZDUSD,USDCAD,USDCHF,USDJPY";
input bool AlertOnM1=false;
input bool AlertOnM5=false;
input bool AlertOnM15=false;
input bool AlertOnM30=false;
input bool AlertOnH1=false;
//input bool AlertOnH4=false;
//input bool AlertOnD1=false;
//input bool AlertOnW1=false;
//input bool AlertOnMN1=false;
//+------------------------------------------------------------------+
//| 10/12/17 Added in extra alert sounds                             |
//+------------------------------------------------------------------+
input bool   EnableSoundAlerts  = true;
input string s500PointBarSoundFileName  = "500PointBar.wav";
input string s1000PointBarSoundFileName = "1000PointBar.wav";
input string s1500PointBarSoundFileName = "1500PointBar.wav";
//+------------------------------------------------------------------+
//| //END 10/12/17 Added in extra alert sounds                       |
//+------------------------------------------------------------------+

string symbols[];
string      sep=",";
ushort  u_sep=StringGetCharacter(sep,0);
int   symb_cnt=0;
bool newb[9]={false,false,false,false,false,false,false,false};
static datetime lastbar[9]={0,0,0,0,0,0,0,0};
bool enbalealert[9]={};
ENUM_TIMEFRAMES tfs[9]=
  {
   PERIOD_M1,
   PERIOD_M5,
   PERIOD_M15,
   PERIOD_M30,
   PERIOD_H1,
   PERIOD_H4,
   PERIOD_D1,
   PERIOD_W1,
   PERIOD_MN1,

  };

double tbprice=0;
datetime tbtime=0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int OnInit()
  {symb_cnt=StringSplit(Symbols,u_sep,symbols);

   for(int z=0;z<ArraySize(symbols);z++)
     
      
   enbalealert[0]=AlertOnM1;
   enbalealert[1]=AlertOnM5;
   enbalealert[2]=AlertOnM15;
   enbalealert[3]=AlertOnM30;
   enbalealert[4]=AlertOnH1;
   //enbalealert[5]=AlertOnH4;
   //enbalealert[6]=AlertOnD1;
   //enbalealert[7]=AlertOnW1;
   //enbalealert[8]=AlertOnMN1;

   lastbar[0]=0;
   lastbar[1]=0;
   lastbar[2]=0;
   lastbar[3]=0;
   lastbar[4]=0;
   lastbar[5]=0;
   lastbar[6]=0;
   lastbar[7]=0;
   lastbar[8]=0;
//--- indicator buffers mapping
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
   Comment("");
   EventKillTimer();
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {

 if(MQLInfoInteger(MQL_TESTER))
   Process();
//---

//--- return value of prev_calculated for next call
   return(rates_total);
  }
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
  {
 if(!MQLInfoInteger(MQL_TESTER))
   Process();
//---

  }
void Process()
{
 for(int s=0;s<9;s++)
     {
      if(NewBar(s) && enbalealert[s])
         for(int z=0;z<ArraySize(symbols);z++)
           {                        
            
            if (AlertOnM1) 
              {
              
            MqlRates rates[];
            ArraySetAsSeries(rates,true);
            // Get the open close hi and low of the last 2 bars into rates[] array
            CopyRates(symbols[z],PERIOD_M1,0,2,rates);
            
            // rates[i].open
            // rates[i].high
            // rates[i].low
            // rates[i].close
            // rates[i].tick_volume                       
   
            // Point Differance between bars
            static double dPoint_Diff;            
           
            
            // Current Barsize is greater than last Barsize - GOING UP
            if(rates[1].high > rates[1].low)   
            {
         
                  // Differance in points between the high and low of last bar     
                  dPoint_Diff   = rates[1].high - rates[1].low;
                  
                  // convert the 3 digit jpy pairs to a whole number 
                  if (getdig(symbols[z]) == 3) {dPoint_Diff *= 1000;}
                  //convert the 5 digit pairs to a whole number
                  if (getdig(symbols[z]) == 5) {dPoint_Diff *= 100000;}
         
                  if(dPoint_Diff > 1500)
                  {
         
                   //Alert_(symbols[z]+" p-"+getdig(symbols[z])+" h-"+rates[1].high+" l-"+rates[1].low+"<<< 1500 buyxxx alert happend here on: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   Alert_(symbols[z]+" <<< 1500 buy alert happend here on: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s1500PointBarSoundFileName);          
         
                  }         
                  else if(dPoint_Diff > 1000)
                  {
         
                   Alert_(symbols[z]+" << 1000 buy alert happend here on: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }         
                  else if(dPoint_Diff > 750)
                  {
         
                   Alert_(symbols[z]+" < 750 buy alert happend here on: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  } 
                  else if(dPoint_Diff > 500)
                  {
         
                   Alert_(symbols[z]+" b500 buy alert happend here on: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  } 
                  else
                  {
         
                   //Alert_(DoubleToString(dPoint_Diff,getdig(_Symbol))+" e-buy alert happend here on: Diff = "+DoubleToString(dPoint_Diff,getdig(_Symbol)));
                   //if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }      
         
                
            }
   

            // Current Barsize is less than last Barsize - GOING DOWN
            else if(rates[1].low < rates[1].high)
            {
         
                  // Differance in points between the high and low of last bar     
                  dPoint_Diff   = rates[1].low - rates[1].high;
                  
                  // convert the 3 digit jpy pairs to a whole number 
                  if (getdig(symbols[z]) == 3) {dPoint_Diff *= 1000;}
                  //convert the 5 digit pairs to a whole number
                  if (getdig(symbols[z]) == 5) {dPoint_Diff *= 100000;}
         
                  if(dPoint_Diff > 1500)
                  {
         
                   Alert_(symbols[z]+" >>> 1500 DOWN point bar size: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s1500PointBarSoundFileName);
         
                  }         
                  else if(dPoint_Diff > 1000)
                  {
         
                   Alert_(symbols[z]+" >> 1000 DOWN point bar size: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }         
                  else if(dPoint_Diff > 750)
                  {
         
                   Alert_(symbols[z]+" > 750 DOWN point bar size: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }
                  else if(dPoint_Diff > 500)
                  {
         
                   Alert_(symbols[z]+" 500 DOWN point bar size: Diff =  "+DoubleToString(dPoint_Diff,getdig(symbols[z])));
                   if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }
                  else
                  {
         
                   //Alert_(DoubleToString(dPoint_Diff,getdig(_Symbol))+" e-sell alert happend here on: Diff = "+DoubleToString(dPoint_Diff,getdig(_Symbol)));
                   //if (EnableSoundAlerts) PlaySound(s500PointBarSoundFileName);
         
                  }                          
                        
        
            } 
              
              }
             
          
            
           }
     }
}  
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
bool NewBar(int z)
  {
   datetime curbar=iTime(NULL,tfs[z],0);
   if(lastbar[z]!=curbar)
     {
      lastbar[z]=curbar;
      return (true);
     }
   else return(false);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
string  StringTf(ENUM_TIMEFRAMES tf)
  {
   if(tf==PERIOD_M1)return("M1");
   if(tf==PERIOD_M5)return("M5");
   if(tf==PERIOD_M15)return("M15");
   if(tf==PERIOD_M30)return("M30");
   if(tf==PERIOD_H1)return("H1");
   if(tf==PERIOD_H4)return("H4");
   if(tf==PERIOD_D1)return("D1");
   if(tf==PERIOD_W1)return("W1");
   if(tf==PERIOD_MN1)return("MN1");


   return("");
  }

//+--
int getdig(string symb)
  {
   return(int(SymbolInfoInteger(symb,SYMBOL_DIGITS)));
  }
//+------------------------------------------------------------------+
//+------------------------------------------------------------------+
datetime expiredate=0;
string txtname="DTS"+".txt";

//+------------------------------------------------------------------+
void Alert_(string text)
  {
   Alert(text);
   SendNotification(text);
   SendMail(MQLInfoString(MQL_PROGRAM_NAME),text);
  }
//+------------------------------------------------------------------+
datetime iTime(string symb,ENUM_TIMEFRAMES timeframe,int nShift)
  {
   datetime timeseries[1];
   if(CopyTime(symb,timeframe,nShift,1,timeseries)==1) return(timeseries[0]);
   else return(-1.0);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
ENUM_TIMEFRAMES TFMigrate(int tf)
  {
   switch(tf)
     {
      case 0: return(PERIOD_CURRENT);
      case 1: return(PERIOD_M1);
      case 5: return(PERIOD_M5);
      case 15: return(PERIOD_M15);
      case 30: return(PERIOD_M30);
      case 60: return(PERIOD_H1);
      case 240: return(PERIOD_H4);
      case 1440: return(PERIOD_D1);
      case 10080: return(PERIOD_W1);
      case 43200: return(PERIOD_MN1);

      case 2: return(PERIOD_M2);
      case 3: return(PERIOD_M3);
      case 4: return(PERIOD_M4);
      case 6: return(PERIOD_M6);
      case 10: return(PERIOD_M10);
      case 12: return(PERIOD_M12);
      case 16385: return(PERIOD_H1);
      case 16386: return(PERIOD_H2);
      case 16387: return(PERIOD_H3);
      case 16388: return(PERIOD_H4);
      case 16390: return(PERIOD_H6);
      case 16392: return(PERIOD_H8);
      case 16396: return(PERIOD_H12);
      case 16408: return(PERIOD_D1);
      case 32769: return(PERIOD_W1);
      case 49153: return(PERIOD_MN1);
      default: return(PERIOD_CURRENT);
     }
  }
//+------------------------------------------------------------------+
xop32
152
xop32  

I have duplicate code blocks for


if (AlertOnM1)

if (AlertOnM5)

if (AlertOnM15)

if (AlertOnM30)

if (AlertOnH1)


but I have removed the from the above code as the character limit was excceded


putting duplicate code blocks in for the checks if 1,5,15,30 minute alerts are enabled does not seem like a good idea


does anyone have a idea which would be the best way to check for which alerts timeframes are enabled, and run threw a single block of code??    

nicholi shen
2391
nicholi shen  
xop32:

I have duplicate code blocks for


if (AlertOnM1)

if (AlertOnM5)

if (AlertOnM15)

if (AlertOnM30)

if (AlertOnH1)


but I have removed the from the above code as the character limit was excceded


putting duplicate code blocks in for the checks if 1,5,15,30 minute alerts are enabled does not seem like a good idea


does anyone have a idea which would be the best way to check for which alerts timeframes are enabled, and run threw a single block of code??    

Couple of tips...


This will never resolve to true

rates[1].low < rates[1].high


You can greatly simplify your code by using objects. You can create a unique object for each alert.


//+------------------------------------------------------------------+
//|                                                BarSizeAlerts.mq4 |
//|                                      Copyright 2018, nicholishen |
//|                                          http://forexfactory.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2018, nicholishen"
#property link      "http://forexfactory.com"
#property version   "1.00"
#property strict
#property indicator_chart_window

input string InpCurrencies = "AUD,CAD,CHF,JPY,NZD,USD,EUR,GBP";
input string InpTimeframes = "M1,M5,M15,H1";
input string InpPointValues= "50,100,500,1000,1500";
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
#include <Tools\DateTime.mqh>
#include <Arrays\ArrayObj.mqh>
#include <Arrays\ArrayInt.mqh>
#include <Arrays\ArrayString.mqh>

class BarAlert : public CObject
{
protected:
   string            m_symbol;
   ENUM_TIMEFRAMES   m_timeframe;
   uint              m_alert_points;
   datetime          m_last_alert;
   MqlRates          m_rates[];
   double            m_point;
   string            m_sound;
public:
   BarAlert(const string symbol,const ENUM_TIMEFRAMES timeframe, const uint alert_points, string sound = NULL)
   {
      SymbolSelect(symbol,true);
      m_symbol       = symbol;
      m_timeframe    = timeframe;
      m_alert_points = alert_points;
      m_sound        = sound;
      m_point        = SymbolInfoDouble(m_symbol,SYMBOL_POINT);
      ArraySetAsSeries(m_rates,true);
   }
   void Refresh()
   {
      if(CopyRates(m_symbol,m_timeframe,0,1,m_rates) < 1)  
      {
         printf("CopyRates error %d",_LastError);
         return;
      }
      if(HasAlerted())
         return;
      double delta = m_rates[0].high - m_rates[0].low;
      if(delta >= (double)m_alert_points * m_point)
      {
         if(m_sound != NULL)
            PlaySound(m_sound);
         string alert_text = StringFormat("%s: %d point bar size on %s",m_symbol,int(delta/m_point),EnumToString(m_timeframe));
         _Alert(alert_text);
         m_last_alert = m_rates[0].time;
      }
   }
   bool HasAlerted()
   {
      return ArraySize(m_rates)<1? false : m_rates[0].time == m_last_alert;
   }
protected:  
   void _Alert(string text)
   {
      Alert(text);
      //SendNotification(text);
      SendMail(MQLInfoString(MQL_PROGRAM_NAME),text);
   }
};

class AlertManager
{
protected:
   CArrayObj      m_alerts;
public:
   bool OnInit(string currencies, string timeframes,string point_vals)
   {
      string c[],t[],p[];
      ENUM_TIMEFRAMES all_timeframes[] = {PERIOD_M1,PERIOD_M5,PERIOD_M15,PERIOD_M30,PERIOD_H1,PERIOD_H4,PERIOD_D1};
      int total_currencies = StringSplit(currencies,',',c);
      int total_timeframes = StringSplit(timeframes,',',t);
      int total_point_vals = StringSplit(point_vals,',',p);
      CArrayInt timeframes_to_use;
      for(int i=0;i<total_timeframes;i++)
         for(int j=0;j<ArraySize(all_timeframes);j++)
            if(StringFind(EnumToString(all_timeframes[j]),t[i]) >= 0)
               if(timeframes_to_use.Add((int)all_timeframes[j]))
                  break;
      CArrayString symbols_to_use;
      for(int i=0;i<total_currencies;i++)
         for(int j=0;j<total_currencies;j++)
         {
            if(j==i)
               continue;
            string test_pair = c[i]+c[j];
            for(int k=0;k<SymbolsTotal(false);k++)
               if(StringFind(SymbolName(k,false),test_pair) >=0)
                  if(symbols_to_use.Add(SymbolName(k,false)))
                     break;
         }
      for(int i=0;i<symbols_to_use.Total();i++)
         for(int j=0;j<timeframes_to_use.Total();j++)
            for(int k=0;k<total_point_vals;k++)
            {
               BarAlert *alerter = new BarAlert(symbols_to_use[i],(ENUM_TIMEFRAMES)timeframes_to_use[j],(int)p[k]);
               m_alerts.Add(alerter);
            }
      return true;
   }
   void Refresh()
   {
      for(int i=m_alerts.Total()-1;i>=0;i--)
         ((BarAlert*)m_alerts.At(i)).Refresh();
   }
};

AlertManager g_manager;
int OnInit()
  {
//--- indicator buffers mapping
   if(!g_manager.OnInit(InpCurrencies,InpTimeframes,InpPointValues))
      return INIT_FAILED;
   EventSetTimer(1);
//---
   return(INIT_SUCCEEDED);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {
   return(rates_total);
  }
//+------------------------------------------------------------------+
//| Timer function                                                   |
//+------------------------------------------------------------------+
void OnTimer()
{
   g_manager.Refresh();   
}
//+------------------------------------------------------------------+
xop32
152
xop32  

thanks for the help nicholishen


I will study your code and test it out when the markets open again on tuesday


your code looks a lot cleaner than my attempt at it 

To add comments, please log in or register