Need some help editing an Indicator

New comment
 

Beofre I put this over to the market I've attached an Indicator that I can't seem to relocate in the market place (it was freely available).

I've attempted and unsuccesfully failed at editing this Indicator to work for the following currencies;

Horizontal Line: AUD USD JPY GBP CAD CHF NZD EUR SGD

and the Vertical Line: AUD USD JPY GBP CAD CHF NZD EUR SGD

If anyone wants to have a look and see if they can figure out where I'm failing by all means :) Would appreciate the help.

 
  1. Switch to the new style OnCalculate. Drop IndicatorCounted.
  2. Make sure you have history loaded for other pairs. Download history in MQL4 EA - MQL4 and MetaTrader 4 - MQL4 programming forum
  3.    if(iClose("EURUSD",0,HistoryShift)>iOpen("EURUSD",0,HistoryShift))
    Do not assume that shift of the current chart equals shift of other charts. Use iBarShift
  4.       EURLong++;
    You're doing this every tick and never use the values.
  5. Your code
    		Simplified 
      color  Color[4];

   Color[0]= DeepSkyBlue;  // Object color ..
   Color[1]= LightPink;    // .. for different situations
   Color[2]= Yellow;
   Color[3]= Yellow;
    color  Color[]={DeepSkyBlue, LightPink, Yellow, Yellow};
New comment
Reason: