Calculate Daily profit

8tango 2017.02.09 15:27

Hello,

I would like to calculate the daily profit of one of my EA, my code is:

double DailyProfit()
{
double profit = 0;
int i,hstTotal=OrdersHistoryTotal();
  for(i=0;i<hstTotal;i++)
    {
     if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==TRUE)
       {
         if(TimeToStr(TimeCurrent(),TIME_DATE) == TimeToStr(OrderCloseTime(),TIME_DATE))
         {
            profit += OrderProfit() + OrderSwap() + OrderCommission();
         }
       }
    }
   return(profit);
}

But this code return the equity of my account, what is wrong into my code?

Thank you for your help.

honest_knave 2017.02.09 15:32 #1

double DailyProfit()
{
double profit = 0;
int i,hstTotal=OrdersHistoryTotal();
  for(i=0;i<hstTotal;i++)
    {
     if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==TRUE)
       {
         if(OrderType()>1) continue;
         if(TimeToStr(TimeCurrent(),TIME_DATE) == TimeToStr(OrderCloseTime(),TIME_DATE))
         {
            profit += OrderProfit() + OrderSwap() + OrderCommission();
         }
       }
    }
   return(profit);
}

William Roeder 2017.02.09 16:12 #2

if(OrderType()>1) continue;	Deleted orders have zero OrderCloseTime, and wouldn't be selected. But there are other entries in history deposits/withdrawals and adjustments (6/7)

8tango 2017.02.09 16:19 #3

Thank you very much it work fine.

Slamet Santoso 2018.09.19 05:21 #4

honest_knave:

Mehmet Bastem 2018.09.19 10:15 #5

8tango:

Hello,

I would like to calculate the daily profit of one of my EA, my code is:

But this code return the equity of my account, what is wrong into my code?

Thank you for your help.

//+------------------------------------------------------------------+
//|                                                  ProfitDaily.mq4 |
//|                        Copyright 2015, MetaQuotes Software Corp. |
//|                                             https://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Copyright 2015, MetaQuotes Software Corp."
#property link      "https://www.mql5.com"
#property version   "1.00"
#property strict
//+------------------------------------------------------------------+
//| Script program start function                                    |
//+------------------------------------------------------------------+
void OnStart()
  {
//---
   DailyProfit();
  }
//+------------------------------------------------------------------+
double DailyProfit()
{
double profit = 0;
int i,hstTotal=OrdersHistoryTotal();
  for(i=0;i<hstTotal;i++)
    {
     if(OrderSelect(i,SELECT_BY_POS,MODE_HISTORY)==TRUE)
       {
         if(TimeToStr(TimeLocal(),TIME_DATE) == TimeToStr(OrderCloseTime(),TIME_DATE))
         {
            profit += OrderProfit() + OrderSwap() + OrderCommission();
         }
       }
    }
    Alert(profit);
   return(profit);
}

New comment