How can I calculate Profit in Currency? - MQL4 and MetaTrader 4

honest_knave 2017.02.02 11:33 #301

Max Enrik:

if(id==CHARTEVENT_OBJECT_CLICK && (StringFind(sparam,Button_1,0)>=0 || StringFind(sparam,Button_2,0)>=0))
{
ticketnumber=(int) StringSubstr(sparam,1);

Print(ticketnumber);

Print your ticket number - make sure it looks correct.

-----

Max Enrik:

if(id==CHARTEVENT_OBJECT_CLICK && (StringFind(sparam,Button_1,0)>=0 || StringFind(sparam,Button_2,0)>=0))
  {
   ticketnumber=(int) StringSubstr(sparam,1);

   if(OrderSelect(ticketnumber,SELECT_BY_TICKET))
     {
      if(StringFind(sparam,Button_1,0)>=0)
        {
         // ...
        }

      if(StringFind(sparam,Button_2,0)>=0)
        {
         //...
        }

      for(i=OrdersTotal()-1; i>=0; i--)
        {
         if(!OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) continue;
         if(Symbol()!=OrderSymbol()) continue;

         update_1();
         update_2();
         update_3();
        }
     }
else printf("OrderSelect failed for %i",ticketnumber);

}

Check the OrderSelect is working.

-----

Max Enrik:

if(id==CHARTEVENT_OBJECT_CLICK && (StringFind(sparam,Button_1,0)>=0 || StringFind(sparam,Button_2,0)>=0))
  {
   ticketnumber=(int) StringSubstr(sparam,1);

   if(OrderSelect(ticketnumber,SELECT_BY_TICKET))
     {
      if(StringFind(sparam,Button_1,0)>=0)
        {
         // ...
        }

      if(StringFind(sparam,Button_2,0)>=0)
        {
         //...
        }

      for(i=OrdersTotal()-1; i>=0; i--)
        {
         if(!OrderSelect(i,SELECT_BY_POS,MODE_TRADES)) continue;
         if(Symbol()!=OrderSymbol()) continue;

         update_1();
         update_2();
         update_3();
        }
     }
  }

I don't understand this.

You know this goes through every order with the same Symbol and runs update_1() update_2() update_3()? Not just the order you found with ticketnumber.

Function Ticket[n] Help for my First Missing something obvious/

Max Enrik 2017.02.02 12:38 #302

honest_knave:

Print your ticket number - make sure it looks correct.
-----
Check the OrderSelect is working.
-----
I don't understand this.
You know this goes through every order with the same Symbol and runs update_1() update_2() update_3()? Not just the order you found with ticketnumber.

Thanks for your prompt comment.
After your comment, I checked once again. It looks good.

#1 - Ticket number - correct.
#2 - OrderSelect() works.
#3 - Yeah! you right, but if I do not use it that update_*()'s won't works.

I use that method for Drags, that method works good. But that method does not works good for CHARTEVENT_OBJECT_CLICK. ( it does work good while single order, when I open opposite order it does works. )

I really need help, please.

MMA_Breakout_strategy_volume I (without MM Handling partial closes of Using OrderSelect() to find

honest_knave 2017.02.02 12:42 #303

Show me a screenshot of what you want to happen. I'm not clear on the problem.

Max Enrik 2017.02.02 12:44 #304

honest_knave:
Show me a screenshot of what you want to happen. I'm not clear on the problem.

While I was making screenshot I found solution, just wow! ( I already spent over 2 hours for it )
So, it looks like good so far, if something will go to wrong about that I will write more clearly comment.

Thanks for your time.

( That was really magical. )

Data input window in OneDailyTrade EA Fractal strategy/ Help

honest_knave 2017.02.02 13:04 #305

Max Enrik:

While I was making screenshot I found solution, just wow! ( I already spent over 2 hours for it )
So, it looks like good so far, if something will go to wrong about that I will write more clearly comment.

Thanks for your time.

( That was really magical. )

I'm glad you got it fixed

Max Enrik 2017.02.03 16:41 #306

#Profit Currency Calculate - Open

I just started to find solution that how can I calculate Profit in Currency. e.g: 100 pip = 0.89 USD in USDJPY

Q: How can I convert Order Profit in pips to Order Profit in Currency, please?

( I just worry about I can't find solution till market close )

Any clearly comment would be better, please.

Thanks in advance.

//--- 2nd times edited

I found a lot of similar forums, but I can't find this type of topics.

Regrading mismatch in profit MT5 a step backwards?? [ARCHIVE!] Any rookie question,

Marco vd Heijden 2017.02.03 20:19 #307

How do you get to profit in pips?

OrderProfit()

Returned value:

The net profit value (without swaps or commissions) for the selected order.

For open orders, it is the current unrealized profit.

For closed orders, it is the fixed profit.

Max Enrik 2017.02.04 22:55 #308

Marco vd Heijden:

How do you get to profit in pips?

OrderProfit()

Returned value:

The net profit value (without swaps or commissions) for the selected order.

For open orders, it is the current unrealized profit.

For closed orders, it is the fixed profit.

Thanks for your comment.

Sorry Marco, I did not describe my issue more clearly.
I can easily get value Order Profit in Pips and Currency - with below codes.

DoubleToString( OrderProfit(), 2 )
DoubleToString( change_to_points( Bid - OrderOpenPrice() ), 0 );

But I try to find solution for Stop Loss and Take Profit in Currency.

I am working on it, and I still need help, please.

Thanks in advance.

OrderOpenPrice returns 0 Indicator Miscellaneous Questions How to put a

William Roeder 2017.02.05 01:01 #309

Max Enrik: ut I try to find solution for Stop Loss and Take Profit in Currency.	Substitute OrderStopLoss for one of those. You place the stop where it needs to be - where the reason for the trade is no longer valid. E.g. trading a support bounce the stop goes below the support. Account Balance * percent/100 = RISK = OrderLots * (\|OrderOpenPrice - OrderStopLoss\| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the SPREAD, and DeltaPerLot is usually around $10/pip but it takes account of the exchange rates of the pair vs. your account currency.) Do NOT use TickValue by itself - DeltaPerLot You must normalize lots properly and check against min and max. You must also check FreeMargin to avoid stop out

Max Enrik: ut I try to find solution for Stop Loss and Take Profit in Currency.

Substitute OrderStopLoss for one of those.

You place the stop where it needs to be - where the reason for the trade is no longer valid. E.g. trading a support bounce the stop goes below the support.
Account Balance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the SPREAD, and DeltaPerLot is usually around $10/pip but it takes account of the exchange rates of the pair vs. your account currency.)
Do NOT use TickValue by itself - DeltaPerLot
You must normalize lots properly and check against min and max.
You must also check FreeMargin to avoid stop out

How to check StopLoss parameter or method for Calculating a trade lotsize

Max Enrik 2017.02.05 09:42 #310

whroeder1:

	Substitute OrderStopLoss for one of those. You place the stop where it needs to be - where the reason for the trade is no longer valid. E.g. trading a support bounce the stop goes below the support. Account Balance * percent/100 = RISK = OrderLots * (\|OrderOpenPrice - OrderStopLoss\| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the SPREAD, and DeltaPerLot is usually around $10/pip but it takes account of the exchange rates of the pair vs. your account currency.) Do NOT use TickValue by itself - DeltaPerLot You must normalize lots properly and check against min and max. You must also check FreeMargin to avoid stop out

Substitute OrderStopLoss for one of those.

You place the stop where it needs to be - where the reason for the trade is no longer valid. E.g. trading a support bounce the stop goes below the support.
Account Balance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the SPREAD, and DeltaPerLot is usually around $10/pip but it takes account of the exchange rates of the pair vs. your account currency.)
Do NOT use TickValue by itself - DeltaPerLot
You must normalize lots properly and check against min and max.
You must also check FreeMargin to avoid stop out

Thanks for your more informative comment.
I am studying it...

//--- 2nd time edited

Maybe lack of code knowledge does not gives me permission to understand your calculation method.
But I think I close to solution. And I try below code that I get ( for Buy Order ) Stop Loss in Currency.
Then I get this results ( I know I passed something... because I can't imply them... ) e.g: Profits: 7.67 USD - Pips: 1001 / for USDCAD. But actually Profit: 7.69 USD. ( I already checked out ( Swap and Commission ) )

double  tickvalue               = MarketInfo( Symbol(), MODE_TICKVALUE ) / MarketInfo( Symbol(), MODE_TICKSIZE ),
        buy_stoploss_incurrency = OrderOpenPrice() - OrderStopLoss();
string  stoploss_incurrency     = DoubleToString( OrderLots() * buy_stoploss_incurrency * tickvalue + OrderCommission(), 2 );

Print( "stop loss in currency: ", stoploss_incurrency );

So, I need advice, please.

Thanks in advance.

//--- 3rd time edited

Please coder or programmer let me know above code is right? Because now I see correct Stop Loss in currency for GBPCHF, but not correct for USDCAD. I do not figure out what is wrong?! ( note: USDCAD open position, but GBPCHF is Pending orders. )

Everything is OK for now. So, thanks a lot Mr. William.

Indicator Miscellaneous Questions Useful features from KimIV help needed with too

expert advisor - miscellaneous questions - page 31