Invalid price on multiple paris

[hsharghi]

Hi,

 My expert works fine when I use it on one pair. I mean drag the expert on the chart and let it execute. But when I use an array of pairs to open position on multiple pairs, It doesn't work. It seems still tries to open position on some other pair. It returns error 129 (Invalid price)

static string pairs[]={"GBPUSD","EURUSD","EURGBP","AUDUSD"};//, "EURJPY"};

   if((OrdersTotal()==0) && (OKToTrade))
     {
      initialBalance=AccountBalance();
      OKToTrade=false;

      for(int p=0; p<ArraySize(pairs); p++)
        {
           string currentSymbol=pairs[p];  // when use this line of code and try to open positions on multiple pairs, doesn't work
 //        string currentSymbol=_Symbol;   // when use this line of code and run it on any chart it works.
         double point=MarketInfo(currentSymbol,MODE_POINT);//Request for Point
         int digits=MarketInfo(currentSymbol,MODE_DIGITS);
         int cTP=(digits==5 || digits==3 ? 10 : 1);

         for(int i=1; i<=MaxOpenPositions; i++)
           {
            double spread=MarketInfo(currentSymbol,MODE_SPREAD);//Request for Spread
            double bid=MarketInfo(currentSymbol,MODE_BID); // Request for the value of Bid
            double ask=MarketInfo(currentSymbol,MODE_ASK); // Request for the value of Ask
            int tp=i*TakeProfit*cTP;
            double buyPrice=ask;
            double sellPrice=bid+spread*point;
 //         int buyRes  = OrderSend(currentSymbol,OP_BUY,LotSize,NormalizeDouble(buyPrice,digits),30,0,NormalizeDouble(buyPrice+tp*point, digits),buyComment,44444);
 //         int sellRes = OrderSend(currentSymbol,OP_SELL,LotSize,NormalizeDouble(sellPrice,digits),30,0,NormalizeDouble(sellPrice-tp*point-spread*point, digits),sellComment,44444);
            buyComment  = "Buy \nLot: " + LotSize + "\nPrice: " + NormalizeDouble(buyPrice,digits) + "\nTP: " + NormalizeDouble(buyPrice+tp*point, digits);
            sellComment = "Sell \nLot: " + LotSize + "\nPrice: " + NormalizeDouble(sellPrice,digits) + "\nTP: " + NormalizeDouble(sellPrice-tp*point-spread*point, digits);

            OrderSendReliable(currentSymbol,OP_BUY,LotSize,NormalizeDouble(buyPrice,digits),3,0,NormalizeDouble(buyPrice+tp*point,digits),buyComment,44444);
            OrderSendReliable(currentSymbol,OP_SELL,LotSize,NormalizeDouble(sellPrice,digits),3,0,NormalizeDouble(sellPrice-tp*point-spread*point,digits),sellComment,44444);
           }
        }
     }

  

I tried OrderSend() and OrderReliable helper class. Both fail at opening positions on multiple pairs.

[William Roeder]

double buyPrice=ask;  // Ask is one of the predefined variables

1. • Do not trade multiple currencies, you can't use any predefined variables, can't use the tester, must poll (not OnTick,) and usually other problems.
   • Code it to trade the chart pair only. Look at the others if you must.
   • Then put it on other charts to trade the other pairs. Done.

   ---

2. Do NOT use NormalizeDouble, EVER. For ANY Reason. It's a kludge, don't use it. It's use is always wrong

   • SL/TP (stops) need to be normalized to tick size (not Point.) (On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 forum) and abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 forum
   • Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on Metals. So do it right: Trailing Bar Entry EA - MQL4 forum or Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 forum
   • Lot size must also be adjusted to a multiple of LotStep. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.