b600+, Web-csv-Files, ANSI, UNICODE - ???
GrabWeb not working on MT4 Build 600 ( 1 2 3 )
//+------------------------------------------------------------------+ //| GRABWEB.mq4 | //| Copyright © 2014, Tjipke de Vries | //| https://forum.mql4.com/60608/page2#906517 WDholic | //+------------------------------------------------------------------+ #property copyright "Copyright © 2014, Tjipke de Vries" #property link "" #property version "1.00" #property strict #import "Wininet.dll" int InternetOpenW(string, int, string, string, int); int InternetConnectW(int, string, int, string, string, int, int, int); int HttpOpenRequestW(int, string, string, int, string, int, string, int); int InternetOpenUrlW(int, string, string, int, int, int); int InternetReadFile(int, string, int, int& OneInt[]); int InternetCloseHandle(int); #import //+------------------------------------------------------------------+ //| Script program start function | //+------------------------------------------------------------------+ void OnStart() { //--- string URL="http://calendar.forex-tsd.com/calendar.php?csv=1&date=20140214&calendar[]=4&gmt=0"; int HttpOpen = InternetOpenW(" ", 0, " "," ",0 ); int HttpConnect = InternetConnectW(HttpOpen, "", 80, "", "", 3, 0, 1); int HttpRequest = InternetOpenUrlW(HttpOpen,URL, NULL, 0, 0, 0); int read[1]; int end; string Buffer = " "; string NEWS = ""; string fileName = "DailyFX-News.csv"; string xmlFileName = fileName; int xmlHandle=FileOpen(xmlFileName, FILE_READ); //File exists if FileOpen return >=0. if (xmlHandle >= 0) {FileClose(xmlHandle); FileDelete(xmlFileName);} xmlHandle=FileOpen(xmlFileName, FILE_CSV|FILE_WRITE, ';'); while (true) { InternetReadFile(HttpRequest, Buffer, StringLen(Buffer), read); if (read[0] > 0) NEWS = NEWS + StringSubstr(Buffer, 0, read[0]); else { FileWriteString(xmlHandle, NEWS); FileClose(xmlHandle); break; } } if (HttpRequest > 0) InternetCloseHandle(HttpRequest); if (HttpConnect > 0) InternetCloseHandle(HttpConnect); if (HttpOpen > 0) InternetCloseHandle(HttpOpen); MessageBox(NEWS, "HTTP READ:" ); } //+------------------------------------------------------------------+
@ Gooly Don't make your posting so wide
Thank you - but as I wanted to test your solution I started b600 /portable it updates to b610 and and can't compile any more:
2014.02.16 01:01:06.754 Compiler cannot create interface 2014.02.16 01:01:00.703 Compiler invalid version of MQL engine - 0 instead of 887 2014.02.16 01:01:00.703 Compiler invalid MQL5 compiler engine version 883 instead of 887
sigh.
May be tomorrow when I get up I see it was just a nightmare.
I don't want to be picky, but your code is reading the HTTP response one byte at a time, and would start becoming very slow for large amounts of data. (It also relies on an Ansi->Unicode conversion which would not work properly if the server's response were something like UTF8, and relies on a particular layout of strings and other data in MT4's memory. If Buffer is held in memory exactly adjacent to other data then you could sometimes get random garbage appended into the string.)
The code at https://www.mql5.com/en/code/1998 (mentioned in GrabWeb not working on MT4 Build 600) uses the much more efficient technique of using InternetReadFile to read into a uchar[] buffer, and then doing conversion on the buffer.
A best way could be using
URLDownloadToFileW
I don't want to be picky, but your code is reading the HTTP response one byte at a time, and would start becoming very slow for large amounts of data. (It also relies on an Ansi->Unicode conversion which would not work properly if the server's response were something like UTF8, and relies on a particular layout of strings and other data in MT4's memory. If Buffer is held in memory exactly adjacent to other data then you could sometimes get random garbage appended into the string.)
The code at https://www.mql5.com/en/code/1998 (mentioned in GrabWeb not working on MT4 Build 600) uses the much more efficient technique of using InternetReadFile to read into a uchar[] buffer, and then doing conversion on the buffer.
I was using a buffer with 255 bytes ( and got the advice not to make my lines so long;):
string sBuffer = " {...} "; // 255 spaces
So I assume that this causes the char-marmelade I got?
Now it works - Thanks deVries!
Gooly
VaBus: I need the content immediately. Saving is only for security.
Thanks again to all!
I was using a buffer with 255 bytes ( and got the advice not to make my lines so long;):
So I assume that this causes the char-marmelade I got?
The deVries code works, slowly, because it reads one byte at a time. Indirectly - and perhaps unintentionally - this does Ansi->Uncode conversion on the one byte. (The code in easymql.mqh at https://www.mql5.com/en/code/1998 is a much, much better way of using InternetReadFile.)
If you use a larger string buffer such as 255 bytes, then you are reading Ansi data into a buffer where MT4 is expecting Unicode, and you are almost certainly going to get garbage.
The deVries code works, slowly, because it reads one byte at a time. Indirectly - and perhaps unintentionally - this does Ansi->Uncode conversion on the one byte. (The code in easymql.mqh at https://www.mql5.com/en/code/1998 is a much, much better way of using InternetReadFile.)
If you use a larger string buffer such as 255 bytes, then you are reading Ansi data into a buffer where MT4 is expecting Unicode, and you are almost certainly going to get garbage.
You are right, but it needs some changes - this works:
#import "wininet.dll" int InternetOpenW(string,int,string,string,int); int InternetConnectW(int,string,int,string,string,int,int,int); int InternetOpenUrlW(int,string,string,int,int,int); int InternetReadFile(int hFile,uchar &sBuffer[],int lNumBytesToRead,int &lNumberOfBytesRead[]); int InternetCloseHandle(int); #import ... bool GrabWeb(string strUrl, string& result, int debug=0) { // MUST HAVE THIS DEFINITION!!: // int InternetReadFile(int hFile,uchar &sBuffer[],int lNumBytesToRead,int &lNumberOfBytesRead[]); int HttpOpen=InternetOpenW(" ",0," "," ",0); int HttpConnect = InternetConnectW(HttpOpen, "", 80, "", "", 3, 0, 1); int HttpRequest = InternetOpenUrlW(HttpOpen,strUrl, NULL, 0, 0, 0); int read[1]; int sz; uchar buffer[1024]; bool isOk; while(true) { isOk = InternetReadFile(HttpRequest,buffer,1024,read); sz += read[0]; if(read[0]>0) result=result+CharArrayToString(buffer,0,read[0],CP_UTF8); else break; } if(HttpRequest>0) InternetCloseHandle(HttpRequest); if(HttpConnect>0) InternetCloseHandle(HttpConnect); if(HttpOpen>0) InternetCloseHandle(HttpOpen); if (sz>0) return(true); else return(false); }
thanks!
#import "urlmon.dll" int URLDownloadToFileW(int pCaller,string szURL,string szFileName,int dwReserved,int Callback); #import int PeriodTimeWeek; string urlNews = "http://calendar.forex-tsd.com/calendar.php?csv=1&calendar[]=4&";
if (PeriodTimeWeek < iTime(NULL, PERIOD_W1, 0)) { PeriodTimeWeek = iTime(NULL, PERIOD_W1, 0); date = StringConcatenate(getCorrectDate); string completeUrlNews = StringConcatenate(urlNews, "date=", date, "gmt=", IntegerToString(serverGMT())); string file = StringConcatenate(date, ".csv"); if (!FileIsExist(file)) { int res = URLDownloadToFileW(NULL, completeUrlNews, file, 0, NULL); if (res == 0) Print("Download OK"); else Print("Download failed"); } }
string getCorrectDate() { string month = TimeMonth(TimeCurrent()); string day = TimeDay(TimeCurrent()); if (StringLen(month) == 1) { month = StringConcatenate("0", month); } if (StringLen(day) == 1) { day = StringConcatenate("0", day); } return(StringConcatenate(TimeYear(TimeCurrent()), month, day)); }
It´s working... Once a week you get the news with only URLDownloadToFileW.
A best way could be using
URLDownloadToFileW
That's really good solution!
Be recommended!
- Free trading apps
- Over 8,000 signals for copying
- Economic news for exploring financial markets
You agree to website policy and terms of use
Well I managed to dld the csv-file for yesterday from the tds-calendar,
url: http://calendar.forex-tsd.com/calendar.php?csv=1&date=20140214&calendar[]=4&gmt=0
If I paste that into the address line of my FF, FF asks me to open this files with LibreOffice, which I can and where I see and recognize all Friday's News :)
OK, the address is correct!
Now I let mt4 b600+ grab this file:
And the result is written to a local file herewith:
Even this is done without any error, BUT:
from here on if I open this file and try to read it mt4 b600 cannot :(
If I open the saved file with the Notepad++-editor I read only 1 line:
?????????????????-?????????????????????? ??-????????????????????????????????????? ....
The Encoding Option of Notepad++ tells me ANSI.
And even if I try to open this csv-file with Libre-Office I only see ??????????????????? hundreds of them, no date, no time, no news, nothing but ??
So do I have to do to get out of this mess?
Gooly
Adding a little joke look a the picture what mt4 wants to 'give' me as the fin. news from yesterday, Friday:
PS: I tried to go back to ..OpenA(..) and ..ConnectA(..) and ..OpenUrlA(..) but then I don't get a valid handle: hInternet == 0 :(