Orderselect always retrun false..

[Deleted] 2013.11.09 05:25

Hi..

This is my code, when i test it, its always return false and execute OpenBuy function, why its happened please guide me :-

      if (OrderSelect(TicketNumber, SELECT_BY_TICKET) == true) {
         if (OrderType() == OP_SELL) {
               CloseSell();
               OpenBuy();
         }         
      } else {         
         OpenBuy();
      }

Ian Flanagan 2013.11.09 06:33 #1

I have no idea. Add some checks, e.g.

Alert("TicketNumber:",TicketNumber);

and see if it's right.

Are you SURE it's return false? How are you checking the return value?

Do you know that if OrderSelect returns true, and OrderType is not OP_SELL than OpenBuy() is not triggered?

Add this alert:

Alert("OrderSelected:",(OrderSelect(TicketNumber, SELECT_BY_TICKET));

0 = false, 1 = true;

Also, add this code after OrderSelect:

int error = GetLastError();
if(error !=0) Alert("error:",error);

Basically, learn to solve it yourself

[Deleted] 2013.11.09 11:36 #2

hi..

Thank you for your advise..

Its display message as below:

Aler: OrderSelect: 0

int            TicketNumber = 12345;
...
...
...

int GetTicketNumber (int TicketNumber, string symbol, int timeFrame) {   
   int isymbol = 0;
   if (symbol == "EURUSD")       isymbol = 1;
   else if (symbol == "GBPUSD")  isymbol = 2;
   else if (symbol == "USDJPY")  isymbol = 3;
   else if (symbol == "USDCHF")  isymbol = 4;
   else if (symbol == "AUDUSD")  isymbol = 5;
   else if (symbol == "USDCAD")  isymbol = 6;
   else if (symbol == "EURGBP")  isymbol = 7;
   else if (symbol == "EURJPY")  isymbol = 8;
   else if (symbol == "EURCHF")  isymbol = 9;
   else if (symbol == "EURAUD")  isymbol = 10;
   else if (symbol == "EURCAD")  isymbol = 11;
   else if (symbol == "GBPUSD")  isymbol = 12;
   else if (symbol == "GBPJPY")  isymbol = 13;
   else if (symbol == "GBPCHF")  isymbol = 14;
   else if (symbol == "GBPAUD")  isymbol = 15;
   else if (symbol == "GBPCAD")  isymbol = 16;
   else                          isymbol = 17;
   
   return (TicketNumber + isymbol);
   //return (StrToInteger(StringConcatenate(TicketNumber, isymbol, timeFrame)));
}

int init() {
       TicketNumber = GetTicketNumber( TicketNumber, Symbol(), Period() );      
       return (0);
}

void OpenBuy() {   
   if (MinProfit > 0) {
      OrderSend(Symbol(),OP_BUY,lot,Ask,1,0,Ask+MinProfit*Point,"arnab",TicketNumber,0,Blue);      
   } else {
      OrderSend(Symbol(),OP_BUY,lot,Ask,1,0,0,"arnab",TicketNumber,0,Blue);      
   }
}

void CloseSell() {   
   OrderClose(OrderTicket(), OrderLots(), Bid, 3, Red);
}

void OpenSell() {
   if (MinProfit > 0) {
      OrderSend(Symbol(),OP_SELL,lot,Bid,1,0,Bid-MinProfit*Point,"arnab",TicketNumber,0,Red);       
   } else {
      OrderSend(Symbol(),OP_SELL,lot,Bid,1,0,0,"arnab",TicketNumber,0,Red);       
   }
}

void CloseBuy() { 
   OrderClose(OrderTicket(), OrderLots(), Ask, 3, Blue);         
}

...
...
...
    if (Test > 0) {
      Alert("Orderselect: ", (OrderSelect(TicketNumber, SELECT_BY_TICKET)));
      if (OrderSelect(TicketNumber, SELECT_BY_TICKET) == true) {
         error = GetLastError();
         if (error != 0) Alert("error:", error);

         if (OrderType() == OP_SELL) {
            Print ("SELL OrderType: " + OrderType());
            CloseSell();
            OpenBuy();
         }         
      } else {         
         OpenBuy();
      }      
   } else {
      Alert("Orderselect: ", (OrderSelect(TicketNumber, SELECT_BY_TICKET)));
      if (OrderSelect(TicketNumber, SELECT_BY_TICKET) == true) {
         error = GetLastError();
         if (error != 0) Alert("error:", error);
         
         if (OrderType() == OP_BUY) {
             CloseBuy();
             OpenSell();
          }
      } else {
         OpenSell();
      }
   }

Thank you

Simon Gniadkowski 2013.11.09 12:48 #3

bh_hensem:

hi..

Thank you for your advise..

Its display message as below:

Aler: OrderSelect: 0

Thank you

Where are you setting the value for TicketNumber ?

[Deleted] 2013.11.09 13:14 #4

hi..

This is the setting:-

int TicketNumber = 12345;

or you can refer to my previous thread as above...i have edit the code...

Thank you and please guide me... i have no ideas to solve this problem..

Journal - Settings - Managing Pending Orders - Projects and MQL5 Storage

Simon Gniadkowski 2013.11.09 13:43 #5

bh_hensem:

hi..

This is the setting:-

int TicketNumber = 12345;

or you can refer to my previous thread as above...i have edit the code...

Thank you and please guide me... i have no ideas to solve this problem..

What does this code do to the ticket number ?

TicketNumber = GetTicketNumber( TicketNumber, Symbol(), Period() );

[Deleted] 2013.11.09 13:59 #6

Hi...

The GetTicketNumber function called to create TicketNumber based on symbol and timeframe..The code as below:-

int GetTicketNumber (int TicketNumber, string symbol, int timeFrame) {   
   int isymbol = 0;
   if (symbol == "EURUSD")       isymbol = 1;
   else if (symbol == "GBPUSD")  isymbol = 2;
   else if (symbol == "USDJPY")  isymbol = 3;
   else if (symbol == "USDCHF")  isymbol = 4;
   else if (symbol == "AUDUSD")  isymbol = 5;
   else if (symbol == "USDCAD")  isymbol = 6;
   else if (symbol == "EURGBP")  isymbol = 7;
   else if (symbol == "EURJPY")  isymbol = 8;
   else if (symbol == "EURCHF")  isymbol = 9;
   else if (symbol == "EURAUD")  isymbol = 10;
   else if (symbol == "EURCAD")  isymbol = 11;
   else if (symbol == "GBPUSD")  isymbol = 12;
   else if (symbol == "GBPJPY")  isymbol = 13;
   else if (symbol == "GBPCHF")  isymbol = 14;
   else if (symbol == "GBPAUD")  isymbol = 15;
   else if (symbol == "GBPCAD")  isymbol = 16;
   else                          isymbol = 17;
   
   return (TicketNumber + isymbol);
   //return (StrToInteger(StringConcatenate(TicketNumber, isymbol, timeFrame)));
}

Simon Gniadkowski 2013.11.09 14:03 #7

bh_hensem:

Hi...

The GetTicketNumber function called to create TicketNumber based on symbol and timeframe..The code as below:-

OK, and you know that you have an open Order with that ticket number how ? you don't assign a ticket number to an Order it is set by the Broker's server.

[Deleted] 2013.11.09 14:21 #8

hi..

what do you means ?

I have passed the TicketNumber on Ordersend command.. where is my mistake ?

...
void OpenBuy() {   
   if (MinProfit > 0) {
      OrderSend(Symbol(),OP_BUY,lot,Ask,1,0,Ask+MinProfit*Point,"arnab",TicketNumber,0,Blue);      
   } else {
      OrderSend(Symbol(),OP_BUY,lot,Ask,1,0,0,"arnab",TicketNumber,0,Blue);      
   }
}
...

Simon Gniadkowski 2013.11.09 14:36 #9

bh_hensem:

hi..

what do you means ?

I have passed the TicketNumber on Ordersend command.. where is my mistake ?

There is no variable in OrderSend for the ticket number, the ticket number is returned by OrderSend(). Read the documentation click ---> OrderSend()

What you are passing to OrderSend() is the Magic Number not the Ticket Number, they are very different.

William Roeder 2013.11.09 15:26 #10

You can NOT create ticket numbers. You get them from the broker, either from the OrderSend or a OrderSelect loop

1 2

New comment