Little help and modification needed

Jayaram Naick Bukke 2013.08.30 01:28

//+------------------------------------------------------------------+
//|                                                 ForexSession.mq4 |
//|                   2011-1-18 16:30:18 oldz.cn@qq.com         OldZ |
//|                                        http://www.metaquotes.net |
//+------------------------------------------------------------------+
// The design idea is from http://www.forexmarkethours.com/ 

#property copyright "OldZ"
#property link      "http://www.metaquotes.net"

#property indicator_separate_window
#property indicator_minimum 0
#property indicator_maximum 1
#property indicator_buffers 4
#property indicator_color1 Blue
#property indicator_color2 Gold
#property indicator_color3 Green
#property indicator_color4 OrangeRed
//---- input parameters
extern int       LocalGMT=8; // Local time zone GMT offset
extern int       BrokerGMT=1; // Broker MT4's GMT offset
extern bool      ShowText = true; // Show each session on the left top corner.
int      SessionLocal[8],SessionBroker[8];
//---- buffers

double Sydney[];
double Tokyo[];
double London[];
double NewYork[];
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_ARROW);
   SetIndexArrow(0,110);
   SetIndexBuffer(0,Sydney);
   SetIndexLabel(0,"Sydney");
   SetIndexEmptyValue(0,0.0);
   
   SetIndexStyle(1,DRAW_ARROW);
   SetIndexArrow(1,110);
   SetIndexBuffer(1,Tokyo);
   SetIndexLabel(1,"Tokyo");
   SetIndexEmptyValue(1,0.0);
   
   SetIndexStyle(2,DRAW_ARROW);
   SetIndexArrow(2,110);
   SetIndexBuffer(2,London);
   SetIndexLabel(2,"London");
   SetIndexEmptyValue(2,0.0);
   
   SetIndexStyle(3,DRAW_ARROW);
   SetIndexArrow(3,110);
   SetIndexBuffer(3,NewYork);
   SetIndexLabel(3,"NewYork");
   SetIndexEmptyValue(3,0.0);
   
   IndicatorDigits(Digits);
   
   SessionLocal(LocalGMT);
   SessionBroker(BrokerGMT);   
  
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   Comment("");
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int    counted_bars=IndicatorCounted();
         if(counted_bars<0) return(-1);
         if(counted_bars>0) counted_bars--;
   int   limit = Bars-counted_bars;
//----
   int i;
   int hr;
   datetime t5 = iTime(NULL,PERIOD_D1,4);// 4 : draw 5 days 
   for(i=0;i<limit && Time[i]>=t5 ;i++)
   {     
      hr = TimeHour(Time[i]);
      DrawBrokerSession(hr,i);
   }
   
    if(ShowText)
    ShowSessionLocal();
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

void SessionLocal(int LocalGMT)
   {
      int gmt_diff = 8-LocalGMT;// 
            
      SessionLocal[0] =  6 - gmt_diff;
      SessionLocal[1] =  14 - gmt_diff;
      
      SessionLocal[2] =  8 - gmt_diff;
      SessionLocal[3] =  16 - gmt_diff;
      
      SessionLocal[4] =  16 - gmt_diff;
      SessionLocal[5] =  0 - gmt_diff;// 
      
      SessionLocal[6] =  21 - gmt_diff;
      SessionLocal[7] =  5 - gmt_diff;
      
      for( int i=0;i<8;i++)      
         if(SessionLocal[i]<0) SessionLocal[i]+=24;
      
   }
     
void SessionBroker(int BrokerGMT)
   {
      int gmt_diff = 1-BrokerGMT;// 
            
      SessionBroker[0] =  23 - gmt_diff;
      SessionBroker[1] =  7 - gmt_diff;
      
      SessionBroker[2] =  1 - gmt_diff;
      SessionBroker[3] =  9 - gmt_diff;
      
      SessionBroker[4] =  9 - gmt_diff;
      SessionBroker[5] =  17 - gmt_diff;
      
      SessionBroker[6] =  14 - gmt_diff;
      SessionBroker[7] =  22 - gmt_diff;
      
      for( int i=0;i<8;i++)      
         if(SessionBroker[i]<0) SessionBroker[i]+=24;      
   }  


void DrawBrokerSession(int hr,int i)
{
   if(SessionBroker[0]<SessionBroker[1])  
      if(SessionBroker[0]<=hr && hr <=SessionBroker[1]) Sydney[i]=0.8;
   if(SessionBroker[0]>SessionBroker[1]) 
     { 
       if(hr>=SessionBroker[0] && hr<=23)  Sydney[i] = 0.8;
       if(hr>=0 && hr<=SessionBroker[1])   Sydney[i] = 0.8;
      }
      
      
   if(SessionBroker[2]<SessionBroker[3])  
      if(SessionBroker[2]<=hr && hr <=SessionBroker[3]) Tokyo[i]=0.6;
   if(SessionBroker[2]>SessionBroker[3]) 
      { 
       if(hr>=SessionBroker[2] && hr<=23)  Tokyo[i] = 0.6;
       if(hr>=0 && hr<=SessionBroker[3])   Tokyo[i] = 0.6;
      }
      
   
   if(SessionBroker[4]<SessionBroker[5])  
      if(SessionBroker[4]<=hr && hr <=SessionBroker[5]) London[i]=0.4;
   if(SessionBroker[4]>SessionBroker[5]) 
       { 
       if(hr>=SessionBroker[4] && hr<=23)  London[i] = 0.4;
       if(hr>=0 && hr<=SessionBroker[5])   London[i] = 0.4;
      }
   
   if(SessionBroker[6]<SessionBroker[7])  
      if(SessionBroker[6]<=hr && hr <=SessionBroker[7]) NewYork[i]=0.2;
   if(SessionBroker[6]>SessionBroker[7]) 
       { 
       if(hr>=SessionBroker[6] && hr<=23)  NewYork[i] = 0.2;
       if(hr>=0 && hr<=SessionBroker[7])   NewYork[i] = 0.2;
      }    
   
}
   
void ShowSessionLocal()
   {
      Comment("\n", 
              "Forex market session on local time (GMT ",LocalGMT,")   ",TimeToStr(TimeLocal(),TIME_SECONDS),"\n",
              "Sydney   session:  ",SessionLocal[0]+":00 ----",SessionLocal[1]+":59","\n",
              "Tokyo    session:  ",SessionLocal[2]+":00 ----",SessionLocal[3]+":59","\n",
              "London   session:  ",SessionLocal[4]+":00 ----",SessionLocal[5]+":59","\n",
              "NewYork  session:  ",SessionLocal[6]+":00 ----",SessionLocal[7]+":59","\n");              
   }

Hi the above one is very nice indicator..

little correction to be modified are..

1. if local time it is showing top left corner is covering hiding candles can we place it some where as box so that we drag it to anywhere in chart as box.

2. I can see only integer type.. can u modify it to doubl type so that i can add my local time (ex here in india local time is GMT +5.30 but it is considering 530 so i am unable to place 5hrs 30min)

3. Can u make Vertical lines exactly on the chart window saying that text (vertical text) names of session open and close.

Thank you for your wonderfull indicator and your help.

Simon Gniadkowski 2013.08.30 05:39 #1

naickmt4:

Hi the above one is very nice indicator..

little correction to be modified are..

1. if local time it is showing top left corner is covering hiding candles can we place it some where as box so that we drag it to anywhere in chart as box.

2. I can see only integer type.. can u modify it to doubl type so that i can add my local time (ex here in india local time is GMT +5.30 but it is considering 530 so i am unable to place 5hrs 30min)

3. Can u make Vertical lines exactly on the chart window saying that text (vertical text) names of session open and close.

Thank you for your wonderfull indicator and your help.

1. No, Comment() is shown in the top left corner, you can change it to a Label Object and place it where you want.

2. The local time just shows seconds, change it to hours and minutes if you want.

3. what have you tried so far ?

If you want someone else to do your work for you go here: Modify my MT4 Indicator

Bitmap Label - Graphical Text Label - Graphical Managing Pending Orders -

Jayaram Naick Bukke 2013.08.30 10:59 #2

RaptorUK:

1. No, Comment() is shown in the top left corner, you can change it to a Label Object and place it where you want.

2. The local time just shows seconds, change it to hours and minutes if you want.

3. what have you tried so far ?

If you want someone else to do your work for you go here: Modify my MT4 Indicator

I want to input parameter of Local GMT =5.30; but i could not enter 5.30 but i can enter 5 in input parameter. so how can i edit the below line and how it will effect for entire program

extern int       LocalGMT=8; // Local time zone GMT offset

Horizontal Line - Lines Horizontal Line - Lines Edit - Graphical Objects

Ahmad Mehdiyev 2013.08.30 11:28 #3

first, 5 hours 30 minutes is not entered as 5.3 ! Think about it.

second, you cannot simply change int to double in that line alone... there will have to be a lot more changes made in the code.

History - MetaTrader 5 Password Recovery - MQL5 Parameters and arguments

Jayaram Naick Bukke 2013.08.30 11:40 #4

pro_:

first, 5 hours 30 minutes is not entered as 5.3 ! Think about it.

second, you cannot simply change int to double in that line alone... there will have to be a lot more changes made in the code.

yes may be u r right..

that is First issue. Secondly i have seen that time as per Broker GMT (+3 ) i should see the market starting from 10.00 for Europe and 15.00 for New York. But it shows me starts time of 11 for europe and 16.00o for Newyork. what changes is to be made in input as well as in program.

u are right not a simple double type instead of int. help in tese two issues as stated above. Thanks for your help.

ArrayFill Basic concepts Constant variables

New comment