macd sample in different chart n different pair

New comment
 

hai everyone.... iam trying to make macd sample, n ihope it can running in several different chart, with several different pair, but one ea, when i put it into chart i hope it can make open orders, so when if i put it again to another chart with different pair, i hopo it make another open order,... so this is the code (EA) that iam trying to make...


#define MAGIC  20050610

extern double TakeProfit = 50;
extern double Lots = 0.1;
extern double TrailingStop = 30;
extern double MACDOpenLevel=3;
extern double MACDCloseLevel=2;
extern double MATrendPeriod=26;
extern double Stoploss = 30;

//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int start()
  {
 double MacdCurrent, MacdPrevious, SignalCurrent;
   double SignalPrevious, MaCurrent, MaPrevious;
   int cnt, ticket, total;
// initial data checks
// it is important to make sure that the expert works with a normal
// chart and the user did not make any mistakes setting external 
// variables (Lots, StopLoss, TakeProfit, 
// TrailingStop) in our case, we check TakeProfit
// on a chart of less than 100 bars
   if(Bars<100)
     {
      Print("bars less than 100");
      return(0);  
     }
   if(TakeProfit<10)
     {
      Print("TakeProfit less than 10");
      return(0);  // check TakeProfit
     }
// to simplify the coding and speed up access
// data are put into internal variables
   MacdCurrent=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_MAIN,0);
   MacdPrevious=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_MAIN,1);
   SignalCurrent=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_SIGNAL,0);
   SignalPrevious=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_SIGNAL,1);
   MaCurrent=iMA(NULL,0,MATrendPeriod,0,MODE_EMA,PRICE_CLOSE,0);
   MaPrevious=iMA(NULL,0,MATrendPeriod,0,MODE_EMA,PRICE_CLOSE,1);


   int TotalBuy=0, TotalSell=0;              ==================================\ is this line ok?, i hope with this code that my order total not just 1 openorder,
   for(int x=0; x<OrdersTotal(); x++)        ================================== \   if i had a mistake in this several line can anyone help, and what sould i do with 
      {                                                                          \   the code...
         OrderSelect(x, SELECT_BY_POS, MODE_TRADES); ==========================   \
         if (OrderSymbol()!=Symbol() && OrderMagicNumber()!=MAGIC) continue; ==   /
         if (OrderType()==OP_BUY)   TotalBuy++;================================  /
         else                                                                   /  
         if(OrderType()==OP_SELL)   TotalSell++;===============================/
      }

     
    // check for long position (BUY) possibility
      if(MacdCurrent<0 && MacdCurrent>SignalCurrent && MacdPrevious<SignalPrevious &&
         MathAbs(MacdCurrent)>(MACDOpenLevel*Point) && MaCurrent>MaPrevious)
         if(TotalBuy==0)
        {
         ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"macd sample",MAGIC,0,Green);
         if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
           }
         else Print("Error opening BUY order : ",GetLastError()); 
         return(0); 
        }
      // check for short position (SELL) possibility
      if(MacdCurrent>0 && MacdCurrent<SignalCurrent && MacdPrevious>SignalPrevious && 
         MacdCurrent>(MACDOpenLevel*Point) && MaCurrent<MaPrevious)
         if(TotalSell==0)
        {
         ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"macd sample",MAGIC,0,Red);
         if(ticket>0)
           {
            if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
           }
         else Print("Error opening SELL order : ",GetLastError()); 
         return(0);
        }
       return(0);
     
}

for(int x=0; x<OrdersTotal(); x++) ===> and is the meaning of this??  thanks before...
 
Looks fine to me. Meaning= for x equal zero, while x is less-then order-total, do what ever is in the loop, the increase x by 1.
 
ubzen:
Looks fine to me. Meaning= for x equal zero, while x is less-then order-total, do what ever is in the loop, the increase x by 1.

hai uzben, thanks for the answer.... but after one day long, i put it into 16 different chart, its only two open orders... 1. usdjpy = buy, and 1. eurusd= sell,...??

can you help me ..

 
gekafx:

hai everyone.... iam trying to make macd sample, n ihope it can running in several different chart, with several different pair, but one ea, when i put it into chart i hope it can make open orders, so when if i put it again to another chart with different pair, i hopo it make another open order,... so this is the code (EA) that iam trying to make...


Please don't double post . . . why do you need 2 threads about the same thing ?

https://www.mql5.com/en/forum/138673

New comment
Reason: