I did an EA, but dont work right... Why???

New comment

Szabolcs Heczei 2012.01.25 15:36

Hello!

I' a beginner in programming. I learn it two month ago, and now i don't know what can i do. So please help to me. :)

I very respecting u RaptorUK. If u have some free minutes, please help :)

I read all topics, what can help to me.

Its have some, for Sidus:

https://www.mql5.com/en/forum/134736

So, i want to programming to EA an Indicator. It name is Sidus v.2.

This program code is it:

//+------------------------------------------------------------------+
//|                                    Sidus v.2 Entry Indicator.mq4 |
//|                                                                  |
//|                                                   Ideas by Sidus |
//+------------------------------------------------------------------+
#property copyright "Sidus"
#property link      ""

#property indicator_chart_window
#property indicator_buffers 4
#property indicator_color1 Blue
#property indicator_color2 Red
#property indicator_color3 Blue
#property indicator_color4 DodgerBlue

#include <WinUser32.mqh>
//---- input parameters
extern int       FastEMA=14;
extern int       SlowEMA=21;
extern int       RSIPeriod=17;
extern bool      Alerts=false;
//---- buffers
double ExtMapBuffer1[];
double ExtMapBuffer2[];
double ExtMapBuffer3[];
double ExtMapBuffer4[];
double rsi_sig[];
//---- variables
int sigCurrent=0;
int sigPrevious=0;
double pipdiffCurrent=0;
double pipdiffPrevious=0;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0,DRAW_LINE);
   SetIndexBuffer(0,ExtMapBuffer1);
   SetIndexStyle(1,DRAW_LINE,1,3);
   SetIndexBuffer(1,ExtMapBuffer2);
   SetIndexStyle(2,DRAW_ARROW,1,5);
   SetIndexArrow(2,233);
   SetIndexBuffer(2,ExtMapBuffer3);
   SetIndexEmptyValue(2,0.0);
   SetIndexStyle(3,DRAW_ARROW,1,5);
   SetIndexArrow(3,234);
   SetIndexBuffer(3,ExtMapBuffer4);
   SetIndexEmptyValue(3,0.0);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
  RefreshRates();
   int limit;
   int counted_bars=IndicatorCounted();
   double rsi_sig=0;
   bool entry=false;
   double entry_point=0;
   
   //---- check for possible errors
   if(counted_bars<0) return(-1);
   //---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;
   limit=Bars-counted_bars;

   //---- main loop
   for(int i=0; i<limit; i++)
   {
     //---- ma_shift set to 0 because SetIndexShift called abowe
     ExtMapBuffer1[i]=iMA(NULL,0,FastEMA,0,MODE_EMA,PRICE_CLOSE,i);
     ExtMapBuffer2[i]=iMA(NULL,0,SlowEMA,0,MODE_EMA,PRICE_CLOSE,i);
     rsi_sig = iRSI(NULL, 0, RSIPeriod, PRICE_CLOSE, i);
     
     pipdiffCurrent=(ExtMapBuffer1[i]-ExtMapBuffer2[i]);

     //Comment("pipdiffCurrent = "+pipdiffCurrent+" ");
     if (pipdiffCurrent>0 && rsi_sig>50) 
     {
       sigCurrent = 1;  //Up
     }
     else if (pipdiffCurrent<0 && rsi_sig<50)
     {
       sigCurrent = 2;  //Down
     }
/*
     if (pipdiffCurrent>0) 
     {
       sigCurrent = 1;  //Up
     }
     else if (pipdiffCurrent<0)
     {
       sigCurrent = 2;  //Down
     }
*/     

     if (sigCurrent==1 && sigPrevious==2)
     {
        ExtMapBuffer4[i-1] = High[i-1]-5*Point;
        //ExtMapBuffer3[i] = Ask;
        entry=true;
        entry_point=Ask;
     } 
     else if (sigCurrent==2 && sigPrevious==1)
     {
        ExtMapBuffer3[i-1] = Low[i-1]-5*Point;
        //ExtMapBuffer4[i] = Bid;
        entry=true;
        entry_point=Bid;
     }


     sigPrevious=sigCurrent;
     pipdiffPrevious=pipdiffCurrent;
   }

   //----
   if(Alerts && entry)
   {
     PlaySound("alert.wav");
     if (sigPrevious==1)
     {
        MessageBox("Entry point: buy at "+entry_point+"!!", "Entry Point", MB_OK);
     }
     else if (sigPrevious==2)
     {
        MessageBox("Entry point: sell at "+entry_point+"!!", "Entry Point", MB_OK);
     }

     entry=false;
   }
RefreshRates();

//----
   return(0);
  }
//+------------------------------------------------------------------+

And i did it!

Here:

//+------------------------------------------------------------------+
//|                                               Beginner sidus.mq4 |
//|                                                          mindegy |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Beginner"
#property link      ""

//---- input parameters
extern int        StartHour = 0;
extern int        SL = 50;
extern int        TP = 55;
extern double    Lots=0.1;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//----
   
   static datetime myTime;
   
   int cmd = 2; double price; int slippage = 4; double stoploss; double takeprofit; color colour; int magic = 1111;
   bool myTrades; int myTicket;

   for(int i=0;i<OrdersTotal();i++)
   {
   if(OrderSelect(i,SELECT_BY_POS,MODE_TRADES)==false) break;
      if(OrderSymbol()==Symbol() && OrderMagicNumber()==magic)
      {
         myTrades = true;
         myTicket = OrderTicket();
      }
   }
   
   if(myTrades == false)
   {
      if(Hour() == StartHour) // Time to put your orders
      {
         double haOpen = iCustom(NULL,0,"sidus",14,21,17,false,2,1);
         double haClose = iCustom(NULL,0,"sidus",14,21,17,false,3,1);
         
         if(haOpen < haClose) 
         { 
            cmd = 0; price = Ask; colour = Green; stoploss = Bid - SL*Point; takeprofit = Ask + TP*Point; 
         }
         
         if(haOpen > haClose)
         {
            cmd = 1; price = Bid; colour = Red; stoploss = Ask + SL*Point; takeprofit = Ask - TP*Point;
         }
   
         if(cmd != 2)
         {
            OrderSend(Symbol(), cmd, Lots, price, slippage, stoploss, takeprofit, NULL, magic, 0, colour) ;
            return;
         }
      }
   }
   
   
//----
   return(0);
  }
//+------------------------------------------------------------------+

Simon Gniadkowski 2012.01.25 16:07 #1

What is this meant to achieve ? and how does it achieve it ?

 if(Hour() == StartHour) // Time to put your orders

[Deleted] 2013.05.15 12:46 #2

Hi Charma,

I just found your EA today and I have fixed the custom indicator signal for you, I have been searching for years to find An editable Copy of the

Sidus v.2 indicator and thanks to you I now know how it works. I have Attached a copy of the edited EA for you but I will explain to you what I did also.

I removed the code:

if(Hour() == StartHour) // Time to put your orders

As it would only open a trade if both the StartHour and custom indicator parameters were true...

once I removed that part I read the code for the Sidus Indicator to edit this part for you:

         double haOpen = iCustom(NULL,0,"sidus",14,21,17,false,2,1);
         double haClose = iCustom(NULL,0,"sidus",14,21,17,false,3,1);
         
         if(haOpen < haClose) 
         { 
            cmd = 0; price = Ask; colour = Green; stoploss = Bid - SL*Point; takeprofit = Ask + TP*Point; 
         }
         
         if(haOpen > haClose)
         {
            cmd = 1; price = Bid; colour = Red; stoploss = Ask + SL*Point; takeprofit = Ask - TP*Point;
         }
   
         if(cmd != 2)
         {
            OrderSend(Symbol(), cmd, Lots, price, slippage, stoploss, takeprofit, NULL, magic, 0, colour) ;
            return;

I edited like this:

         double HaOpen  =  iCustom(NULL,0,"sidus v.2",14,21,17,false,3,1);
         double haOpen  =  iCustom(NULL,0,"sidus v.2",14,21,17,false,2,0);
         double HaClose =  iCustom(NULL,0,"sidus v.2",14,21,17,false,2,1);
         double haClose =  iCustom(NULL,0,"sidus v.2",14,21,17,false,3,0);
         
         if(HaOpen < haOpen) // BUY SIGNAL!!
         { 
            cmd = 0; price = Ask; colour = Green; stoploss = Bid - SL*Point; takeprofit = Ask + TP*Point; 
         }
         
         if(HaClose < haClose) // SELL SIGNAL!!
         {
            cmd = 1; price = Bid; colour = Red; stoploss = Ask + SL*Point; takeprofit = Ask - TP*Point;
         }
   
         if(cmd != 2)
         {
            OrderSend(Symbol(), cmd, Lots, price, slippage, stoploss, takeprofit, NULL, magic, 0, colour) ;
            return;

Sadly the Indicator is still not placing all the Buy Sell signals when back testing but I will try to fix that problem and attach the new indicator at a latter date..

I am also making my own EA that will Move Order Stops at each signal following the trend Just like you would when manual trading and I will post it too once I am done.

You still need to add a MaxOrder option to your EA as it will keep placing orders for the Whole Bar.. Maybe a Maxtrade per Bar option would work..

Anyway I Hope you find this helpful and once again Thank You for posting the Indicator code you have made me a very happy man ;)

Best Regards: FirePubes..

JeffRo

Files:

sidus1.mq4 3 kb

MQL5 Wizard: Development of How to Subscribe to Indicators - Charts -

Simon Gniadkowski 2013.05.15 13:03 #3

FirePubes:

Hi Charma,

I just found your EA today and I have fixed the custom indicator signal for you, I have been searching for years to find An editable Copy of the

Sidus v.2 indicator and thanks to you I now know how it works. I have Attached a copy of the edited EA for you but I will explain to you what I did also.

I removed the code:

As it would only open a trade if both the StartHour and custom indicator parameters were true...

once I removed that part I read the code for the Sidus Indicator to edit this part for you:

I edited like this:

Sadly the Indicator is still not placing all the Buy Sell signals when back testing but I will try to fix that problem and attach the new indicator at a latter date..

Do yourself a big favour, check the return values from your trading functions and report any errors: What are Function return values ? How do I use them ?

William Roeder 2013.05.15 13:21 #4

Indicator

```
int start(){
  RefreshRates();
```
Unnecessary

 if(counted_bars>0) counted_bars--;
 limit=Bars-counted_bars;

Contradictory information on IndicatorCounted() - MQL4 forum

   for(int i=0; i<limit; i++){

     if (pipdiffCurrent>0 && rsi_sig>50) ..

     if (sigCurrent==1 && sigPrevious==2)

What is sigPrevious, you are counting UP. there is no previous You can't look at future values.
Always count down

for(int i=Bars-1-counted_bars; i>=0; i--){

     if (sigCurrent==1 && sigPrevious==2)
     {
        ExtMapBuffer4[i-1] = High[i-1]-5*Point;

Again you are setting a future indicator value. You probably mean

ExtMapBuffer4[i] = High[i+1]-5*Point;

```
  for(int i=0;i<OrdersTotal();i++)
```
Get in the habit of couning down. Loops and Closing or Deleting Orders - MQL4 forum

            cmd = 1; price = Bid; colour = Red; stoploss = Ask + SL*Point; takeprofit = Ask - TP*Point;
         }
   
         if(cmd != 2)
         {
            OrderSend(Symbol(), cmd, Lots, price, slippage, stoploss, takeprofit, NULL, magic, 0, colour) ;

Not adjusting for 4/5 digit brokers, not adjusting for ECN brokers. Not testing return codes.

New comment