Problem to change an ARROW for a LINE

New comment
 

I was breaking my head trying to do a very simple thing: Change an arrow style for a line style. I usually change only the SetIndexStyle, but this time it didn’t work, and the indicator disappear.

Do you know where my mistake is?

#property indicator_separate_window
#property indicator_buffers 5
#property indicator_color1 LimeGreen
#property indicator_color2 FireBrick
#property indicator_color3 Green
#property indicator_color4 Red
//---- input parameters
extern string separator1 = "*** EMA Settings ***";
extern int    fastEMA = 12;
extern int    slowEMA = 26;
extern int    signal = 9;
extern string separator2 = "*** Indicator Settings ***";
extern double positiveSensitivity = 0.0001;
extern double negativeSensitivity = -0.0001;
extern double historyBarsCount = 0;
extern bool   drawDivergenceLines = true;
extern bool   displayAlert = false;
//---- buffers
double upOsMA[];
double downOsMA[];
double bullishDivergence[];
double bearishDivergence[];
double OsMA[];
//----
static datetime lastAlertTime;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0, DRAW_ARROW);
   SetIndexStyle(1, DRAW_ARROW);
   SetIndexStyle(2, DRAW_NONE);
   SetIndexStyle(3, DRAW_NONE);
   SetIndexStyle(4, DRAW_NONE);
//----   
   SetIndexBuffer(0, bullishDivergence);
   SetIndexBuffer(1, bearishDivergence);
   SetIndexBuffer(2, upOsMA);
   SetIndexBuffer(3, downOsMA);
   SetIndexBuffer(4, OsMA);
//----
   IndicatorDigits(Digits + 2);
   IndicatorShortName("FX5_Divergence_v2.0(" + fastEMA + "," + 
                      slowEMA + "," + signal + ")");
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
   for(int i = ObjectsTotal() - 1; i >= 0; i--)
     {
       string label = ObjectName(i);
       if(StringSubstr(label, 0, 14) != "DivergenceLine")
           continue;
       ObjectDelete(label);   
     }
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start()
  {
   int countedBars = IndicatorCounted();
   if (countedBars < 0)
       countedBars = 0;
   CalculateIndicator(countedBars);
   return(0);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void CalculateIndicator(int countedBars)
  {
   for(int i = Bars - countedBars; i >= 0; i--)
     {
      CalculateOsMA(i);
      CatchBullishDivergence(i + 2);
      CatchBearishDivergence(i + 2);
     }              
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void CalculateOsMA(int i)
  {
   OsMA[i] = iOsMA(NULL, 0, fastEMA, slowEMA, signal, PRICE_CLOSE, i);
   if(OsMA[i] > 0)
     {
      upOsMA[i] = OsMA[i];
      downOsMA[i] = 0;
     }
   else 
       if(OsMA[i] < 0)
         {
           downOsMA[i] = OsMA[i];
           upOsMA[i] = 0;   
         }
   else
     {
       upOsMA[i] = 0;
       downOsMA[i] = 0;   
     }         
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void CatchBullishDivergence(int shift)
  {
   if(IsIndicatorTrough(shift) == false)
       return; 
   int currentTrough = shift;
   int lastTrough = GetIndicatorLastTrough(shift);
//----
   if(OsMA[currentTrough] > OsMA[lastTrough] && 
      Low[currentTrough] < Low[lastTrough])
     {
       bullishDivergence[currentTrough] = 1;
     }
     else
      {
        if(OsMA[currentTrough] < OsMA[lastTrough] && 
            Low[currentTrough] > Low[lastTrough])
           {
             bullishDivergence[currentTrough] = 1;
           } 
           else
           {
             bullishDivergence[currentTrough] = 0;
           }
      }       
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
void CatchBearishDivergence(int shift)
  {
   if(IsIndicatorPeak(shift) == false)
       return;
   int currentPeak = shift;
   int lastPeak = GetIndicatorLastPeak(shift);   
//----
   if(OsMA[currentPeak] < OsMA[lastPeak] && 
      High[currentPeak] > High[lastPeak])
     {
       bearishDivergence[currentPeak] = -1;
     }
   else
   {
    if(OsMA[currentPeak] > OsMA[lastPeak] && 
       High[currentPeak] < High[lastPeak])
        {
          bearishDivergence[currentPeak] = -1;
        }
        else
        {
          bearishDivergence[currentPeak] = 0;
        }  
    } 
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
bool IsIndicatorPeak(int shift)
  {
   if(OsMA[shift] > 0 + positiveSensitivity && 
      OsMA[shift] > OsMA[shift+1] && OsMA[shift] > OsMA[shift-1])
     {
       for(int i = shift + 1; i < Bars; i++)
         {
           if(OsMA[i] < 0)
               return(true);
           if(OsMA[i] > OsMA[shift])
               break;            
         }
     }   
   return(false);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
bool IsIndicatorTrough(int shift)
  {
   if(OsMA[shift] < 0 + negativeSensitivity && 
      OsMA[shift] < OsMA[shift+1] && OsMA[shift] < OsMA[shift-1])
     {
       for(int i = shift + 1; i < Bars; i++)
         {
           if(OsMA[i] > 0)
               return(true);
           if(OsMA[i] < OsMA[shift])
               break;            
         }
     }   
   return(false);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
int GetIndicatorLastPeak(int shift)
  {
   bool redZone = false;
   
   for(int i = shift; i < Bars; i++)
     {
       if(OsMA[i] > 0 && redZone == false)
          continue;
       if(OsMA[i] < 0)
         {
           redZone = true;
           continue;
         }
       if(OsMA[i] < positiveSensitivity)
           continue;
       if(OsMA[i] > OsMA[i+1] && OsMA[i] > OsMA[i-1])
           return(i);
     }
   return(-1);
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
int GetIndicatorLastTrough(int shift)
{
   bool greenZone = false;
   
   for (int i = shift; i < Bars; i++)
   {
      if (OsMA[i] < 0 && greenZone == false)
         continue;
      if (OsMA[i] > 0)
      {
         greenZone = true;
         continue;
      }
      if (OsMA[i] > negativeSensitivity)
         continue;      
      if (OsMA[i] < OsMA[i+1] && OsMA[i] < OsMA[i-1])
         return(i);
   }
   return(-1);
}
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

 

I got a blank display, then adding

#property indicator_width1 2
#property indicator_width2 2

worked for me ...

Although removing those lines & recompiling also worked! *strange* !

 

Thanks brewmanz... Very strange! Bug?!

New comment