I need help

Wackena 2010.09.05 17:22 #1

abcc:

here is what I want my computer compiles;)

OrderModify(OrderTicket(),OrderOpenPrice(),(Highest high since the order began)-Point*TrailingStop,OrderTakeProfit(),0,Green);

Can someone help me?

Thanks

Try this. Not tested. Hope it works OK.

double HighestPrice() // find highest price since current order opened
{ 
   double HPrice=0; 
   int per=0;
   for (int i=0; i<OrdersTotal(); i++) 
      { 
         if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) 
         if((OrderSymbol()==Symbol()) && OrderMagicNumber() == MagicNumber) 
            {
               per=iBarShift(Symbol(),Period(),OrderOpenTime()); // Find number of bars since order opened
               HPrice=NormalizeDouble(iHigh(Symbol(),Period(),iHighest(Symbol(),Period(),MODE_HIGH,per,0)),Digits); 
            } 
      }  
   return(HPrice); 
}

[Deleted] 2010.09.05 18:00 #2

wackena:

Try this. Not tested. Hope it works OK.

How can I put your code into this one;

//+------------------------------------------------------------------+
//| MACD .mq4 |
//|

//+------------------------------------------------------------------+

extern double TakeProfit = 50;
extern double Lots = 0.1;
extern double TrailingStop = 30;
extern double MACDOpenLevel=3;
extern double MACDCloseLevel=2;
extern double MATrendPeriod=26;

//+------------------------------------------------------------------+
//| |
//+------------------------------------------------------------------+
int start()
{
double MacdCurrent, MacdPrevious, SignalCurrent;
double SignalPrevious, MaCurrent, MaPrevious;
int cnt, ticket, total;
// initial data checks
// it is important to make sure that the expert works with a normal
// chart and the user did not make any mistakes setting external
// variables (Lots, StopLoss, TakeProfit,
// TrailingStop) in our case, we check TakeProfit
// on a chart of less than 100 bars
if(Bars<100)
{
Print("bars less than 100");
return(0);

Print("TakeProfit less than 10");
return(0); // check TakeProfit
}
// to simplify the coding and speed up access
// data are put into internal variables
MacdCurrent=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_MAIN,0);
MacdPrevious=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_MAIN,1);
SignalCurrent=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_SIGNAL,0);
SignalPrevious=iMACD(NULL,0,12,26,9,PRICE_CLOSE,MODE_SIGNAL,1);
MaCurrent=iMA(NULL,0,MATrendPeriod,0,MODE_EMA,PRICE_CLOSE,0);
MaPrevious=iMA(NULL,0,MATrendPeriod,0,MODE_EMA,PRICE_CLOSE,1);

total=OrdersTotal();
if(total<1)
{
// no opened orders identified
if(AccountFreeMargin()<(1000*Lots))
{
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}
// check for long position (BUY) possibility
if(MacdCurrent<0 && MacdCurrent>SignalCurrent && MacdPrevious<SignalPrevious &&
MathAbs(MacdCurrent)>(MACDOpenLevel*Point) && MaCurrent>MaPrevious)
{
ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"macd sample",16384,0,Green);
if(ticket>0)
{
if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
}
else Print("Error opening BUY order : ",GetLastError());
return(0);
}
// check for short position (SELL) possibility
if(MacdCurrent>0 && MacdCurrent<SignalCurrent && MacdPrevious>SignalPrevious &&
MacdCurrent>(MACDOpenLevel*Point) && MaCurrent<MaPrevious)
{
ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"macd sample",16384,0,Red);
if(ticket>0)
{
if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
}
else Print("Error opening SELL order : ",GetLastError());
return(0);
}
return(0);
}
// it is important to enter the market correctly,
// but it is more important to exit it correctly...
for(cnt=0;cnt<total;cnt++)
{
OrderSelect(cnt, SELECT_BY_POS, MODE_TRADES);
if(OrderType()<=OP_SELL && // check for opened position
OrderSymbol()==Symbol()) // check for symbol
{
if(OrderType()==OP_BUY) // long position is opened
{
// should it be closed?
if(MacdCurrent>0 && MacdCurrent<SignalCurrent && MacdPrevious>SignalPrevious &&
MacdCurrent>(MACDCloseLevel*Point))
{
OrderClose(OrderTicket(),OrderLots(),Bid,3,Violet); // close position
return(0); // exit
}
// check for trailing stop
if(TrailingStop>0)
{
if(Bid-OrderOpenPrice()>Point*TrailingStop)
{
if(OrderStopLoss()<Bid-Point*TrailingStop)
{
OrderModify(OrderTicket(),OrderOpenPrice(),Bid-Point*TrailingStop,OrderTakeProfit(),0,Green);
return(0);
}
}
}
}
else // go to short position
{
// should it be closed?
if(MacdCurrent<0 && MacdCurrent>SignalCurrent &&
MacdPrevious<SignalPrevious && MathAbs(MacdCurrent)>(MACDCloseLevel*Point))
{
OrderClose(OrderTicket(),OrderLots(),Ask,3,Violet); // close position
return(0); // exit
}
// check for trailing stop
if(TrailingStop>0)
{
if((OrderOpenPrice()-Ask)>(Point*TrailingStop))
{
if((OrderStopLoss()>(Ask+Point*TrailingStop)) || (OrderStopLoss()==0))
{
OrderModify(OrderTicket(),OrderOpenPrice(),Ask+Point*TrailingStop,OrderTakeProfit(),0,Red);
return(0);
}
}
}
}
}
}
return(0);
}
// the end.

thanks

Help me to add How to reverse trade error ' end_of_program' -

Ubzen 2010.09.05 18:11 #3

Use the SRC Button above when you Paste Codes.

Here's more codes which might help answer your question Here.

Wackena 2010.09.05 21:49 #4

Copy and paste this code past "// the end" of your EA code.

double HighestPrice() // find highest price since current order opened
{ 
   double HPrice=0; 
   int per=0;
   for (int i=0; i<OrdersTotal(); i++) 
      { 
         if (OrderSelect(i, SELECT_BY_POS, MODE_TRADES)) 
         if((OrderSymbol()==Symbol()) && OrderMagicNumber() == MagicNumber) 
            {
               per=iBarShift(Symbol(),Period(),OrderOpenTime()); // Find number of bars since order opened
               HPrice=NormalizeDouble(iHigh(Symbol(),Period(),iHighest(Symbol(),Period(),MODE_HIGH,per,0)),Digits); 
            } 
      }  
   return(HPrice); 
}

Then as example to use on code line in your first comment in this thread.

OrderModify(OrderTicket(),OrderOpenPrice(),HighestPrice()-Point*TrailingStop,OrderTakeProfit(),0,Green);

William Roeder 2010.09.06 16:13 #5

int    duration = iBarShift(NULL,0, OrderOpenTime());
double HH       = High[Highest(NULL,0, MODE_HIGH, duration+1, 0)],