Profit counting

[Gordon Gekko]

Please, help me to resolve this problem: I'd like to count the total amount of profit that belongs to a magic number (there are other orders with different magic on the account).

Here is my code:

double MagicProfit(int Magic)
{
  int total=OrdersTotal()-1;

  for (int cnt = total ; cnt >=0 ; cnt--)
  {
    OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
    
    if (OrderMagicNumber() == Magic && OrderSymbol()==Symbol() && (OrderType()==OP_SELL || OrderType()==OP_BUY))
    {
      P1=+OrderProfit();
      return(P1);
      break;
    }
  }
  return(0);
}

It shows just the profit of the last order, not the total. What is the good solution?

[Rogerio Figurelli]

ggekko:

Please, help me to resolve this problem: I'd like to count the total amount of profit that belongs to a magic number (there are other orders with different magic on the account).

Here is my code:

It shows just the profit of the last order, not the total. What is the good solution?

You have some mistakes, try the changes bellow.

[e-mail]

double MagicProfit(int Magic)
{
  double profit=0;
  int total=OrdersTotal()-1;

  for (int cnt = total ; cnt >=0 ; cnt--) {
    OrderSelect(cnt,SELECT_BY_POS,MODE_TRADES);
    if (OrderMagicNumber() == Magic) {
      profit+=OrderProfit();
    }
  }
  return(profit);
}

// Call example
P1 = MagicProfit(25); // return profit of Magic = 25

[Gordon Gekko]

figurelli:

You have some mistakes, try the changes bellow.

Rogerio Figurelli

[e-mail]
www.fxcoder.com

Thank you!

[Russell]

https://www.mql5.com/en/code/8640

hth

Russell