Message to UKT

prosper1 2008.06.23 10:36

Hi UKT,

Sorry to ask you again but i still have problem with it. Normally my EA must stop after have losed and restart next day.

When I test it sometimes it makes only one trade, or it makes more trades after have losed in the same day. Moreover, when I parametre the number of loss possible by day, there are no impact in my EA.

I have tried to change something in the code but it still doesn't work, I have not more idea.

Have you an idea to resolve this ?

Thanks for your answers.

The code :

#define SIGNAL_NONE 0
#define SIGNAL_BUY 1
#define SIGNAL_SELL 2
#define SIGNAL_CLOSEBUY 3
#define SIGNAL_CLOSESELL 4
#define SIGNAL_NUMBEROFLOSSPOSTODAY 5

extern int MagicNumber = 0;
extern bool SignalMail = False;
extern bool EachTickMode = True;
extern double Lots = 1.0;
extern int Slippage = 3;
extern bool UseStopLoss = True;
extern int StopLoss = 40;
extern bool UseTakeProfit = True;
extern int TakeProfit =30;
extern bool UseTrailingStop = False;
extern int TrailingStop = 30;
extern bool UseNumbersOfLossPosToday = True;
extern int NumberOfLossPosToday = 1;
int BarCount;
int Current;
bool TickCheck = False;



//+--------------------------------------------------------------------------------------+
//| Àâòîð : Êèì Èãîðü Â. aka KimIV, http://www.kimiv.ru |
//+--------------------------------------------------------------------------------------+
//| Âåðñèÿ : 19.02.2008 |
//| Îïèñàíèå : Âîçâðàùàåò êîëè÷åñòâî óáûòî÷íûõ ïîçèöèé, çàêðûòûõ ñåãîäíÿ. |
//+--------------------------------------------------------------------------------------+
//| Parametres: |
//| sy - Symbol ("" - any Symbol |
//| NULL - current Symbol) |
//| op - operation (-1 - any position) |
//| mn - MagicNumber (-1 - any magic) | 
//+---------------------------------------------------------------------------------------+
int NumberOfLossPosToday(string sy="", int op=-1, int mn=-1) {
datetime t;
int i, k=OrdersHistoryTotal(), kp=0;

for (i=0; i<k; i++) {
if (OrderSelect(i, SELECT_BY_POS, MODE_HISTORY)) {
if (OrderType()==OP_BUY || OrderType()==OP_SELL) {
if (op<0 || OrderType()==op) {
if (mn<0 || OrderMagicNumber()==mn) {
t=OrderCloseTime();
if (Year()==TimeYear(t) && DayOfYear()==TimeDayOfYear(t)) {
if (OrderProfit()<0) kp++;
if (OrderProfit()<0) Print("#",OrderTicket(),", Profit=",OrderProfit());
{

Print("NumberOfLossPosToday() = ",NumberOfLossPosToday());


}
}
}
}
}
}
}
}
return(0);


void Message(string m) {
Comment(m);
if (StringLen(m)>0) Print(m);
}


//+------------------------------------------------------------------+
//| expert initialization function |
//+------------------------------------------------------------------+
int init() {
BarCount = Bars;

if (EachTickMode) Current = 0; else Current = 1;

return(0);
}
//+------------------------------------------------------------------+
//| expert deinitialization function |
//+------------------------------------------------------------------+
int deinit() {
return(0);
}
//+------------------------------------------------------------------+
//| expert start function |
//+------------------------------------------------------------------+


int start () {
int Order = SIGNAL_NONE;
int Total, Ticket;
double StopLossLevel, TakeProfitLevel;

Message(NumberOfLossPosToday());

if (EachTickMode && Bars != BarCount) TickCheck = False;
Total = OrdersTotal();
Order = SIGNAL_NONE;


//+------------------------------------------------------------------+
//| Variable Begin |
//+------------------------------------------------------------------+

double Var1 = iADX(NULL, 0, 14, PRICE_MEDIAN, MODE_MAIN, Current + 0);
double Var2 = iATR(NULL, 0, 14, Current + 0);

double Buy1_1 = iATR(NULL, 0, 14, Current + 0);
double Buy1_2 = iADX(NULL, 0, 14, PRICE_MEDIAN, MODE_PLUSDI, Current + 0);

double Sell1_1 = iADX(NULL, 0, 14, PRICE_MEDIAN, MODE_MINUSDI, Current + 0);
double Sell1_2 = iATR(NULL, 0, 14, Current + 0);


//+------------------------------------------------------------------+
//| Variable End |
//+------------------------------------------------------------------+

//Check position
bool IsTrade = False;

for (int i = 0; i < Total; i ++) {
OrderSelect(i, SELECT_BY_POS, MODE_TRADES);
if(OrderType() <= OP_SELL && OrderSymbol() == Symbol()) {
IsTrade = True;
if(OrderType() == OP_BUY) {
//Close


//+------------------------------------------------------------------+
//| Signal End(Exit Buy) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSEBUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Bid, Slippage, MediumSeaGreen);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Close Buy");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) { 
if(Bid - OrderOpenPrice() > Point * TrailingStop) {
if(OrderStopLoss() < Bid - Point * TrailingStop) {
OrderModify(OrderTicket(), OrderOpenPrice(), Bid - Point * TrailingStop, OrderTakeProfit(), 0, MediumSeaGreen);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
} else {
//Close


//+------------------------------------------------------------------+
//| Signal End(Exit Sell) |
//+------------------------------------------------------------------+

if (Order == SIGNAL_CLOSESELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
OrderClose(OrderTicket(), OrderLots(), Ask, Slippage, DarkOrange);
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Close Sell");
if (!EachTickMode) BarCount = Bars;
IsTrade = False;
continue;
}
//Trailing stop
if(UseTrailingStop && TrailingStop > 0) { 
if((OrderOpenPrice() - Ask) > (Point * TrailingStop)) {
if((OrderStopLoss() > (Ask + Point * TrailingStop)) || (OrderStopLoss() == 0)) {
OrderModify(OrderTicket(), OrderOpenPrice(), Ask + Point * TrailingStop, OrderTakeProfit(), 0, DarkOrange);
if (!EachTickMode) BarCount = Bars;
continue;
}
}
}
}
}
}

//+------------------------------------------------------------------+
//| Signal Begin(Entry) |
//+------------------------------------------------------------------+

if (Buy1_1 < Buy1_2) Order = SIGNAL_BUY;

if (Sell1_1 < Sell1_2) Order = SIGNAL_SELL;


//+------------------------------------------------------------------+
//| Signal End |
//+------------------------------------------------------------------+

//Buy
if (Order == SIGNAL_BUY && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Ask - StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Ask + TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_BUY, Lots, Ask, Slippage, StopLossLevel, TakeProfitLevel, "Buy(#" + MagicNumber + ")", MagicNumber, 0, DodgerBlue);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("BUY order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Ask, Digits) + " Open Buy");
} else {
Print("Error opening BUY order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}

//Sell
if (Order == SIGNAL_SELL && ((EachTickMode && !TickCheck) || (!EachTickMode && (Bars != BarCount)))) {
if(!IsTrade) {
//Check free margin
if (AccountFreeMargin() < (1000 * Lots)) {
Print("We have no money. Free Margin = ", AccountFreeMargin());
return(0);
}

if (UseStopLoss) StopLossLevel = Bid + StopLoss * Point; else StopLossLevel = 0.0;
if (UseTakeProfit) TakeProfitLevel = Bid - TakeProfit * Point; else TakeProfitLevel = 0.0;

Ticket = OrderSend(Symbol(), OP_SELL, Lots, Bid, Slippage, StopLossLevel, TakeProfitLevel, "Sell(#" + MagicNumber + ")", MagicNumber, 0, DeepPink);
if(Ticket > 0) {
if (OrderSelect(Ticket, SELECT_BY_TICKET, MODE_TRADES)) {
Print("SELL order opened : ", OrderOpenPrice());
if (SignalMail) SendMail("[Signal Alert]", "[" + Symbol() + "] " + DoubleToStr(Bid, Digits) + " Open Sell");
} else {
Print("Error opening SELL order : ", GetLastError());
}
}
if (EachTickMode) TickCheck = True;
if (!EachTickMode) BarCount = Bars;
return(0);
}
}


if (!EachTickMode)BarCount = Bars;


return(0);}

//+------------------------------------------------------------------+

ukt 2008.06.23 13:54 #1

hi,

look - I am not only user on forum. Also, have not unlimited time to 1. manually format your code so I can attempt to make sense of it; 2. document out just what code presently does and then brainstorm about what it should do.

For me this all takes massive time - there are many others on this site far more capable than me.

I am attempting to manage my own every growing list of design/coding ToDo's and not get into total immersion over someone else's code, ok?

This is maybe harsh but cannot invest what for me is lots of time.

BUT... I would strongly suggest that any code you enter into post via SRC button to be formatted properly, ok?

eg:

int NumberOfLossPosToday(string sy="", int op=-1, int mn=-1)
{
  datetime t;
  int i, k=OrdersHistoryTotal(), kp=0;

  for (i=0; i<k; i++) {
      if (OrderSelect(i, SELECT_BY_POS, MODE_HISTORY)) {
          if (OrderType()==OP_BUY || OrderType()==OP_SELL) {
              if (op<0 || OrderType()==op) {
                  if (mn<0 || OrderMagicNumber()==mn) {
                      t=OrderCloseTime();
                      if (Year()==TimeYear(t) && DayOfYear()==TimeDayOfYear(t)) {
                          if (OrderProfit()<0) kp++;
                          if (OrderProfit()<0) Print("#",OrderTicket(),", Profit=",OrderProfit());
                          {
                              Print("NumberOfLossPosToday() = ",NumberOfLossPosToday());
                          }
                      }
                  }
              }
          }
      }
  }
  return(0);
}

How do close all ADD 4 SECONDS TO How to embed a

[Удален] 2008.06.23 14:39 #2

Ukt

Good points, well made

Nice bit of code too :)

Sadly my opinion to not use this approach - posted on a.n.other forum - seems not to have been of interest!

-BB-

New comment