Nmd

Hello,

I am new to MT4 and have tried to code an EA, it does not appear to work as I have coded it.  I think I have gotten most of it but am missing a few steps.

As this is also a learning experience I want the detailed logic as to how the proposed code is to operate. 

I want an EA to do the following -- the %b indicator, referenced below is defined in the test code attached. 

If the Bid price is above the 200 period (close) average

and

the %b indicator is less than 20% for five consecutive time periods

buy the next Bar at Ask (market) (there should only be 1 position taken at a time).

If in long position and the %b indicator is greater than 80% (only 1 period needed) then close (sell long) at Bid.

//+------------------------------------------------------------------+
//|                                                    ETF #2 %b.mq4 |
//|                                            Copyright © 2011, NMD |
//|                                                                  |
//+------------------------------------------------------------------+
#property copyright "Copyright © 2011, NMD"
#property link      ""

#include <stdlib.mqh>

//External Parameters
extern int MagicNumber = 123;
extern int MAPeriod = 200;
extern int    Bands_period = 20;
extern double Bands_deviation = 2;

//---- buffers
double PercentBB[];

//Global variables
int BuyTicket;


//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//----
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
{
if(Bars<200)
   {
   Alert("Not enough bars");
   return;
   }

   int    counted_bars = IndicatorCounted();
//----
   double LB, UB;
   int limit;
   
   if(counted_bars > 0) counted_bars--;
   limit = Bars - counted_bars - 1;
      
   for(int i = 0; i < limit; i++){
      LB = iBands(NULL, 0, Bands_period, Bands_deviation, 0, PRICE_CLOSE, MODE_LOWER, i);
      UB = iBands(NULL, 0, Bands_period, Bands_deviation, 0, PRICE_CLOSE, MODE_UPPER, i);

      if(UB-LB>0)
      { 
      PercentBB[i] = (iClose(NULL, 0, i) - LB)/(UB - LB) * 100;
      }
   }
//----

int c=0;
while(PercentBB[i]<10)
{
c++;
if(c==3)
break;
}

  
//Moving Averages
double SlowMA = iMA(NULL,0,MAPeriod,0,0,0,0);

// Buy Order
if(Bid>SlowMA && BuyTicket == 0 && c==3)
// Open buy order
   {
BuyTicket=OrderSend(Symbol(),OP_BUY,.01,Ask,5,0,0,"Buy Order",MagicNumber,0,Green);
   }
   
 //Order Close
 if(PercentBB[i]>80)
 {
 OrderSelect(BuyTicket,SELECT_BY_TICKET);
 }
 
 //Close order
 if(OrderCloseTime() == 0 && BuyTicket > 0)
 {
   double CloseLots = OrderLots();
   double ClosePrice = Bid;
   
   bool Closed = OrderClose(BuyTicket,.01,ClosePrice,5,Red);
 }
      
   
   return(0);
  }
//+------------------------------------------------------------------+