Discussing the article: "Example of new Indicator and Conditional LSTM" - page 2

New comment
 
Anil Varma #:

Hi Javier

Thanks for reply.

I found the problem. You have named "stock_prediction_model_MACD.onnx" in EA but zip files have it named as stock_prediction_model_MACD_Signal.onnx

I have also noticed inappropriate use of indicator handle (bug!!!) in the code. You have used 

In MQL5, indicator values are derived using CopyBuffer and indicator handle, which you have used in 

Can you please elaborate why handle was used differently with double variable to get the values in the first case?


Regards and have nice weekend.

Hi Anil

atr * _Point() to use the value directly. Print atr without the point and it will give weird values.

 
Anil Varma #:

Hi Javier

Thanks for reply.

I found the problem. You have named "stock_prediction_model_MACD.onnx" in EA but zip files have it named as stock_prediction_model_MACD_Signal.onnx

I have also noticed inappropriate use of indicator handle (bug!!!) in the code. You have used 

In MQL5, indicator values are derived using CopyBuffer and indicator handle, which you have used in 

Can you please elaborate why handle was used differently with double variable to get the values in the first case?


Regards and have nice weekend.

You are completely right! 

I made a mistake there, thanks for making that point.

You have to use copybuffer and handle. 

 

Hello Javier

Thanks for this great article, your bot uses are risk to reward ratio of 135:20  which makes it risky. when i try an appropriate ratio like 1:2 or 1:3 its a loosing bot .Any suggestions on how i can mke it better whith right risk to reward ratio

 
MuhireInnocent #:

Hello Javier

Thanks for this great article, your bot uses are risk to reward ratio of 135:20  which makes it risky. when i try an appropriate ratio like 1:2 or 1:3 its a loosing bot .Any suggestions on how i can mke it better whith right risk to reward ratio

Hi, I think I have not been too explicit and expressed that this example only serves as a way to show you can use LSTM with more than just OHLC. Simply don't use this example to trade.

 

Hi,Javier

how to make sure this param VAMTHRESH value is?

12
New comment