How can I solve 'OP_BUY' - undeclared identifier in MQL5?

New comment
 

Hi , I need help , I have this EA code: 

 #define MODE_LOWER 2
// Input parameters
input double lotSize = 0.1;
input int maPeriod = 50;
input double riskPercentage = 2.0;
input int rsiPeriod = 14;
input int macdPeriod = 12;
input int macdSignalPeriod = 9;
input int bollingerPeriod = 20;
input int bollingerDevFactor = 2;
input double maxRiskPerTrade = 1.0;
input double maxDrawdown = 10.0;
input int maxConsecutiveLosses = 3;
input int maxTradesPerDay = 5;
input double atrMultiplier = 2.0;
input double trailingStopMultiplier = 1.0;

// Global variables
double maValue;
double currentPrice;
double rsiValue;
double macdValue;
double bollingerUpper;
double bollingerLower;
double stopLossPrice;
double takeProfitPrice;
double riskPerLot;
int maxLots;

double trailingStopPrice;

int maHandle;
int rsiHandle;
int macdHandle;
int bollingerHandle;
int macdFastPeriod = 12; // Example value, replace with your desired fast EMA period
int macdSlowPeriod = 26; // You can assign any appropriate value based on your strategy

double accountBalance;
double riskAmount;
double atr;
double trailingStopDistance;

int consecutiveLosses = 0;
int tradesToday = 0;

bool modificationResult; // Declare the variable here


//+------------------------------------------------------------------+
//|                Expert initialization function                    |
//+------------------------------------------------------------------+
int OnInit()
{
    // Initialize moving average
    maHandle = iMA(_Symbol, 0, maPeriod, 0, MODE_SMA, PRICE_CLOSE);

    // Initialize RSI
    rsiHandle = iRSI(_Symbol, 0, rsiPeriod, PRICE_CLOSE);

    // Initialize MACD
    macdHandle = iMACD(_Symbol, 0, macdPeriod, macdSignalPeriod, 0, PRICE_CLOSE);

    // Initialize Bollinger Bands
    bollingerHandle = iCustom(_Symbol, 0, "BBANDS", bollingerPeriod, bollingerDevFactor, 0, 0);

    // Calculate risk amount
    riskAmount = AccountInfoDouble(ACCOUNT_BALANCE) * riskPercentage / 100.0;

    // Initialize global variables
    accountBalance = AccountInfoDouble(ACCOUNT_BALANCE);
    consecutiveLosses = 0;
    tradesToday = 0;

    return(INIT_SUCCEEDED);
}
//+------------------------------------------------------------------+
//| Expert deinitialization function                                 |
//+------------------------------------------------------------------+
void OnDeinit(const int reason)
  {
//---
   
  }
//+------------------------------------------------------------------+
//|                      Expert tick function                        |
//+------------------------------------------------------------------+


void OnTick()
{
    // Consolidate indicator calls
    static double prevMaValue = 0;
    static double prevCurrentPrice = 0;
    static double prevRsiValue = 0;
    static double prevMacdValue = 0;
    static double prevBollingerUpper = 0;
    static double prevBollingerLower = 0;

    if(!IsStopped())
    {
        if(prevMaValue == 0)
        {
            prevMaValue = iMA(_Symbol, 0, maPeriod, 0, MODE_SMA, PRICE_CLOSE);
        }
        if(prevCurrentPrice == 0)
        {
            prevCurrentPrice = SymbolInfoDouble(_Symbol, SYMBOL_BID);
        }
        if(prevRsiValue == 0)
        {
            prevRsiValue = iRSI(_Symbol, 0, rsiPeriod, PRICE_CLOSE);
        }
        if(prevMacdValue == 0)
        {
            prevMacdValue = iMACD(_Symbol, 0, macdPeriod, macdSignalPeriod, 0, PRICE_CLOSE);
        }
        if(prevBollingerUpper == 0)
        {
            prevBollingerUpper = iBands(_Symbol, 0, bollingerPeriod, 1, bollingerDevFactor, PRICE_CLOSE);
        }
        if(prevBollingerLower == 0)
        {
            prevBollingerLower = iBands(_Symbol, 0, bollingerPeriod, bollingerDevFactor, 2, PRICE_CLOSE);
        }

        maValue = iMA(_Symbol, 0, maPeriod, 0, MODE_SMA, PRICE_CLOSE);
        currentPrice = SymbolInfoDouble(_Symbol, SYMBOL_BID);
        rsiValue = iRSI(_Symbol, 0, rsiPeriod, PRICE_CLOSE);
        macdValue = iMACD(_Symbol, 0, macdFastPeriod, macdSlowPeriod, macdSignalPeriod, PRICE_CLOSE);

        double bollingerBands[];
        ArraySetAsSeries(bollingerBands,true);
        
        if(CopyBuffer(iBands(_Symbol, 0, bollingerPeriod, bollingerDevFactor, 0, PRICE_CLOSE), 1, 1, 3, bollingerBands) > 0)
        {
            bollingerUpper = bollingerBands[1];
            bollingerLower = bollingerBands[2];
        }

        prevMaValue = maValue;
        prevCurrentPrice = currentPrice;
        prevRsiValue = rsiValue;
        prevMacdValue = macdValue;
        prevBollingerUpper = bollingerUpper;
        prevBollingerLower = bollingerLower;
    }

    // Calculate ATR and trailing stop distance
    atr = iATR(_Symbol, 0 ,14);

    trailingStopDistance = atr * trailingStopMultiplier;

    // Check if maximum drawdown has been exceeded
    if((AccountInfoDouble(ACCOUNT_BALANCE) - accountBalance) / accountBalance * 100.0 < -maxDrawdown)
    {
        Print("Maximum drawdown exceeded. Trading halted.");
        return;
    }

    // Check if maximum consecutive losses has been reached
    if(consecutiveLosses >= maxConsecutiveLosses)
    {
        Print("Maximum consecutive losses reached. Trading halted.");
        return;
    }

    // Check if maximum trades per day has been reached
    if(tradesToday >= maxTradesPerDay)
    {
        Print("Maximum trades per day reached. Trading halted.");
        return;
    }

    // Refactor trade entry conditions
    bool isTrendConfirmed = ( (currentPrice > maValue) && (rsiValue < 30.0) && (macdValue > macdSignalPeriod) && ((bollingerUpper - bollingerLower) > (2.0 * Point)) );

    if(isTrendConfirmed)
    {
       // Calculate risk per lot and maximum lots
       riskPerLot = atr * atrMultiplier * lotSize;
       maxLots = (int)(riskAmount / riskPerLot);

       // Check if maximum risk per trade has been exceeded
       if((riskPerLot * lotSize / AccountInfoDouble(ACCOUNT_BALANCE) *100.0) > maxRiskPerTrade)
       {
           Print("Maximum risk per trade exceeded. Skipping trade.");
           return;
       }

       if(maxLots > 0)
       {
           // Calculate dynamic stop loss and take profit
           stopLossPrice = currentPrice - atr * atrMultiplier;
           takeProfitPrice = currentPrice + atr * atrMultiplier;

           // Calculate dynamic trailing stop loss
           trailingStopPrice = currentPrice - trailingStopDistance;

           // Open buy trade
           int ticket= OrderSend(_Symbol ,OP_BUY ,lotSize ,currentPrice ,3 ,stopLossPrice ,takeProfitPrice ,"Buy order" ,0 ,trailingStopPrice ,clrGreen );
           tradesToday++;

           if(ticket > 0)
           {
               // Streamline order modification
               double initialStopLoss= stopLossPrice ;
               while(OrderSelect(ticket ,SELECT_BY_TICKET ))
               {
                   double currentProfit = OrderGetDouble(ORDER_PROFIT);
                   double currentStopLoss= OrderStopLoss();

                   if(currentProfit > 0 && currentStopLoss < currentPrice - trailingStopDistance )
                   {
                       double newStopLoss= currentPrice - trailingStopDistance ;
                       if(OrderModify(ticket, OrderOpenPrice(), newStopLoss, takeProfitPrice, clrGreen))
                       {
                           initialStopLoss= newStopLoss ;
                           // The order modification was successful
                           // Add any necessary actions or logging here
                           Print("Order modification successful. Ticket: ", ticket );
                       }
                       else
                       {
                           // The order modification failed
                           // Add error handling or logging here
                           Print("Order modification failed. Ticket: ", ticket );
                       }
                   }
               }

               // Add a trend-following filter
               double dynamicTakeProfit= currentPrice + (atr * atrMultiplier *1.5 );
               if(OrderType() == OP_BUY && dynamicTakeProfit > OrderTakeProfit())
               {
                   if(OrderModify(OrderTicket() ,OP_BUY ,OrderOpenPrice() ,dynamicTakeProfit ,clrGreen ))
                   {
                       // The order modification was successful
                       // Add any necessary actions or logging here
                       Print("Order modification successful. Ticket: ", OrderTicket() );
                   }
                   else
                   {
                       // The order modification failed
                       // Add error handling or logging here
                       Print("Order modification failed. Ticket: ", OrderTicket() );
                   }
               }
           }
       }
   }
}
//+------------------------------------------------------------------+

double Ask = SymbolInfoDouble(_Symbol, SYMBOL_ASK);
int orderTicket = OrderSend(Symbol(), OP_BUY, 1.0, Ask, 3, 0, 0);

void OnTrade()
{
    // Check if trade was closed with a loss
    if (OrderSelect(orderTicket, SELECT_BY_TICKET))
    {
        if (OrderProfit() < 0)
        {
            consecutiveLosses++;
        }
        else
        {
            consecutiveLosses = 0;
        }

        // Calculate dynamic take profit based on ATR and current price movement
        double currentBidPrice = SymbolInfoDouble(_Symbol, SYMBOL_BID);
        double atrValue = iATR(_Symbol, 0, 14);
        double tempTakeProfitPrice = currentBidPrice + atrValue * atrMultiplier * 1.5;

        if (modificationResult)
        {
            Print("Order modification successful. Ticket: ", orderTicket);
        }
        else
        {
            Print("Order modification failed. Ticket: ", orderTicket);
        }
    }
}

void OnTimer()
{
   // Reset trades today counter at midnight
   if(TimeHour(TimeCurrent()) == 0 && TimeMinute(TimeCurrent()) == 0)
   {
      tradesToday = 0;

   }

when I execute this code, I got this error: 'OP_BUY' - undeclared identifier EA2.mq5 261 39 , in this line: int orderTicket = OrderSend(Symbol(), OP_BUY, 1.0, Ask, 3, 0, 0); , I don't know how should I solve this error, would you please help me if possible?


  
#define OP_BUY 0

That's not your only problem to be solved. 

  
  1.     accountBalance = AccountInfoDouble(ACCOUNT_BALANCE);
    Don't try to use any price (or indicator) or server related functions in OnInit (or on load or in OnTimer before you've received a tick), as there may be no connection/chart yet:
    1. Terminal starts.
    2. Indicators/EAs are loaded. Static and globally declared variables are initialized. (Do not depend on a specific order.)
    3. OnInit is called.
    4. For indicators OnCalculate is called with any existing history.
    5. Human may have to enter password, connection to server begins.
    6. New history is received, OnCalculate called again.
    7. A new tick is received, OnCalculate/OnTick is called. Now TickValue, TimeCurrent, account information and prices are valid. 

  2.         if(prevMaValue == 0)
        {
            prevMaValue = iMA(_Symbol, 0, maPeriod, 0, MODE_SMA, PRICE_CLOSE);

    Perhaps you should read the manual, especially the examples.
       How To Ask Questions The Smart Way. (2004)
          How To Interpret Answers.
             RTFM and STFW: How To Tell You've Seriously Screwed Up.

    They all (including iCustom) return a handle (an int). You get that in OnInit. In OnTick/OnCalculate (after the indicator has updated its buffers), you use the handle, shift and count to get the data.
              Technical Indicators - Reference on algorithmic/automated trading language for MetaTrader 5
              Timeseries and Indicators Access / CopyBuffer - Reference on algorithmic/automated trading language for MetaTrader 5
              How to start with MQL5 - General - MQL5 programming forum - Page 3 #22 (2020)
              How to start with MQL5 - MetaTrader 5 - General - MQL5 programming forum - Page 7 #61 (2020)
              MQL5 for Newbies: Guide to Using Technical Indicators in Expert Advisors - MQL5 Articles (2010)
              How to call indicators in MQL5 - MQL5 Articles (2010)

  3.           stopLossPrice = currentPrice - atr * atrMultiplier;
           takeProfitPrice = currentPrice + atr * atrMultiplier;

    You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit by the Ask.

    1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?

    2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close at a specific Bid price, add the average spread.
                MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25

    3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)

      Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes.
      My GBPJPY shows average spread = 26 points, average maximum spread = 134.
      My EURCHF shows average spread = 18 points, average maximum spread = 106.
      (your broker will be similar).
                Is it reasonable to have such a huge spreads (20 PIP spreads) in EURCHF? - General - MQL5 programming forum (2022)

  4. int ticket= OrderSend(_Symbol ,OP_BUY ,lotSize ,currentPrice ,3 ,stopLossPrice ,takeProfitPrice ,"Buy order" ,0 ,trailingStopPrice ,clrGreen );
    This is the MT4 command. Totally incompatible with MT5.
 
محمد دهقانی:

Hi , I need help , I have this EA code: 


when I execute this code, I got this error: 'OP_BUY' - undeclared identifier EA2.mq5 261 39 , in this line: int orderTicket = OrderSend(Symbol(), OP_BUY, 1.0, Ask, 3, 0, 0); , I don't know how should I solve this error, would you please help me if possible?


Dont use generators or Chat GPT to help you. The OP_BUY  is not a MT5 command. You can always look at the MQL5 reference manual, there you will find everything you need to know. But asking AI to help you will not solve the problem

Here is a link to a PDF that you can use, it explains in great detail how to get started and i have added a link to MQL5 reference as well.

[PDF] Expert Advisor Programming for Metatrader 5 Copy - Free Download (epdfx.com)

MQL5 Reference – How to use algorithmic/automated trading language for MetaTrader 5

[PDF] Expert Advisor Programming for Metatrader 5 Copy - Free Download
[PDF] Expert Advisor Programming for Metatrader 5 Copy - Free Download
  • epdfx.com
Download Expert Advisor Programming for Metatrader 5 Copy
New comment