Help with calculating right lot size based on ticks of stoploss

 
//Inputs
input double riskPercentage = 10; // Risk % of account balance per trade
input int TPandSLpointsFixed = 200; //Fixed SL and TP points at open of the trade
input int TrailingPoints = 50; // Trailing stop points
////////////////////////////////////////////////////
void OnTick()
{
      //Get ask price
      double Ask = NormalizeDouble(SymbolInfoDouble(_Symbol, SYMBOL_ASK), Digits());
      //Get bid price
      double Bid = NormalizeDouble(SymbolInfoDouble(_Symbol, SYMBOL_BID), Digits());
     //Risk per trade calculation
      double AccountBalance = AccountInfoDouble(ACCOUNT_BALANCE);
      double TickSize = SymbolInfoDouble(_Symbol, SYMBOL_TRADE_TICK_SIZE);
      double TickValue = SymbolInfoDouble(_Symbol, SYMBOL_TRADE_TICK_VALUE);
      double LotStep = SymbolInfoDouble(_Symbol, SYMBOL_VOLUME_STEP);
      double ticksup = NormalizeDouble(Ask - (Ask - TPandSLpointsFixed * TickSize),Digits());
      double ticksdown = NormalizeDouble(((Bid + TPandSLpointsFixed * TickSize) - Bid),Digits());
      ////////////////////////////////////
      double riskpertrade = AccountBalance * riskPercentage / 100;
      double lotup0 = ticksup * TickValue * LotStep;
      double lotdown0 = ticksdown  * TickValue * LotStep;
      double lotup1 = (riskpertrade/lotup0/);
      double lotdown1 = (riskpertrade / lotdown0);

Hello, I have problem with this code, your help would be appraciated. 


I need to calculate lot size based on % risk from account balance, also this value is calculated from points of sl (inputs section). Right now lotup1 is showing me 0.0 result


Thanks

 

Risk depends on your initial stop loss, lot size, and the value of the symbol. It does not depend on margin and leverage. No SL means you have infinite risk (on leveraged symbols). Never risk more than a small percentage of your trading funds, certainly less than 2% per trade, 6% total.

  1. You place the stop where it needs to be — where the reason for the trade is no longer valid. E.g. trading a support bounce, the stop goes below the support.

  2. AccountBalance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the spread, and DeltaPerLot is usually around $10/PIP, but it takes account of the exchange rates of the pair vs. your account currency.)

  3. Do NOT use TickValue by itself - DeltaPerLot and verify that MODE_TICKVALUE is returning a value in your deposit currency, as promised by the documentation, or whether it is returning a value in the instrument's base currency.
              MODE_TICKVALUE is not reliable on non-fx instruments with many brokers - MQL4 programming forum (2017)
              Is there an universal solution for Tick value? - Currency Pairs - General - MQL5 programming forum (2018)
              Lot value calculation off by a factor of 100 - MQL5 programming forum (2019)

  4. You must normalize lots properly and check against min and max.

  5. You must also check Free Margin to avoid stop out

  6. For MT5, see 'Money Fixed Risk' - MQL5 Code Base (2017)

Most pairs are worth about $10 per PIP. A $5 risk with a (very small) 5 PIP SL is $5/$10/5 or 0.1 Lots maximum.

 
William Roeder #:

Risk depends on your initial stop loss, lot size, and the value of the symbol. It does not depend on margin and leverage. No SL means you have infinite risk (on leveraged symbols). Never risk more than a small percentage of your trading funds, certainly less than 2% per trade, 6% total.

  1. You place the stop where it needs to be — where the reason for the trade is no longer valid. E.g. trading a support bounce, the stop goes below the support.

  2. AccountBalance * percent/100 = RISK = OrderLots * (|OrderOpenPrice - OrderStopLoss| * DeltaPerLot + CommissionPerLot) (Note OOP-OSL includes the spread, and DeltaPerLot is usually around $10/PIP, but it takes account of the exchange rates of the pair vs. your account currency.)

  3. Do NOT use TickValue by itself - DeltaPerLot and verify that MODE_TICKVALUE is returning a value in your deposit currency, as promised by the documentation, or whether it is returning a value in the instrument's base currency.
              MODE_TICKVALUE is not reliable on non-fx instruments with many brokers - MQL4 programming forum (2017)
              Is there an universal solution for Tick value? - Currency Pairs - General - MQL5 programming forum (2018)
              Lot value calculation off by a factor of 100 - MQL5 programming forum (2019)

  4. You must normalize lots properly and check against min and max.

  5. You must also check Free Margin to avoid stop out

  6. For MT5, see 'Money Fixed Risk' - MQL5 Code Base (2017)

Most pairs are worth about $10 per PIP. A $5 risk with a (very small) 5 PIP SL is $5/$10/5 or 0.1 Lots maximum.

I am begginer, could you please help me with the code in Private Message? Thanks
Reason: