6 errors on a Expert Advisor, what's wrong with this code?

Guigo - 2023.02.11 17:48

#include <Trade/Trade.mqh>

input double Lots = 0.01;
input double LotFactor = 2;
input int TpPoints = 100;
input int SlPoints = 100;
input int Magic = 111;

CTrade trade;
bool isTradeAllowed = true;

int OnInit(){

   trade.SetExpertMagicNumber(Magic);
   
   return(INIT_SUCCEEDED);
}

void OnDeinit(const int reason){

}

void OnTick(){

   if(isTradeAllowed){
      double ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK);
      double tp = ask + TpPoints * _Point;
      double sl = ask - SlPoints * _Point;
      
      ask = NormalizeDouble(ask,_Digits);
      tp = NormalizeDouble(tp,_Digits);
      sl = NormalizeDouble(sl,_Digits);
      
      if(trade.Buy(Lots,_Symbol,ask,sl,tp)){
         isTradeAllowed = false;
      }
   }
}

void OnTradeTransaction (
   const MqlTradeTransaction& trans, // trade transaction structure
   const MqlTradeRequest& request, // request structure
   const MqlTradeResult& result,
   ){
   
   if(trans.type == TRADE_TRANSACTION_DEAL_ADD){
      CDealInfo deal;
      deal.Ticket(trans.deal);
      HistorySelect(TimeCurrent()-PeriodSeconds(PERIOD_D1),TimeCurrent()+10);
      
      if(deal.Magic() == Magic && deal.Symbol() == _Symbol){
         if(deal.Entry() == DEAL_ENTRY_OUT){
            Print(__FUNCTION__," > Closed pos #",trans.position);
            if(deal.Profit() > 0){
               isTradeAllowed = true;
            }else{
               if(deal.DealType() == DEAL_TYPE_BUY){
                  double lots = deal.Volume() * LotFactor;
                  lots = NormalizeDouble(lots,2);
                  
                  double ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK);
                  double tp = ask + TpPoints * _Point;
                  double sl = ask - SlPoints * _Point;
                  
                  ask = NormalizeDouble(ask,_Digits);
                  tp = NormalizeDouble(tp,_Digits);
                  sl = NormalizeDouble(sl,_Digits);
                  
                  trade.Buy(lots,_Symbol,ask,sl,tp);
               }else if(deal.DealType() == DEAL_TYPE_SELL){
                  double lots = deal.Volume() * LotFactor;
                  lots = NormalizeDouble(Lots,2);
                  
                  double bid = SymbolInfoDouble(_Symbol,SYMBOL_BID);
                  double tp = bid - TpPoints * _Point;
                  double sl = bid + SlPoints * _Point;
                  
                  bid = NormalizeDouble(bid,_Digits);
                  tp = NormalizeDouble(tp,_Digits);
                  sl = NormalizeDouble(sl,_Digits);}
                  
                  trade.Sell(lots,_Symbol,bid,sl,tp);
               }
            }               
         }               
      }               
   }              
}

Files:

Captura_de_pantalla_2023-02-11_a_las_19.10.06.png 39 kb

Fernando Carreiro 2023.02.11 17:57 #1

Please edit your post (don't create a new post) and replace your code properly (with "</>" or Alt-S), or attach the original file directly with the "+ Attach file" button below the text box.

NB! Very important! DO NOT create a new post. EDIT your original post.

A zigzag that creates Please Help Error code can sombody correct for

Fernando Carreiro 2023.02.11 17:59 #2

Also, show the errors you are getting, and explain what is you expect it to do.

Guigo - 2023.02.11 18:11 #3

Fernando Carreiro #:

Please edit your post (don't create a new post) and replace your code properly (with "</>" or Alt-S), or attach the original file directly with the "+ Attach file" button below the text box.

NB! Very important! DO NOT create a new post. EDIT your original post.

just updated ! thank you

William Roeder 2023.02.11 18:29 #4

```
      double tp = ask + TpPoints * _Point;
      double sl = ask - SlPoints * _Point;
```
You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit by the Ask.
1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?
2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close at a specific Bid price, add the average spread.
  MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25
3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)
  
  Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes.
  My GBPJPY shows average spread = 26 points, average maximum spread = 134.
  My EURCHF shows average spread = 18 points, average maximum spread = 106.
  (your broker will be similar).
  Is it reasonable to have such a huge spreads (20 PIP spreads) in EURCHF? - General - MQL5 programming forum (2022)
```
                  ask = NormalizeDouble(ask,_Digits);
                  tp = NormalizeDouble(tp,_Digits);
                  sl = NormalizeDouble(sl,_Digits);
```
You used NormalizeDouble, It's use is usually wrong, as it is in your case.
1. Floating point has a infinite number of decimals, it's your not understanding floating point and that some numbers can't be represented exactly. (like 1/10.)
  Double-precision floating-point format - Wikipedia, the free encyclopedia
  
  See also The == operand. - MQL4 programming forum (2013)
2. Print out your values to the precision you want with DoubleToString - Conversion Functions - MQL4 Reference.
3. SL/TP (stops) need to be normalized to tick size (not Point) — code fails on non-currencies.
  On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 programming forum (2011)
  
  And abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 programming forum (2012)
4. Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on non-currencies. So do it right.
  Trailing Bar Entry EA - MQL4 programming forum (2013)
  Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 programming forum (2012)
5. Lot size must also be adjusted to a multiple of LotStep and check against min and max. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.
  (MT4 2013)) (MT5 2022))
6. MathRound() and NormalizeDouble() are rounding in a different way. Make it explicit.
  MT4:NormalizeDouble - MQL5 programming forum (2017)
  How to Normalize - Expert Advisors and Automated Trading - MQL5 programming forum (2017)
7. Prices you get from the terminal are already correct (normalized).
8. PIP, Point, or Tick are all different in general.
  What is a TICK? - MQL4 programming forum (2014)

Double value doesn't show PositionModify, new stop loss Problem with retrieving points

Guigo - 2023.02.11 18:33 #5

William Roeder #:

You buy at the Ask and sell at the Bid. Pending Buy Stop orders become market orders when hit by the Ask.
1. Your buy order's TP/SL (or Sell Stop's/Sell Limit's entry) are triggered when the Bid / OrderClosePrice reaches it. Using Ask±n, makes your SL shorter and your TP longer, by the spread. Don't you want the specified amount used in either direction?
2. Your sell order's TP/SL (or Buy Stop's/Buy Limit's entry) will be triggered when the Ask / OrderClosePrice reaches it. To trigger close at a specific Bid price, add the average spread.
  MODE_SPREAD (Paul) - MQL4 programming forum - Page 3 #25
3. The charts show Bid prices only. Turn on the Ask line to see how big the spread is (Tools → Options (control+O) → charts → Show ask line.)
  
  Most brokers with variable spreads widen considerably at end of day (5 PM ET) ± 30 minutes.
  My GBPJPY shows average spread = 26 points, average maximum spread = 134.
  My EURCHF shows average spread = 18 points, average maximum spread = 106.
  (your broker will be similar).
  Is it reasonable to have such a huge spreads (20 PIP spreads) in EURCHF? - General - MQL5 programming forum (2022)
You used NormalizeDouble, It's use is usually wrong, as it is in your case.
1. Floating point has a infinite number of decimals, it's your not understanding floating point and that some numbers can't be represented exactly. (like 1/10.)
  Double-precision floating-point format - Wikipedia, the free encyclopedia
  
  See also The == operand. - MQL4 programming forum (2013)
2. Print out your values to the precision you want with DoubleToString - Conversion Functions - MQL4 Reference.
3. SL/TP (stops) need to be normalized to tick size (not Point) — code fails on non-currencies.
  On 5Digit Broker Stops are only allowed to be placed on full pip values. How to find out in mql? - MQL4 programming forum (2011)
  
  And abide by the limits Requirements and Limitations in Making Trades - Appendixes - MQL4 Tutorial and that requires understanding floating point equality Can price != price ? - MQL4 programming forum (2012)
4. Open price for pending orders need to be adjusted. On Currencies, Point == TickSize, so you will get the same answer, but it won't work on non-currencies. So do it right.
  Trailing Bar Entry EA - MQL4 programming forum (2013)
  Bid/Ask: (No Need) to use NormalizeDouble in OrderSend - MQL4 programming forum (2012)
5. Lot size must also be adjusted to a multiple of LotStep and check against min and max. If that is not a power of 1/10 then NormalizeDouble is wrong. Do it right.
  (MT4 2013)) (MT5 2022))
6. MathRound() and NormalizeDouble() are rounding in a different way. Make it explicit.
  MT4:NormalizeDouble - MQL5 programming forum (2017)
  How to Normalize - Expert Advisors and Automated Trading - MQL5 programming forum (2017)
7. Prices you get from the terminal are already correct (normalized).
8. PIP, Point, or Tick are all different in general.
  What is a TICK? - MQL4 programming forum (2014)

thank you !!! will check

Alain Verleyen 2023.02.11 18:43 #6

Guigo -:

#include <Trade/Trade.mqh>

input double Lots = 0.01;
input double LotFactor = 2;
input int TpPoints = 100;
input int SlPoints = 100;
input int Magic = 111;

CTrade trade;
bool isTradeAllowed = true;

int OnInit(){

   trade.SetExpertMagicNumber(Magic);
   
   return(INIT_SUCCEEDED);
}

void OnDeinit(const int reason){

}

void OnTick(){

   if(isTradeAllowed){
      double ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK);
      double tp = ask + TpPoints * _Point;
      double sl = ask - SlPoints * _Point;
      
      ask = NormalizeDouble(ask,_Digits);
      tp = NormalizeDouble(tp,_Digits);
      sl = NormalizeDouble(sl,_Digits);
      
      if(trade.Buy(Lots,_Symbol,ask,sl,tp)){
         isTradeAllowed = false;
      }
   }
}

void OnTradeTransaction (
   const MqlTradeTransaction& trans, // trade transaction structure
   const MqlTradeRequest& request, // request structure
   const MqlTradeResult& result,  
   ){
   
   if(trans.type == TRADE_TRANSACTION_DEAL_ADD){
      CDealInfo deal;
      deal.Ticket(trans.deal);
      HistorySelect(TimeCurrent()-PeriodSeconds(PERIOD_D1),TimeCurrent()+10);
      
      if(deal.Magic() == Magic && deal.Symbol() == _Symbol){
         if(deal.Entry() == DEAL_ENTRY_OUT){
            Print(__FUNCTION__," > Closed pos #",trans.position);
            if(deal.Profit() > 0){
               isTradeAllowed = true;
            }else{
               if(deal.DealType() == DEAL_TYPE_BUY){
                  double lots = deal.Volume() * LotFactor;
                  lots = NormalizeDouble(lots,2);
                  
                  double ask = SymbolInfoDouble(_Symbol,SYMBOL_ASK);
                  double tp = ask + TpPoints * _Point;
                  double sl = ask - SlPoints * _Point;
                  
                  ask = NormalizeDouble(ask,_Digits);
                  tp = NormalizeDouble(tp,_Digits);
                  sl = NormalizeDouble(sl,_Digits);
                  
                  trade.Buy(lots,_Symbol,ask,sl,tp);
               }else if(deal.DealType() == DEAL_TYPE_SELL){
                  double lots = deal.Volume() * LotFactor;
                  lots = NormalizeDouble(Lots,2);
                  
                  double bid = SymbolInfoDouble(_Symbol,SYMBOL_BID);
                  double tp = bid - TpPoints * _Point;
                  double sl = bid + SlPoints * _Point;
                  
                  bid = NormalizeDouble(bid,_Digits);
                  tp = NormalizeDouble(tp,_Digits);
                  sl = NormalizeDouble(sl,_Digits);}
                  
                  trade.Sell(lots,_Symbol,bid,sl,tp);  lots,bid,sl,tp are unknown here as they are declared inside the previous {} local scope
               }
            }               
         }               
      }               
   }              
}

Guigo - 2023.02.11 19:05 #7

Alain Verleyen #:

WOW! two clicks and fixed it, thank you very much!

New comment