Checking all running positions and move the SL to breakeven when critera are met

[Marbo]

Hello guys,

can you help me with this problem? I always receive an invalid request (error 4756 invalid stops) when the SL should be moved to breakeven. But in the log file I can see that the SL is correct.

//+------------------------------------------------------------------+
//| Expert tick function                                             |
//+------------------------------------------------------------------+
void OnTick() {
   if (PositionsTotal()>0) {
      MqlTradeRequest   m_request;              // request data
      MqlTradeResult    m_result;               // result data
      for (int i=0;i<PositionsTotal();i++) {
         if (PositionGetSymbol(i)!="") {
            string symbol=PositionGetString(POSITION_SYMBOL);
            ulong ticket=PositionGetInteger(POSITION_TICKET);
            double op=PositionGetDouble(POSITION_PRICE_OPEN);
            double sl=PositionGetDouble(POSITION_SL);
            double tp=PositionGetDouble(POSITION_TP);
            long type=PositionGetInteger(POSITION_TYPE);
            if (type==POSITION_TYPE_BUY) {
               if (sl<op) {
                  if (SymbolInfoDouble(symbol,SYMBOL_BID)>op+(op-sl)) {
                     m_request.action  =TRADE_ACTION_SLTP;
                     m_request.position=ticket;
                     m_request.symbol  =symbol;
                     m_request.sl      =op;
                     m_request.tp      =tp;
                     OrderSend(m_request,m_result);
                  }
               }
            }
            else if (type==POSITION_TYPE_SELL) {
               if (sl>op) {
                  if (SymbolInfoDouble(symbol,SYMBOL_ASK)<op-(sl-op)) {
                     m_request.action  =TRADE_ACTION_SLTP;
                     m_request.position=ticket;
                     m_request.symbol  =symbol;
                     m_request.sl      =op;
                     m_request.tp      =tp;
                     OrderSend(m_request,m_result);
                  }
               }
            }
         }
      }
   }
}

[Marbo]

Marbo:

Hello guys,

can you help me with this problem? I always receive an invalid request (error 4756 invalid stops) when the SL should be moved to breakeven. But in the log file I can see that the SL is correct.

No idea? :(

[Carl Schreiber]

Marbo #:

No idea? :(

Learn how to track possible errors!

Check the return code, print the relevant variables like SL, TP, ask and bid ...

Learn to use the debugger: https://www.mql5.com/en/articles/654.

[Marbo]

Carl Schreiber #:

Learn how to track possible errors!

Check the return code, print the relevant variables like SL, TP, ask and bid ...

Learn to use the debugger: https://www.mql5.com/en/articles/654.

Thanks for your advice!

My problem is that I am not sure about the code itself. The trade management is so different from MQL4 (positions, deals...) and I didn't find any code which modifies a stoploss in a running trade which I could learn from.

[Fernando Carreiro]

Marbo: can you help me with this problem? I always receive an invalid request (error 4756 invalid stops) when the SL should be moved to breakeven. But in the log file I can see that the SL is correct.

Your code shows no signs of you checking for Stops Level. Always check the broker's contract specifications, like the Stops Levels and Freeze Levels.

Also your logic seems strange ...

bid > op + ( op - sl ) ... is equivalent to ... bid > 2 * op - sl

ask < op - ( sl - op ) ... is equivalent to ... ask < 2 * op - sl

[Enrique Dangeroux]

Marbo #:

Thanks for your advice!

My problem is that I am not sure about the code itself. The trade management is so different from MQL4 (positions, deals...) and I didn't find any code which modifies a stoploss in a running trade which I could learn from.

Then use MT4 style for MT5 https://www.mql5.com/ru/code/16006

[Carl Schreiber]

Check the articles of Enrico Lambino: https://www.mql5.com/en/users/iceron/publications

[Marbo]

@all thanks for your help!

FYI: I just needed to add the magic number as a parameter and then my code worked. I didn't know that this magic number is needed.