OrderModify changes to many orders

Mathias Halen 2021.05.28 22:48

So I have this EA that reads from a txt file and takes the info from that checks if its a AdjustTradeOrder or NewTrade or CloseTrade.

NewTrade works as it should but my AdjustTradeOrder sometimes changes all open orders but I'm using a check system to check if the myTradeID is the same as on the open order and only then should it modify the order.
The code is here below.

What do I do wrong here?

//+------------------------------------------------------------------+
//+------------------------------------------------------------------+
void AdjustTradeOrder(string myType,string mySymbole,string myTradeID,int myPosition,double myEntry,double myStopLoss,double myTakeProfit)
  {

   if(commentOnOpenOrders(myTradeID) && !commentOnOpenHistory(myTradeID))
     {
      //--- get minimum stop level
      double minstoplevel=MarketInfo(mySymbole,MODE_STOPLEVEL);
      double price=MarketInfo(mySymbole,MODE_ASK); ;
      double minilot = MarketInfo(mySymbole,MODE_MINLOT);

      color orderColor;
      if(myPosition==0)
        {
         orderColor = clrGreen;
        }
      else
        {
         orderColor = clrRed;
        }

      //+------------------------------------------------------------------+
      int PositionIndex;    //  <-- this variable is the index used for the loop
      int TotalNumberOfOrders;   //  <-- this variable will hold the number of orders currently in the Trade pool
      TotalNumberOfOrders = OrdersTotal();    // <-- we store the number of Orders in the variable

      for(PositionIndex = TotalNumberOfOrders - 1; PositionIndex >= 0 ; PositionIndex --)  //  <-- for loop to loop through all Orders . .   COUNT DOWN TO ZERO !
        {
         //Print("----------> AdjustTradeOrder       Part 3");
         if(! OrderSelect(PositionIndex, SELECT_BY_POS, MODE_TRADES))
            continue;   // <-- if the OrderSelect fails advance the loop to the next PositionIndex
         if(OrderComment() == myTradeID)

            Print(myEntry + " ;" + myTakeProfit + " ;" + myTakeProfit);
         if(myEntry==0 && myTakeProfit==0 && myStopLoss>0)
            // MODIFT ONLY SL
           {
            Print("-----> ONLY SL");
            if(! OrderModify(OrderTicket(), OrderOpenPrice(), NormalizeDouble(myStopLoss,Digits),OrderTakeProfit(),0,orderColor))
               Print("[ONLY SL] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
            else
               Print("[ONLY SL] - OrderSend placed successfully");
            deleteFile_AdjustTrade(fileName_Adjusted);

           }
         else
            if(myEntry>0 && myTakeProfit==0 && myStopLoss>0)
               // MODIFT ENTY & SL
              {
               Print("-----> MODIFT ENTY & SL");
               if(! OrderModify(OrderTicket(), NormalizeDouble(myEntry,Digits), NormalizeDouble(myStopLoss,Digits),OrderTakeProfit(),0,orderColor))
                  Print("[MODIFT ENTY & SL] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
               else
                  Print("[MODIFT ENTY & SL] - OrderSend placed successfully");
               deleteFile_AdjustTrade(fileName_Adjusted);
              }
            else
               if(myEntry>0 && myTakeProfit==0 && myStopLoss==0)
                  // MODIFT ONLY ENTY
                 {
                  Print("-----> MODIFT ONLY ENTY");
                  if(! OrderModify(OrderTicket(), NormalizeDouble(myEntry,Digits), OrderStopLoss(),OrderTakeProfit(),0,orderColor))
                     Print("[MODIFT ONLY ENTY] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
                  else
                     Print("[MODIFT ONLY ENTY] - OrderSend placed successfully");
                  deleteFile_AdjustTrade(fileName_Adjusted);
                 }
               else
                  if(myEntry>0 && myTakeProfit>0 && myStopLoss==0)
                     // MODIFT ENTY & TP
                    {
                     Print("-----> MODIFT ENTY & TP");
                     if(! OrderModify(OrderTicket(), NormalizeDouble(myEntry,Digits), OrderStopLoss(),NormalizeDouble(myTakeProfit,Digits),0,orderColor))
                        Print("[MODIFT ENTY & TP] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
                     else
                        Print("[MODIFT ENTY & TP] - OrderSend placed successfully");
                     deleteFile_AdjustTrade(fileName_Adjusted);
                    }
                  else
                     if(myEntry==0 && myTakeProfit>0 && myStopLoss==0)
                        // MODIFT ONLY TP
                       {
                        Print("-----> ONLY Modify TAKEPROFIT");
                        if(! OrderModify(OrderTicket(), OrderOpenPrice(), OrderStopLoss(),NormalizeDouble(myTakeProfit,Digits),0,orderColor))
                           Print("[ONLY Modify TAKEPROFIT] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
                        else
                           Print("[ONLY Modify TAKEPROFIT] - OrderSend placed successfully");
                        deleteFile_AdjustTrade(fileName_Adjusted);
                       }
                     else
                        if(myEntry>0 && myTakeProfit>0 && myStopLoss>0)
                           // MODIFT ALL
                          {
                           Print("-----> MODIFT ALL");
                           if(! OrderModify(OrderTicket(), NormalizeDouble(myEntry,Digits), NormalizeDouble(myStopLoss,Digits),NormalizeDouble(myTakeProfit,Digits),0,orderColor))
                              Print("[MODIFT AL] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
                           else
                              Print("[MODIFT AL] - OrderSend placed successfully");
                           deleteFile_AdjustTrade(fileName_Adjusted);
                          }
         if(myEntry==0 && myTakeProfit>0 && myStopLoss>0)
            // MODIFT SL & TP
           {
            Print("-----> MODIFT SL & TP");
            if(! OrderModify(OrderTicket(),OrderOpenPrice(), NormalizeDouble(myStopLoss,Digits),NormalizeDouble(myTakeProfit,Digits),0,orderColor))
               Print("[MODIFT SL & TP] - Order OrderModify failed, order number: ", OrderTicket(), " Error: ", GetLastError());
            else
               Print("[MODIFT SL & TP] - OrderSend placed successfully");
            deleteFile_AdjustTrade(fileName_Adjusted);
           }
         else
           {
            Print("-----> Don't Know What whent wrong.");
            Print(
               "myType = "+myType   + ";"+
               "mySymbole = "+mySymbole   + ";"+
               "myTradeID = "+myTradeID   + ";"+
               "myPosition = "+IntegerToString(myPosition)   + ";"+
               "myEntry = "+DoubleToStr(myEntry)   + ";"+
               "myStopLoss = "+DoubleToStr(myStopLoss)   + ";"+
               "myTakeProfit = "+DoubleToStr(myTakeProfit)
            );
           }
        }
      //+------------------------------------------------------------------+
     }
   else
     {
      //Print("TradeID Already exists = "+myTradeID);
     }
  }

//+------------------------------------------------------------------+
//+------------------------------------------------------------------+