Hi Can anyone help me in converting custom indicator code to export advisor

New comment
 

Hello All,

I am new to MQL,

Can anyone help me in converting following custom code to export advisor.

It would help me lot.

//+------------------------------------------------------------------+

//|Vortex Indicator.mq4                                              |

//|From the January 2010 issue of Technical Analysis of Stocks &     |

//|Commodities                                                       |

//+------------------------------------------------------------------+

#property  copyright "Copyright 2009 under Creative Commons BY-SA License by Neil D. Rosenthal"

#property  link      "http://creativecommons.org/licenses/by-sa/3.0/"


#property indicator_separate_window

#property indicator_buffers 2

#property indicator_color1 Green

#property indicator_color2 Red


//---- Input parameters

extern int VI_Length=14;


//---- Buffers

double PlusVI[];        //VI+ : + Vortex Indicator buffer

double MinusVI[];       //VI- : - Vortex Indicator buffer

double PlusVM[];        //VM+ : + Vortex Movement buffer

double MinusVM[];       //VM- : - Vorext Movement buffer

double SumPlusVM[];     //Sum of VI_Length PlusVM values

double SumMinusVM[];    //Sum of VI_Length MinusVM values

double SumTR[];         //True Range buffer


//+------------------------------------------------------------------+

//| Custom indicator initialization function                         |

//+------------------------------------------------------------------+

int init()

  {

//----

   IndicatorBuffers(7);

   IndicatorDigits(Digits);

//---- Set visible buffer properties

   SetIndexBuffer(0,PlusVI);

   SetIndexBuffer(1,MinusVI);

   SetIndexStyle(0,DRAW_LINE);

   SetIndexStyle(1,DRAW_LINE);

   SetIndexLabel(0,"PlusVI(" + VI_Length + ")");

   SetIndexLabel(1,"MinusVI(" + VI_Length + ")");

   SetIndexDrawBegin(0,VI_Length);

   SetIndexDrawBegin(1,VI_Length);

//---- Set indices of caching buffers

   SetIndexBuffer(2,PlusVM);

   SetIndexBuffer(3,MinusVM);

   SetIndexBuffer(4,SumPlusVM);

   SetIndexBuffer(5,SumMinusVM);

   SetIndexBuffer(6,SumTR);

   EventSetTimer(40);

   startIndex=0;

   result=0;

//----

   return(0);

  }

//+------------------------------------------------------------------+

//| Custom indicator deinitialization function                       |

//+------------------------------------------------------------------+

int deinit()

  {

//----


//----

   return(0);

  }

//+------------------------------------------------------------------+

//| Custom indicator iteration function                              |

//+------------------------------------------------------------------+

int startIndex;

int result;

//+------------------------------------------------------------------+

//|                                                                  |

//+------------------------------------------------------------------+

void OnTimer()

  {

//---

   if(startIndex!=0)

     {

      startIndex=startIndex-1;

     }

  }


//+------------------------------------------------------------------+

//|                                                                  |

//+------------------------------------------------------------------+

int start()

  {

   int counted_bars = IndicatorCounted();

//Alert(counted_bars + " " + (Bars-1));


//Alert("Bars 1 J 1 " + Bars + " iBars " +iBars("AXISBANK#",5), " Indi Count "+counted_bars);


   if(counted_bars < 0)

      return(-1);

   if(counted_bars > 0)

      counted_bars--;

   int Limit = Bars - counted_bars;

//Alert(Limit);

   if(counted_bars==0)

      Limit-=1+VI_Length;


   result=0;


//Alert("Bars 2 K 2 " + Bars + " iBars " +iBars("AXISBANK#",5), " Indi Count "+IndicatorCounted() + " Limit " + Limit);

//---- Clear caching buffers

   for(int i = 1; i < Limit; i++)

     {

      SumPlusVM[i] = 0;

      SumMinusVM[i] = 0;

      SumTR[i]= 0;

     }

//---- Store the values of PlusVM and MinusVM

   for(i = 1; i < Limit; i++)

     {

      //PlusVM = |Today's High - Yesterday's Low|

      PlusVM[i] = MathAbs(High[i] - Low[i + 1]);

      //MinusVM = |Today's Low - Yesterday's High|

      MinusVM[i] = MathAbs(Low[i] - High[i +1]);

     }

//---- Sum VI_Length values of PlusVM, MinusVM and the True Range

   for(i = 1; i < Limit; i++)

     {

      for(int j = 1; j <= VI_Length - 1; j++)

        {

         SumPlusVM[i] += PlusVM[i + j];

         SumMinusVM[i] += MinusVM[i + j];

         SumTR[i] += iATR(NULL,0,1,i + j); //Sum VI_Length values of the True Range by using a 1-period ATR

        }

     }

//---- Draw the indicator

   for(i = 1; i < Limit; i++)

     {

      PlusVI[i] = SumPlusVM[i] / SumTR[i];

      MinusVI[i] = SumMinusVM[i] / SumTR[i];

     }


   for(int k = 1; k < Limit; k++)

     {

      if(PlusVI[k]>MinusVI[k] && PlusVI[k+1]<MinusVI[k+1])

        {

         Alert("Call Indicator B ");

        }

      if(PlusVI[k]<MinusVI[k] && PlusVI[k+1]>MinusVI[k+1])

        {

         Alert("Call Indicator S ");

        }

     }

//----

   return(11110);

  }

//+------------------------------------------------------------------+----------------------------------+

//+------------------------------------------------------------------+
 
rajeshks1988 KS: Can anyone help me in converting following custom code to export advisor.

Don't try to do that. There are no buffers, no IndicatorCounted() or prev_calculated. No way to know if older bars have changed or been added (history update.)

Just get the value(s) of the indicator(s) into EA/indicator (using iCustom) and do what you want with it.

You should encapsulate your iCustom calls to make your code self-documenting.
          Detailed explanation of iCustom - MQL4 programming forum #33 2017.05.23

 
In future please post in the correct section
I will move your topic to the MQL4 and Metatrader 4 section.
New comment
Reason: