Indicators: #MAMA

[MetaQuotes]

#MAMA:

Indicator #MAMA.

Author: Collector

[[Deleted]]

Hello Collector,
are you sure you dont mix up the two buffers when you write the values just at the end of the code?
As I understand FAMA shall follow MAMA and I had to reverse them to get it right.

Tnx a lot for the contribution anyway!
Cheers.

[[Deleted]]

I concur. FAMA and MAMA are around the wrong way.

[William Roeder]

FABuffer[i] = MAMA[1]; 
MABuffer[i] = FAMA[1]; 

Yes the two buffers are reversed.

If you look at MAMA at Ehlers_Technical_Papers you will see that the ratcheting action described (and below shown) is not occurring in the posted indicator (and image.)

This is because this indicator was translated from EasyLanguage. The two Arctangent calls were transliterated to MathArctan.
How ever, Arctangent returns degrees but MathArctan returns radians.
To fix, replace the two calls with Arctangent and define:

double Arctangent(double v){ return 360.0/M_PI_2*MathArctan(v); }

[Quintos]

whroeder1:

Yes the two buffers are reversed.

If you look at MAMA at Ehlers_Technical_Papers you will see that the ratcheting action described (and below shown) is not occurring in the posted indicator (and image.)

This is because this indicator was translated from EasyLanguage. The two Arctangent calls were transliterated to MathArctan.
How ever, Arctangent returns degrees but MathArctan returns radians.
To fix, replace the two calls with Arctangent and define:

I've got an issue with this indicator.

I'm using the version including whroeder1's  suggested changes but when I add it to a chart, it correctly calculates for the existing bars but as soon as there is new data, it goes haywire:

Unfortunately I haven't been able to find the problem yet. Hopefully someone sees the problem.

I attached the .mq4 file.

Thanks.