Help with Indicator . . .

[Simon Gniadkowski]

Comments that do not relate to the "Using Technical indicator in an EA", have been moved into this topic.

[amin_mohammadi]

Hello everyone,

I'm using a custom indicator in my EA. the custom indicator's file is attached to this comment.

when I use this indicator in my EA it uses much more memory than other indicators such as Ichimoku.

the code in EA is as follow. AnalyzeDemandLine method gets called in OnTick() event.

//+------------------------------------------------------------------+
//|                                                TradeAnalyzer.mqh |
//|                                                   Amin Mohammadi |
//|                                              http://www.mql5.com |
//+------------------------------------------------------------------+
#property copyright "Amin Mohammadi"
#property link      "http://www.mql5.com"
#property version   "1.00"
#include "CurrencySymbols.mqh";
#include "OrderManagement.mqh";
#include "FractalIndicator.mqh";
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+

//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
struct returnedValue
  {
   double            LowTP;
   double            HighTP;
   double            HighDemandLine;
   double            LowDemandLine;
   double            open;
   int               result;

  };
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
class TradeAnalyzer : public CurrencySymbols
  {
private:
   double            Open[];
   double            MoutekiBuffer[];
   double            Ups[];
   double            Downs[];
   double            DemandLineHigh[];
   double            DemandLineLow[];
   double            TakeProfitHigh[];
   double            TakeProfitLow[];

   //   Creation          type;
   string            short_name;
   int               MoutekiHandle;
   int               amount;
   returnedValue value;

public:
   returnedValue     FillArraysFromBuffers(string symbol,ENUM_TIMEFRAMES tf);
   returnedValue     AnalyzeDemandLine(string symbol,ENUM_TIMEFRAMES tf);
                     TradeAnalyzer();
                    ~TradeAnalyzer();
  };
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
TradeAnalyzer::TradeAnalyzer()
  {
  

  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
returnedValue TradeAnalyzer::FillArraysFromBuffers(string symbol,ENUM_TIMEFRAMES tf)
  {
   returnedValue value;
   MoutekiHandle=iCustom(symbol,tf,"Examples\AminNonGraphicMouteki");

//
   amount=Bars(symbol,tf);
   if(MoutekiHandle==INVALID_HANDLE)
     {
      //--- tell about the failure and output the error code
      PrintFormat(symbol,EnumToString(tf),GetLastError());
      //--- the indicator is stopped early
      //return(INIT_FAILED);
     }

////--- normal initialization of the indicator 
   if(CopyBuffer(MoutekiHandle,0,0,amount,Ups)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(Ups,true);
   if(CopyBuffer(MoutekiHandle,1,0,amount,Downs)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(Downs,true);
   if(CopyBuffer(MoutekiHandle,4,0,amount,TakeProfitHigh)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(TakeProfitHigh,true);
   if(CopyBuffer(MoutekiHandle,5,0,amount,TakeProfitLow)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(TakeProfitLow,true);
   if(CopyBuffer(MoutekiHandle,3,0,amount,DemandLineHigh)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(DemandLineHigh,true);
   if(CopyBuffer(MoutekiHandle,2,0,amount,DemandLineLow)<0)
     {
      //--- if the copying fails, tell the error code
      PrintFormat("1.Failed to copy data from the Mouteki indicator, error code %d",GetLastError());
      //--- quit with zero result - it means that the indicator is considered as not calculated
      //return(false);
     }
   ArraySetAsSeries(DemandLineLow,true);
   ArraySetAsSeries(Open,true);
   CopyOpen(symbol,tf,0,Bars(symbol,tf),Open);
   value.HighDemandLine= DemandLineHigh[0];
   value.LowDemandLine = DemandLineLow[0];
   value.HighTP= TakeProfitHigh[0];
   value.LowTP = TakeProfitLow[0];
   value.open=Open[0];
   ArrayFree(Ups);
   ArrayFree(Downs);
   ArrayFree(DemandLineHigh);
   ArrayFree(DemandLineLow);
   ArrayFree(TakeProfitHigh);
   ArrayFree(TakeProfitLow);
   MoutekiHandle = 0;
   
   return value;
  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
returnedValue TradeAnalyzer::AnalyzeDemandLine(string symbol,ENUM_TIMEFRAMES tf)
  {
   
   value=FillArraysFromBuffers(symbol,tf);
   double openValue=value.open;
   double LowTD=value.LowDemandLine;
   double HighTD=value.HighDemandLine;
   if(openValue>LowTD)
     {
     value.result = 1;
      return value;
     }
   else if(openValue<HighTD)
     {
     value.result = 2;
      return value;
     }
     value.result = 0;
   return value;

  }
//+------------------------------------------------------------------+
//|                                                                  |
//+------------------------------------------------------------------+
TradeAnalyzer::~TradeAnalyzer()
  {
  }
//+------------------------------------------------------------------+

[Alain Verleyen]

So what ?