Indicator help

[Rajesh Kumar]

Dear friends

           i have an ema indicator. its repaint 

           please help me.

thanks.

       code:



#property copyright "Copyright © 2008, MetaQuotes Software Corp."
#property link      "http://www.metaquotes.net"


#property indicator_chart_window
#property indicator_buffers 2
#property indicator_color1 Blue
#property indicator_color2 Red

double CrossUp[];
double CrossDown[];
extern int FasterEMA = 3;
extern int SlowerEMA = 6;
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
int init()
  {
//---- indicators
   SetIndexStyle(0, DRAW_ARROW, EMPTY,2);
   SetIndexArrow(0, 233);
   SetIndexBuffer(0, CrossUp);
   SetIndexStyle(1, DRAW_ARROW, EMPTY,2);
   SetIndexArrow(1, 234);
   SetIndexBuffer(1, CrossDown);
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator deinitialization function                       |
//+------------------------------------------------------------------+
int deinit()
  {
//---- 

//----
   return(0);
  }
//+------------------------------------------------------------------+
//| Custom indicator iteration function                              |
//+------------------------------------------------------------------+
int start() {
   int limit, i, counter;
   double fasterEMAnow, slowerEMAnow, fasterEMAprevious, slowerEMAprevious, fasterEMAafter, slowerEMAafter;
   double Range, AvgRange;
   int counted_bars=IndicatorCounted();
//---- check for possible errors
   if(counted_bars<0) return(-1);
//---- last counted bar will be recounted
   if(counted_bars>0) counted_bars--;

   limit=Bars-counted_bars;
   
   for(i = 0; i <= limit; i++) {
   
      counter=i;
      Range=0;
      AvgRange=0;
      for (counter=i ;counter<=i+9;counter++)
      {
         AvgRange=AvgRange+MathAbs(High[counter]-Low[counter]);
      }
      Range=AvgRange/10;
       
      fasterEMAnow = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i);
      fasterEMAprevious = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i+1);
      fasterEMAafter = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i-1);

      slowerEMAnow = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i);
      slowerEMAprevious = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i+1);
      slowerEMAafter = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i-1);
      
      if ((fasterEMAnow > slowerEMAnow) && (fasterEMAprevious < slowerEMAprevious) && (fasterEMAafter > slowerEMAafter)) {
         CrossUp[i] = Low[i] - Range*0.5;
      }
      else if ((fasterEMAnow < slowerEMAnow) && (fasterEMAprevious > slowerEMAprevious) && (fasterEMAafter < slowerEMAafter)) {
         CrossDown[i] = High[i] + Range*0.5;
      }
   }
   return(0);
}

[Simon Gniadkowski]

Change this . .

for(i = 0; i <= limit; i++) {

to this . . .

for(i = 2; i <= limit; i++) {

and it won't repaint any more.

How is this suposed to work when i == 0 ? can you see into the future ?

fasterEMAafter = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE,   i-1  );

[Rajesh Kumar]

RaptorUK:

Change this . .

to this . . .

and it won't repaint any more.

How is this suposed to work when i == 0 ? can you see into the future ?

Dear RaptorUK.

i will check it ones .

thanks a lot.

[dineshydv]

Basically, you should check MA cross only on closed bar like below:

      fasterEMA_prv_bar1 = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i+1);
      fasterEMA_prv_bar2 = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i+2);
      //fasterEMAafter = iMA(NULL, 0, FasterEMA, 0, MODE_EMA, PRICE_CLOSE, i-1);

      slowerEMA_prv_bar1 = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i+1);
      slowerEMA_prv_bar1 = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i+2);
      //slowerEMAafter = iMA(NULL, 0, SlowerEMA, 0, MODE_EMA, PRICE_OPEN, i-1);
      
      if ((fasterEMA_prv_bar1 > slowerEMA_prv_bar1) && (fasterEMA_prv_bar2 < slowerEMA_prv_bar1) ) {
         CrossUp[i] = Low[i] - Range*0.5;
      }
      else if ((fasterEMA_prv_bar1 < slowerEMA_prv_bar1) && (fasterEMA_prv_bar2 > slowerEMA_prv_bar2) ) {
         CrossDown[i] = High[i] + Range*0.5;
      }

[Rajesh Kumar]

dineshydv:

Basically, you should check MA cross only on closed bar like below:

Dear Dineshydv

its variable

please how can i edit.

thanks.