Can some one look at this code and see what I did wrong

[[Deleted]]

I have added an alert I think any way but I am missing something and that is how do I get it to give an alert after the buy bar goes above 25 and the sell bar below 25 so that when this happens I get a alert with a pop up. Right now the alert just keeps going offf every 30 sec or so and no pop up. Please can someone help me.

#property  indicator_separate_window
#property  indicator_buffers 3
#property  indicator_color1  Blue
#property  indicator_color2  Lime
#property  indicator_color3  Red
#property indicator_level1 -0.25
#property indicator_level2 0.25

extern int period=10;
extern int bars_count=1000;
extern string AlertFileName = "alert.wav";

double         ExtBuffer0[];
double         ExtBuffer1[];
double         ExtBuffer2[];


int init()
  {
   
   
   SetIndexStyle(0,DRAW_NONE);
   SetIndexStyle(1,DRAW_HISTOGRAM);
   SetIndexStyle(2,DRAW_HISTOGRAM);
   //IndicatorDigits(Digits+1);

   SetIndexBuffer(0,ExtBuffer0);
   SetIndexBuffer(1,ExtBuffer1);
   SetIndexBuffer(2,ExtBuffer2);

   IndicatorShortName("Fisher");
   SetIndexLabel(1,NULL);
   SetIndexLabel(2,NULL);

   return(0);
  }


int start()
  {
   //int     period=10;
   int    limit;
   int    counted_bars=IndicatorCounted();
   double prev,current,old;
   double Value=0,Value1=0,Value2=0,Fish=0,Fish1=0,Fish2=0;
   double price;
   double MinL=0;
   double MaxH=0;  
   

   if(counted_bars>0) counted_bars--;
   if(bars_count > Bars || bars_count==0) 
   {
      limit=Bars - period;
   }else{
      limit=bars_count-period;
   }


   for(int i=limit; i>=0; i--)
    {  MaxH = High[Highest(NULL,0,MODE_HIGH,period,i)];
       MinL = Low[Lowest(NULL,0,MODE_LOW,period,i)];
      price = (High[i]+Low[i])/2;
      Value = 0.33*2*((price-MinL)/(MaxH-MinL)-0.5) + 0.67*Value1;     
      Value=MathMin(MathMax(Value,-0.999),0.999); 
      ExtBuffer0[i]=0.5*MathLog((1+Value)/(1-Value))+0.5*Fish1;
      Value1=Value;
      Fish1=ExtBuffer0[i];
      
    }


   bool up=true;
   for(i=limit-2; i>=0; i--)
     {
      current=ExtBuffer0[i];
      prev=ExtBuffer0[i+1];
           
      if (((current<0)&&(prev>0))||(current<0))   up= false;    
      if (((current>0)&&(prev<0))||(current>0))   up= true;
      
      if ((current<0)&&(prev>0))
         { 
         PlaySound(AlertFileName);
         }
      if ((current>0)&&(prev<0))
         {
         PlaySound(AlertFileName); 
         }
      if(!up)
        {
         ExtBuffer2[i]=current;
         ExtBuffer1[i]=0.0;
        }
        
       else
         {
          ExtBuffer1[i]=current;
          ExtBuffer2[i]=0.0;
         }
     }

   return(0);
   
  }

[gordon]

fxtrading24:
I have added an alert I think any way but I am missing something and that is how do I get it to give an alert after the buy bar goes above 25 and the sell bar below 25 so that when this happens I get a alert with a pop up. Right now the alert just keeps going offf every 30 sec or so and no pop up. Please can someone help me.

To have a pop-up add an Alert() function (https://docs.mql4.com/common/Alert). PlaySound(), as the name implies, only plays a sound but has no pop-up.

[[Deleted]]

gordon:

To have a pop-up add an Alert() function (https://docs.mql4.com/common/Alert). PlaySound(), as the name implies, only plays a sound but has no pop-up.

Thanks for the reply I just no nothing about coding and, and what all these mean. Coding is confusing to me I just am trying to get this indicator to work properly with an alert and pop up when the indicator bar goes above 25 or below 25 and display the pair. Example of pop up ( eurusd buy) when indicator bar goes above 25.

Thank You all

mike

[[Deleted]]

I still can't seem to get this to work, any ideas, I really like this indi just need the alerts to work.

Thanks

Mike

my email is

[e-mail]

[[Deleted]]

fxtrading24 wrote >>

I still can't seem to get this to work, any ideas, I really like this indi just need the alerts to work.

Thanks

Mike

my email is

[e-mail]

i have some great ea's [e-mail]

[[Deleted]]

selling short only

try one of my EA's. My selling short only has a profit factor of 170+

email me at [e-mail]

[[Deleted]]

selling short 170pf

profit power

832 profit factor

selling short 130 pf

I have these EA's.

I can externaly remote comand a MT4.

my email is [e-mail]