ForumSections

Indicator CCI MA convert to EA

New comment

Below is the indicator of CCI MA :

#property indicator_separate_window
#property indicator_buffers 2
#property indicator_color1 Red
#property indicator_color2 Lime
#property indicator_level1 -150000
#property indicator_level2 150000
 
//---- input parameters
extern int cci_p = 89;
extern int ma = 10;
extern int NumberOfBarsToCalculate = 10000;
 
//---- indicator buffers
double Buffer0[];
double Buffer1[];
double Ma[];
double Cci[];
 
//+------------------------------------------------------------------+
//| Custom indicator initialization function                         |
//+------------------------------------------------------------------+
  int init()
  {
   Comment("");
   IndicatorBuffers(4);
//---- indicator line
   SetIndexStyle(0,DRAW_LINE,STYLE_SOLID,2);
   SetIndexStyle(1,DRAW_LINE,STYLE_SOLID,2);
   SetIndexStyle(2,DRAW_NONE);
   SetIndexStyle(3,DRAW_NONE);
 
   SetIndexBuffer(0,Buffer0);
   SetIndexBuffer(1,Buffer1);
   SetIndexBuffer(2,Ma);
   SetIndexBuffer(3,Cci);
   
 
   IndicatorDigits(MarketInfo(Symbol(),MODE_DIGITS));
//----
 
   SetIndexEmptyValue(0,0);
   SetIndexEmptyValue(1,0);
   SetIndexEmptyValue(2,0);
   SetIndexEmptyValue(3,0);
//----
   return(0);
  }
 
 
int start() {
      string short_name;
      short_name = "CCI["+cci_p+"] \ MA => Max bars to count: |"+(Bars-1)+"| ";
      IndicatorShortName(short_name);
 
      int shift;
      double cci = 0;
      for(shift=NumberOfBarsToCalculate-1;shift>=0;shift--){
         Cci[shift] = iCCI(NULL,0,cci_p,PRICE_CLOSE,shift);    
         }
      for(shift=NumberOfBarsToCalculate-1;shift>=0;shift--){
         Ma[shift] = iMAOnArray(Cci,0,ma,0,MODE_EMA,shift);
         Buffer0[shift] = Cci[shift];
         Buffer1[shift] = Ma[shift];
         }

      return(0);
}
After I change it to EA as below, the data become inaccurate, how actually iMAOnArray work? how to solve this problem?
//---- input parameters
extern int  periodCCI               = 89;
extern int  periodMA                = 10;
extern int NumberOfBarsToCalculate = 10000;
double cci[100],ma[100];
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int start()
{
   int shift;
   for(shift=NumberOfBarsToCalculate-1;shift>=0;shift--)
   {
      cci[shift] = iCCI(NULL,0,periodCCI,PRICE_CLOSE,shift);
   } 
   for(shift=NumberOfBarsToCalculate-1;shift>=0;shift--)
   {
      ma[shift] = iMAOnArray(cci,0,periodMA,0,MODE_EMA,shift);
   }
   Comment("\nCCI(",periodCCI,") = ",cci[0],"\nMA(",periodMA,") = ",ma[0]);
}
Use ArraySetAsSeries function.

Indicators are calculated from left to right, You fill cci array from left to right but data should be reversed, i.e data from 0 (current) bar must be at the end!
New comment